Skip to content

Commit 37d23bc

Browse files
committed
Updated rapidjson to version that has header directory renamed
Updated pyproject.toml to fix version created via setuptools_scm Fixed version
1 parent 109db61 commit 37d23bc

File tree

7 files changed

+29
-26
lines changed

7 files changed

+29
-26
lines changed

CMakeLists.txt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ if (${PYTHON_PREFIX}_VERSION VERSION_LESS "3.9.0")
2121
endif()
2222

2323
set(PYRJ_TARGET "yggdrasil_python_rapidjson")
24-
set(PYRJ_SRC "${CMAKE_CURRENT_SOURCE_DIR}/rapidjson.cpp")
24+
set(PYRJ_SRC "${CMAKE_CURRENT_SOURCE_DIR}/yggdrasil_rapidjson.cpp")
2525

2626
if (PYRJ_ALTERNATE_MODULE)
2727
if (NOT PYRJ_LIBNAME)
@@ -70,7 +70,7 @@ if (PYRJ_ALTERNATE_MODULE)
7070
-P "${CMAKE_CURRENT_BINARY_DIR}/replace_module.cmake"
7171
DEPENDS "${src}" "${CMAKE_CURRENT_BINARY_DIR}/replace_module.cmake")
7272
endforeach()
73-
set(PYRJ_SRC "${CMAKE_CURRENT_BINARY_DIR}/rapidjson.cpp")
73+
set(PYRJ_SRC "${CMAKE_CURRENT_BINARY_DIR}/yggdrasil_rapidjson.cpp")
7474
add_custom_target(alt_rapidjson DEPENDS ${ALT_PYRJ_CPP})
7575
endif()
7676
endif()
@@ -108,7 +108,9 @@ target_compile_options(
108108
-DYGGDRASIL_RAPIDJSON_PYTHON_WRAPPER
109109
-DYGGDRASIL_RAPIDJSON_HAS_STDSTRING
110110
-DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION
111-
-D_USE_MATH_DEFINES)
111+
-D_USE_MATH_DEFINES
112+
-DYGGDRASIL_RAPIDJSON_PYTHON_VERSION=${CMAKE_PROJECT_VERSION}
113+
)
112114
if (YGGDRASIL_RAPIDJSON_EXACT_VERSION)
113115
target_compile_options(
114116
${PYRJ_TARGET} PUBLIC

cmake/ygg_options.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ option(YGGDRASIL_RAPIDJSON_CHECK_PYREFS "Turn on reference counting in rapidjson
7878

7979
message(STATUS "YGGDRASIL_RAPIDJSON_INCLUDE_DIRS = ${YGGDRASIL_RAPIDJSON_INCLUDE_DIRS}")
8080
if (NOT EXISTS ${YGGDRASIL_RAPIDJSON_INCLUDE_DIRS})
81-
message(FATAL_ERROR "RapidJSON sources not found: if you cloned "
81+
message(FATAL_ERROR "YggdrasilRapidJSON sources not found: if you cloned "
8282
" the git repository, you should initialize"
8383
" the rapidjson submodule as explained in the"
8484
" README.rst; in all other cases you may"

geometry.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010

1111
#include <Python.h>
1212

13-
#include "rapidjson/ply.h"
14-
#include "rapidjson/obj.h"
15-
#include "rapidjson/precision.h"
16-
#include "rapidjson/rapidjson.h"
13+
#include "yggdrasil_rapidjson/ply.h"
14+
#include "yggdrasil_rapidjson/obj.h"
15+
#include "yggdrasil_rapidjson/precision.h"
16+
#include "yggdrasil_rapidjson/yggdrasil_rapidjson.h"
1717

1818

1919
using namespace yggdrasil_rapidjson;
@@ -3845,7 +3845,7 @@ geom_module_exec(PyObject* m)
38453845
#define XSTRINGIFY(x) #x
38463846

38473847
if (PyModule_AddStringConstant(m, "__version__",
3848-
STRINGIFY(YGGDRASIL_PYTHON_RAPIDJSON_VERSION))
3848+
STRINGIFY(YGGDRASIL_RAPIDJSON_PYTHON_VERSION))
38493849
|| PyModule_AddStringConstant(m, "__author__",
38503850
"Meagan Lang <langmm.astro@gmail.com>")
38513851
|| PyModule_AddStringConstant(m, "__yggdrasil_rapidjson_version__",

pyproject.toml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,10 @@ editable.verbose = true
5656
# yggdrasil-rapidjson-stubs = "typings/rapidjson-stubs"
5757

5858
[tool.setuptools_scm]
59-
# version_file = "_version.py"
60-
write_to = "_version.py"
61-
git_describe_command = "git describe --tags --long --abbrev=0"
59+
version_file = "_version.py"
60+
# write_to = "_version.py"
61+
# scm.git.describe_command = "git describe --tags --long --abbrev=0"
62+
scm.git.describe_command = "git describe --tags --abbrev=0"
6263

6364
[tool.hatch.metadata.hooks.fancy-pypi-readme]
6465
content-type = "text/x-rst"

rapidjson

Submodule rapidjson updated 112 files

units.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
#include <Python.h>
1212

13-
#include "rapidjson/units.h"
14-
#include "rapidjson/precision.h"
15-
#include "rapidjson/rapidjson.h"
13+
#include "yggdrasil_rapidjson/units.h"
14+
#include "yggdrasil_rapidjson/precision.h"
15+
#include "yggdrasil_rapidjson/yggdrasil_rapidjson.h"
1616
#include <numpy/arrayobject.h>
1717
#include <numpy/ufuncobject.h>
1818

@@ -2711,7 +2711,7 @@ units_module_exec(PyObject* m)
27112711
#define XSTRINGIFY(x) #x
27122712

27132713
if (PyModule_AddStringConstant(m, "__version__",
2714-
STRINGIFY(YGGDRASIL_PYTHON_RAPIDJSON_VERSION))
2714+
STRINGIFY(YGGDRASIL_RAPIDJSON_PYTHON_VERSION))
27152715
|| PyModule_AddStringConstant(m, "__author__",
27162716
"Meagan Lang <langmm.astro@gmail.com>")
27172717
|| PyModule_AddStringConstant(m, "__yggdrasil_rapidjson_version__",

rapidjson.cpp renamed to yggdrasil_rapidjson.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include <locale.h>
1414

1515
#include <Python.h>
16-
#include "rapidjson/pythoncapi_compat.h"
16+
#include "yggdrasil_rapidjson/pythoncapi_compat.h"
1717
#include <datetime.h>
1818
#include <structmember.h>
1919

@@ -28,13 +28,13 @@
2828
#endif // YGGDRASIL_RAPIDJSON_PYTHON_WRAPPER
2929
#define PYRJ_TWO_PHASE_INIT
3030
// #define YGG_ENSURE_PY_GIL
31-
#include "rapidjson/pyrj.h"
32-
#include "rapidjson/reader.h"
33-
#include "rapidjson/schema.h"
34-
#include "rapidjson/stringbuffer.h"
35-
#include "rapidjson/writer.h"
36-
#include "rapidjson/prettywriter.h"
37-
#include "rapidjson/error/en.h"
31+
#include "yggdrasil_rapidjson/pyrj.h"
32+
#include "yggdrasil_rapidjson/reader.h"
33+
#include "yggdrasil_rapidjson/schema.h"
34+
#include "yggdrasil_rapidjson/stringbuffer.h"
35+
#include "yggdrasil_rapidjson/writer.h"
36+
#include "yggdrasil_rapidjson/prettywriter.h"
37+
#include "yggdrasil_rapidjson/error/en.h"
3838
#include "units.cpp"
3939
#include "geometry.cpp"
4040

@@ -7095,7 +7095,7 @@ module_exec(PyObject* m)
70957095
|| PyModule_AddIntConstant(m, "SIZE_OF_SIZE_T", SIZE_OF_SIZE_T)
70967096

70977097
|| PyModule_AddStringConstant(m, "__version__",
7098-
STRINGIFY(YGGDRASIL_PYTHON_RAPIDJSON_VERSION))
7098+
STRINGIFY(YGGDRASIL_RAPIDJSON_PYTHON_VERSION))
70997099
|| PyModule_AddStringConstant(m, "__author__",
71007100
"Meagan Lang <langmm@illinois.edu> [yggdrasil-rapidjson]"
71017101
", Ken Robbins <ken@kenrobbins.com> [rapidjson]"

0 commit comments

Comments
 (0)