Allow reconciling from multiple replicas#365
Merged
fahedouch merged 2 commits intocrossplane-contrib:mainfrom Apr 22, 2025
Merged
Allow reconciling from multiple replicas#365fahedouch merged 2 commits intocrossplane-contrib:mainfrom
fahedouch merged 2 commits intocrossplane-contrib:mainfrom
Conversation
tchinmai7
reviewed
Mar 14, 2025
fahedouch
reviewed
Mar 16, 2025
Collaborator
|
please sign your comments for valid DCO |
julsemaan
force-pushed
the
multi-replicas
branch
3 times, most recently
from
c4ce116 to
eaf826c
Compare
Contributor
Author
|
Thanks for the comments and the review. I've pushed adjustments and replied to your comments where appropriate. Let me know what you think. Thanks! |
fahedouch
reviewed
Mar 26, 2025
fahedouch
reviewed
Mar 26, 2025
julsemaan
force-pushed
the
multi-replicas
branch
2 times, most recently
from
cd6127d to
054d786
Compare
julsemaan
force-pushed
the
multi-replicas
branch
from
054d786 to
3128f0c
Compare
Signed-off-by: Julien Semaan <jul.semaan@gmail.com>
julsemaan
force-pushed
the
multi-replicas
branch
from
3128f0c to
ddbeac0
Compare
Signed-off-by: Julien Semaan <jul.semaan@gmail.com>
julsemaan
commented
Apr 22, 2025
|
What about documentation about how to use this feature ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This allows to run multiple replicas of provider-ansible within the same deployment and all replicas will use leases to select a shard on which they will work. Consistent hashing on the resource name is then used for shards to filter on which AnsibleRuns they should reconcile
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested