(chore) fix "make reviewable test" lint errors

Author: LAMRobinson

apis/cluster/object/v1alpha1/conversion.go

@@ -40,15 +40,15 @@ func (src *Object) ConvertTo(dstRaw conversion.Hub) error {
 		},
 	}
 
-	connectionDetails := []v1alpha2.ConnectionDetail{}
+	connectionDetails := make([]v1alpha2.ConnectionDetail, 0, len(src.Spec.ConnectionDetails))
 	for _, cd := range src.Spec.ConnectionDetails {
 		connectionDetails = append(connectionDetails, v1alpha2.ConnectionDetail{
 			ObjectReference:       cd.ObjectReference,
 			ToConnectionSecretKey: cd.ToConnectionSecretKey,
 		})
 	}
 
-	references := []v1alpha2.Reference{}
+	references := make([]v1alpha2.Reference, 0, len(src.Spec.References))
 	for _, r := range src.Spec.References {
 		ref := v1alpha2.Reference{}
 		if r.DependsOn != nil {
@@ -120,15 +120,15 @@ func (dst *Object) ConvertFrom(srcRaw conversion.Hub) error { //nolint:gocyclo /
 		},
 	}
 
-	connectionDetails := []ConnectionDetail{}
+	connectionDetails := make([]ConnectionDetail, 0, len(src.Spec.ConnectionDetails))
 	for _, cd := range src.Spec.ConnectionDetails {
 		connectionDetails = append(connectionDetails, ConnectionDetail{
 			ObjectReference:       cd.ObjectReference,
 			ToConnectionSecretKey: cd.ToConnectionSecretKey,
 		})
 	}
 
-	references := []Reference{}
+	references := make([]Reference, 0, len(src.Spec.References))
 	for _, r := range src.Spec.References {
 		ref := Reference{}
 		if r.DependsOn != nil {

pkg/kube/client/ssa/cache/extractor/gvk_parser_cache_test.go

@@ -112,7 +112,7 @@ func TestParserCacheManager(t *testing.T) {
 				if diff := cmp.Diff(len(cache.store), len(test.testClusterTargets[pc.GetUID()].gvs)); diff != "" {
 					t.Fatalf("cache length: -want length, +got length\n: %v", diff)
 				}
-				var cacheKeys []schema.GroupVersion
+				cacheKeys := make([]schema.GroupVersion, 0, len(cache.store))
 				for k := range cache.store {
 					cacheKeys = append(cacheKeys, k)
 				}