Table.dynamodb: add ref fields for kmsKeyArn#2002
Open
erhancagirici wants to merge 5 commits intocrossplane-contrib:mainfrom
Open
Table.dynamodb: add ref fields for kmsKeyArn#2002erhancagirici wants to merge 5 commits intocrossplane-contrib:mainfrom
erhancagirici wants to merge 5 commits intocrossplane-contrib:mainfrom
Conversation
Collaborator
Author
|
/test-examples="examples/dynamodb/cluster/v1beta2/table-with-encryption.yaml" |
erhancagirici
force-pushed
the
dynamodb-kmskey-ref
branch
from
6e1791d to
27d03bb
Compare
Collaborator
Author
|
/test-examples="examples/dynamodb/cluster/v1beta2/table-with-encryption.yaml" |
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
erhancagirici
force-pushed
the
dynamodb-kmskey-ref
branch
from
27d03bb to
c1a1055
Compare
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
erhancagirici
force-pushed
the
dynamodb-kmskey-ref
branch
from
c1a1055 to
19f072e
Compare
Collaborator
Author
|
/test-examples="examples/dynamodb/cluster/v1beta2/table-with-encryption.yaml" |
erhancagirici
requested review from
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
turkenf
force-pushed
the
dynamodb-kmskey-ref
branch
from
f92cbe0 to
024ffc1
Compare
Collaborator
|
/test-examples="examples/dynamodb/cluster/v1beta2/table-with-encryption.yaml" |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
turkenf
force-pushed
the
dynamodb-kmskey-ref
branch
from
024ffc1 to
a18cf02
Compare
Collaborator
|
/test-examples="examples/dynamodb/cluster/v1beta2/table-with-encryption.yaml" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds reference/selector fields for
serverSideEncryption.kmsKeyArnandreplica.kmsKeyArninTable/dynamodb.awsMR.I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
Uptest-examples/dynamodb/cluster/v1beta2/table-with-encryption.yaml -- Running