Upgrade to Terraform Provider Google v6.16.0#697
Upgrade to Terraform Provider Google v6.16.0#697rickard-von-essen wants to merge 46 commits intocrossplane-contrib:mainfrom
Conversation
|
Thanks for opening this PR @rickard-von-essen 🙏 Terraform provider major version bump to v6 requires many breaking changes, including field type changes. I don't think it will be easy to consider the impact of these changes and handle accordingly. So, please be patient if we were not able to invest enough resources into this PR in the near future. In order to make the reviewing easier, can you divide your work into commits? You can see a previous Terraform provider bump PR, in which we even committed There is a categorical change that we might want to consider how to handle: There are many resources which have a new |
c9c43f2 to
7859d44
Compare
2651c4d to
e78d986
Compare
|
/test-examples="examples/activedirectory/v1beta1/domain.yaml,examples/alloydb/v1beta2/backup.yaml,examples/alloydb/v1beta2/instance.yaml,examples/alloydb/v1beta2/cluster.yaml,examples/alloydb/v1beta1/backup.yaml,examples/alloydb/v1beta1/instance.yaml,examples/alloydb/v1beta1/cluster.yaml,examples/artifact/v1beta2/registryrepository.yaml,examples/artifact/v1beta1/registryrepository.yaml,examples/apigee/v1beta1/nataddress.yaml" |
|
/test-examples="examples/certificatemanager/v1beta2/certificate.yaml,examples/certificatemanager/v1beta1/certificate.yaml" |
|
/test-examples="examples/cloudbuild/v1beta2/workerpool.yaml" |
|
/test-examples="examples/cloudplatform/v1beta2/serviceaccountiammember.yaml,examples/cloudplatform/v1beta2/projectiammember.yaml,examples/cloudplatform/v1beta1/projectiamauditconfig.yaml,examples/cloudplatform/v1beta1/serviceaccountkey.yaml,examples/cloudplatform/v1beta1/projectservice.yaml,examples/cloudplatform/v1beta1/projectusageexportbucket.yaml,examples/cloudplatform/v1beta1/serviceaccountiammember.yaml,examples/cloudplatform/v1beta1/serviceaccount.yaml,examples/cloudplatform/v1beta1/projectiammember.yaml" |
|
/test-examples="examples/cloudrun/v1beta2/domainmapping.yaml,examples/cloudrun/v1beta2/v2job.yaml,examples/cloudrun/v1beta2/v2service.yaml,examples/cloudrun/v1beta1/domainmapping.yaml,examples/cloudrun/v1beta1/v2job.yaml,examples/cloudrun/v1beta1/v2service.yaml" |
815be5f to
c6d5cc0
Compare
|
Rebased |
|
@rickard-von-essen please consider updating PR to latest https://github.com/hashicorp/terraform-provider-google/releases |
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Resource: google_datastore_index is now removed in favor of google_firestore_index See https://github.com/hashicorp/terraform-provider-google/blob/v6.16.0/website/docs/guides/version_6_upgrade.html.markdown#resource-google_datastore_index-is-now-removed Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
google_identity_platform_project_default_config is removed in favor of google_identity_platform_project_config See https://github.com/hashicorp/terraform-provider-google/blob/v6.16.0/website/docs/guides/version_6_upgrade.html.markdown#resource-google_identity_platform_project_default_config-is-now-removed Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
…project_default_config, and datastore Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
deletion_protection was added in Terraform to help protect from remove/create a resource when you change an immutable attribute. This is not allowed in Crossplane so this is unnecessary. Also this overlap with Crossplane managementPolicy. Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
c6d5cc0 to
b9bdf30
Compare
|
Rebased again |
|
Bumped TPG to 6.33.0 here #782 |
|
See #782 (comment) |
Description of your changes
Update the underlaying Terraform Provider Goolge to version 6.16.0.
Depends on #695TODO:
provider-upjet-gcpmajor version? Suggest to create v2.0.0.docs/family/Upgrade_v2.mddeletionProtectionis mode to states and set tofalse, see 815be5fChanged resources:
activedirectory_*addeddeletionProtectionalloydbmultiple changesapigee_nataddressesaddedactivateflagartifactmultiple changesbigtable_appprofileaddedrowAffinitybigtable_tableaddedcolumnFamily.typebigquerymultiple changescertificatemanager: addedsanDnsnamescloudbuildaddedprivateServiceConnectcloudplatformmultiple changescloudrun_*multiple updatescloudtasksmultiple changescomposermultiple changescompute_*multiple updatescontainerattached_clusteraddsecurityPostureConfigcontainermultiple changescontaineraws_nodepooladdedkubeletConfigdataprocmultiple changesdatastore_indexremoveddialogflowcx_agentaddedloggingSettingsandspeechSettingsdnsaddedexternalEndpointsandhealthcheckfilestoremultiple changesiammultiple changesidentity_platform: Replacedproject_default_configwithconfigorgpolicy_policyaddedparametersmonitoringmultiple changesnetworkconnectivitymultiple changespubsubmultiple changesredis_clustermultiple changessourcerepoaddedcreateIgnoreAlreadyExiststorepositoryspannermultiple changesstoragemultiple changessqlmultiple changesworkflows_workflowsaddeddeletionProtectionvpcaccess_connectorupdated testTODO
Fixes #694
Fixes #656
Fixes #730
(probably) Fixes #685
These issues depends on this upgrade:
#785
#786
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Executed some sanity check with: