Allow specyfing if the namespace should be created (#13)

* Allow specyfing if the namespace should be created

Signed-off-by: Jonasz Łasut-Balcerzak <jonasz.lasut@gmail.com>

* Add default value for spec.parameters.namespace.name

Signed-off-by: Jonasz Łasut-Balcerzak <jonasz.lasut@gmail.com>

---------

Signed-off-by: Jonasz Łasut-Balcerzak <jonasz.lasut@gmail.com>

Author: jonasz-lasut

apis/resourcestatemetrics/definition.yaml

@@ -98,9 +98,20 @@ spec:
                         type: object
                     type: object
                   namespace:
-                    description: Kubernetes namespace where the resource-state-metrics controller
-                      and related resources will be deployed.
-                    type: string
+                    description: Kubernetes namespace configuration.
+                    properties:
+                      name:
+                        type: string
+                        description: Kubernetes namespace where the resource-state-metrics controller and related resources will be deployed.
+                        default: resource-state-metrics-system
+                      create:
+                        type: boolean
+                        description: Should the kubernetes namespace be provisioned.
+                        default: true
+                    type: object
+                    default:
+                      name: resource-state-metrics-system
+                      create: true
                   rbac:
                     description: RBAC configuration for the controller.
                     properties:

examples/xr-rsm.yaml

@@ -4,7 +4,6 @@ metadata:
   name: rsm
 spec:
   parameters:
-    namespace: resource-state-metrics
     rbac:
       allowedAPIGroups:
         - apiextensions.crossplane.io

functions/rsm/01-namespace.yaml.gotmpl

@@ -1,13 +1,15 @@
 # code: language=yaml
 # yaml-language-server: $schema=../../.up/json/models/index.schema.json
 
+{{- if $xr.spec.parameters.namespace.create }}
 ---
 apiVersion: v1
 kind: Namespace
 metadata:
-  name: {{ $xr.spec.parameters.namespace }}
+  name: {{ $xr.spec.parameters.namespace.name }}
   annotations:
     {{ setResourceNameAnnotation "namespace" }}
   labels:
     app.kubernetes.io/name: resource-state-metrics
     app.kubernetes.io/managed-by: crossplane
+{{- end }}

functions/rsm/02-serviceaccount.yaml.gotmpl

@@ -6,7 +6,7 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: resource-state-metrics
-  namespace: {{ $xr.spec.parameters.namespace }}
+  namespace: {{ $xr.spec.parameters.namespace.name }}
   annotations:
     {{ setResourceNameAnnotation "serviceaccount" }}
   labels:

functions/rsm/04-clusterrolebinding.yaml.gotmpl

@@ -20,4 +20,4 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: resource-state-metrics
-  namespace: {{ $xr.spec.parameters.namespace }}
+  namespace: {{ $xr.spec.parameters.namespace.name }}

functions/rsm/05-deployment.yaml.gotmpl

@@ -6,7 +6,7 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: resource-state-metrics
-  namespace: {{ $xr.spec.parameters.namespace }}
+  namespace: {{ $xr.spec.parameters.namespace.name }}
   annotations:
     {{ setResourceNameAnnotation "deployment" }}
   labels:

functions/rsm/06-service.yaml.gotmpl

@@ -6,7 +6,7 @@ apiVersion: v1
 kind: Service
 metadata:
   name: resource-state-metrics
-  namespace: {{ $xr.spec.parameters.namespace }}
+  namespace: {{ $xr.spec.parameters.namespace.name }}
   annotations:
     {{ setResourceNameAnnotation "service" }}
   labels:

tests/test-rsm/test.yaml.gotmpl

@@ -521,12 +521,12 @@ items:
         subjects:
           - kind: ServiceAccount
             name: resource-state-metrics
-            namespace: resource-state-metrics
+            namespace: resource-state-metrics-system
       - apiVersion: apps/v1
         kind: Deployment
         metadata:
           name: resource-state-metrics
-          namespace: resource-state-metrics
+          namespace: resource-state-metrics-system
           annotations:
             crossplane.io/composition-resource-name: deployment
           labels:
@@ -605,7 +605,7 @@ items:
       - apiVersion: v1
         kind: Namespace
         metadata:
-          name: resource-state-metrics
+          name: resource-state-metrics-system
           annotations:
             crossplane.io/composition-resource-name: namespace
           labels:
@@ -623,7 +623,7 @@ items:
         kind: Service
         metadata:
           name: resource-state-metrics
-          namespace: resource-state-metrics
+          namespace: resource-state-metrics-system
           annotations:
             crossplane.io/composition-resource-name: service
           labels:
@@ -654,7 +654,7 @@ items:
         automountServiceAccountToken: false
         metadata:
           name: resource-state-metrics
-          namespace: resource-state-metrics
+          namespace: resource-state-metrics-system
           annotations:
             crossplane.io/composition-resource-name: serviceaccount
           labels: