Skip to content

APIRecorder uses deprecated record.EventRecorder and drops filterFns #1057

Description

@rossigee

Problem

  1. NewAPIRecorder accepts record.EventRecorder which is deprecated in favor of events.EventRecorder (events.k8s.io/v1 API)
  2. WithAnnotations silently drops filterFns on every call due to not forwarding them to NewAPIRecorder
  3. FilterFn godoc incorrectly states return false prevents recording (should be return true)
  4. Eventf call passes empty action string, which can cause events.k8s.io/v1 rejection

Related PR

#1052

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions