cinder/manila: reduce creation of global variables

This is marked as "blocker code smell" by sonarcloud.io, however
we can fix this easily.

Author: dirkmueller

crowbar_framework/app/assets/javascripts/barclamps/cinder/application.js

@@ -31,7 +31,7 @@ $(document).ready(function($) {
   {
     //FIXME: right now, there's no good way to localize strings in js :/
     if (confirm("All volumes in the backend will be made unavailable; do you really want to delete this backend?")) {
-      volume_entry = $(this).data("volumeid");
+      var volume_entry = $(this).data("volumeid");
 
       // delete the backend entry from the attributes JSON
       $('#proposal_attributes').removeJsonAttribute('volumes/' + volume_entry);
@@ -66,8 +66,7 @@ $(document).ready(function($) {
         $('#backend_entries').html()
       );
     }
-    volumes = $('#proposal_attributes').readJsonAttribute('volumes', {});
-    volume_defaults = $('#proposal_attributes').readJsonAttribute('volume_defaults', {});
+    var volumes = $('#proposal_attributes').readJsonAttribute('volumes', {});
 
     // Render forms for backend list
     $('#cinder_backends').replaceWith(

crowbar_framework/app/assets/javascripts/barclamps/manila/application.js

@@ -29,7 +29,7 @@ $(document).ready(function($) {
   {
     //FIXME: right now, there's no good way to localize strings in js :/
     if (confirm("All shares in the backend will be made unavailable; do you really want to delete this backend?")) {
-      share_entry = $(this).data("shareid");
+      var share_entry = $(this).data("shareid");
 
       // delete the backend entry from the attributes JSON
       $('#proposal_attributes').removeJsonAttribute('shares/' + share_entry);
@@ -64,8 +64,7 @@ $(document).ready(function($) {
         $('#backend_entries').html()
       );
     }
-    shares = $('#proposal_attributes').readJsonAttribute('shares', {});
-    share_defaults = $('#proposal_attributes').readJsonAttribute('share_defaults', {});
+    var shares = $('#proposal_attributes').readJsonAttribute('shares', {});
 
     // Render forms for backend list
     $('#manila_backends').replaceWith(