fix(backups): reset backup path if not found

Author: zunderscore

src/backend/backup-manager.ts

@@ -182,6 +182,13 @@ class BackupManager {
             manualActivation ? "_manual" : ""
         }.${fileExtension}`;
 
+        if (!fs.existsSync(this._backupFolderPath)) {
+            logger.warn(`Backup path ${this._backupFolderPath} does not exist. Resetting to default.`);
+            SettingsManager.deleteSetting("BackupLocation");
+            this.updateBackupFolderPath();
+            SettingsManager.saveSetting("BackupLocationReset", true);
+        }
+
         const output = fs.createWriteStream(path.join(this._backupFolderPath, filename));
         const archive = archiver(fileExtension, {
             zlib: { level: 9 }

src/gui/app/app-main.js

@@ -261,7 +261,7 @@
     });
 
     app.controller("MainController", function($scope, $rootScope, $timeout, connectionService, utilityService,
-        settingsService, backupService, sidebarManager, logger, backendCommunicator, fontManager, ngToast, watcherCountService) {
+        settingsService, backupService, sidebarManager, logger, backendCommunicator, fontManager, ngToast, modalFactory) {
         $rootScope.showSpinner = true;
 
         $scope.fontAwesome5KitUrl = `https://kit.fontawesome.com/${secrets.fontAwesome5KitId}.js`;
@@ -516,6 +516,11 @@
             keyboard: false,
             backdrop: "static"
         });*/
+
+        if (settingsService.getSetting("BackupLocationReset") === true) {
+            modalFactory.showInfoModal("Your previous backup location could not be found. Backup location has been reset to default. You can change it in Settings > Backups.");
+            settingsService.deleteSetting("BackupLocationReset");
+        }
     });
 
     // This adds a filter that we can use for ng-repeat, useful when we want to paginate something

src/types/settings.ts

@@ -31,6 +31,7 @@ export type FirebotSettingsTypes = {
     BackupIgnoreResources: boolean;
     BackupKeepAll: boolean;
     BackupLocation: string;
+    BackupLocationReset: boolean;
     BackupOnceADay: boolean;
     BackupOnExit: boolean;
     ChatAlternateBackgrounds: boolean;
@@ -129,6 +130,7 @@ export const FirebotGlobalSettings: Partial<Record<keyof FirebotSettingsTypes, b
     BackupIgnoreResources: true,
     BackupKeepAll: true,
     BackupLocation: true,
+    BackupLocationReset: true,
     BackupOnceADay: true,
     BackupOnExit: true,
     DebugMode: true,
@@ -166,6 +168,7 @@ export const FirebotSettingsDefaults: FirebotSettingsTypes = {
     BackupIgnoreResources: true,
     BackupKeepAll: false,
     BackupLocation: undefined,
+    BackupLocationReset: false,
     BackupOnceADay: true,
     BackupOnExit: true,
     ChatAlternateBackgrounds: true,