Skip to content

Commit 12ba064

Browse files
feat!: add projectDescription to AI prompt completions and remove assistActionAiPromptId
Add projectDescription to the AI prompt completion resource, and remove the assistActionAiPromptId field from AiSetting now that the assist AI prompt action is gone. BREAKING CHANGE: AiSetting.assistActionAiPromptId is removed. Closes #376
1 parent f700c01 commit 12ba064

6 files changed

Lines changed: 6 additions & 7 deletions

File tree

src/main/java/com/crowdin/client/ai/model/AiPromptCompletionRequest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,6 @@ public static class AiPromptResource {
2020
private List<Long> filteredStringsIds;
2121
private Map<String, Object> overridePromptValues;
2222
private String customInstruction;
23+
private String projectDescription;
2324
}
2425
}

src/main/java/com/crowdin/client/ai/model/AiSetting.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
@Data
88
public class AiSetting {
99

10-
private Long assistActionAiPromptId;
1110
private Boolean showSuggestion;
1211
private Long editorSuggestionAiPromptId;
1312

src/test/java/com/crowdin/client/ai/AIApiTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,6 @@ public void downloadAiReportTest() {
330330
public void getAiSettingTest() {
331331
AiSetting aiSetting = this.getAiApi().getAiSetting(userId).getData();
332332
assertNotNull(aiSetting);
333-
assertEquals(aiSetting.getAssistActionAiPromptId(), 2);
334333
assertEquals(aiSetting.getEditorSuggestionAiPromptId(), 5);
335334
assertEquals(aiSetting.getShortcuts().size(), 1);
336335
}
@@ -339,11 +338,10 @@ public void getAiSettingTest() {
339338
public void editAiSettingTest() {
340339
PatchRequest request = new PatchRequest();
341340
request.setOp(PatchOperation.REPLACE);
342-
request.setPath("/assistActionAiPromptId");
341+
request.setPath("/editorSuggestionAiPromptId");
343342
ResponseObject<AiSetting> aiSettingResponseObject =
344343
this.getAiApi().editAiSetting(userId, Collections.singletonList(request));
345344
assertNotNull(aiSettingResponseObject.getData());
346-
assertEquals(aiSettingResponseObject.getData().getAssistActionAiPromptId(), 2);
347345
assertEquals(aiSettingResponseObject.getData().getEditorSuggestionAiPromptId(), 5);
348346
}
349347

@@ -477,6 +475,7 @@ public void generateAiPromptCompletionTest() {
477475
AiPromptCompletionRequest aiPromptCompletionRequest = new AiPromptCompletionRequest();
478476
AiPromptCompletionRequest.AiPromptResource aiPromptResource = new AiPromptCompletionRequest.AiPromptResource();
479477
aiPromptResource.setProjectId(123L);
478+
aiPromptResource.setProjectDescription("Mobile app project");
480479
aiPromptCompletionRequest.setResources(aiPromptResource);
481480
ResponseObject<AiPromptCompletionResponse.AiPromptCompletionData> response = this.getAiApi().generatePromptCompletion(userId, aiPromptId, aiPromptCompletionRequest);
482481
assertEquals(response.getData().getIdentifier(), completionId);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[
22
{
33
"op": "replace",
4-
"path": "/assistActionAiPromptId"
4+
"path": "/editorSuggestionAiPromptId"
55
}
66
]

src/test/resources/api/ai/getAiSettingResponse.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"data": {
3-
"assistActionAiPromptId": 2,
43
"editorSuggestionAiPromptId": 5,
54
"shortcuts": [
65
{
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"resources": {
3-
"projectId": 123
3+
"projectId": 123,
4+
"projectDescription": "Mobile app project"
45
}
56
}

0 commit comments

Comments
 (0)