Skip to content

Commit 08bc4a1

Browse files
committed
fix: code review
1 parent 106cc43 commit 08bc4a1

4 files changed

Lines changed: 11 additions & 2 deletions

File tree

crowdin_api/api_resources/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
"SourceStringsResource",
5252
"StoragesResource",
5353
"StringCommentsResource",
54-
"StyleGuidesResource",
5554
"StringTranslationsResource",
55+
"StyleGuidesResource",
5656
"TasksResource",
5757
"EnterpriseTasksResource",
5858
"TeamsResource",

crowdin_api/api_resources/style_guides/resource.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def list_style_guides(
4040
}
4141
params.update(self.get_page_params(limit=limit, offset=offset))
4242

43-
return self.requester.request(
43+
return self._get_entire_data(
4444
method="get",
4545
path=self.get_style_guides_path(),
4646
params=params,

crowdin_api/client.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,13 @@ def string_translations(self) -> api_resources.StringTranslationsResource:
362362

363363
@property
364364
def style_guides(self) -> api_resources.StyleGuidesResource:
365+
if self.PROJECT_ID:
366+
return api_resources.StyleGuidesResource(
367+
requester=self.get_api_requestor(),
368+
project_id=self.PROJECT_ID,
369+
page_size=self.PAGE_SIZE,
370+
)
371+
365372
return api_resources.StyleGuidesResource(
366373
requester=self.get_api_requestor(), page_size=self.PAGE_SIZE
367374
)

crowdin_api/tests/test_client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ def test_api_requestor_custom_values(self, m_APIRequester):
177177
("storages", "StoragesResource"),
178178
("string_comments", "StringCommentsResource"),
179179
("string_translations", "StringTranslationsResource"),
180+
("style_guides", "StyleGuidesResource"),
180181
("tasks", "TasksResource"),
181182
("translation_memory", "TranslationMemoryResource"),
182183
("translation_status", "TranslationStatusResource"),
@@ -253,6 +254,7 @@ class TestCrowdinClientEnterprise:
253254
("storages", "StoragesResource"),
254255
("string_comments", "StringCommentsResource"),
255256
("string_translations", "StringTranslationsResource"),
257+
("style_guides", "StyleGuidesResource"),
256258
("tasks", "EnterpriseTasksResource"),
257259
("teams", "TeamsResource"),
258260
("translation_memory", "TranslationMemoryResource"),

0 commit comments

Comments
 (0)