lint: unused parameters (#4049)

mmetc · web-flow · commit 4865e55efd72 · 2025-11-14T11:51:13.000+01:00
* lint: unused parameters

* lint print, spacing
diff --git a/cmd/crowdsec-cli/clidecision/import.go b/cmd/crowdsec-cli/clidecision/import.go
@@ -292,7 +292,7 @@ Raw values, standard input:
 
 $ echo "1.2.3.4" | cscli decisions import -i - --format values
 `,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			return cli.import_(cmd.Context(), input, duration, scope, reason, decisionType, batch, format)
 		},
 	}
diff --git a/cmd/crowdsec-cli/cliexplain/explain.go b/cmd/crowdsec-cli/cliexplain/explain.go
@@ -61,7 +61,7 @@ type cliExplain struct {
 	}
 }
 
-func New(cfg configGetter, configFilePath string) *cliExplain {
+func New(_ configGetter, configFilePath string) *cliExplain {
 	return &cliExplain{
 		configFilePath: configFilePath,
 	}
diff --git a/cmd/crowdsec-cli/clisetup/acquisition.go b/cmd/crowdsec-cli/clisetup/acquisition.go
@@ -13,8 +13,8 @@ import (
 	"github.com/hexops/gotextdiff/span"
 	"github.com/spf13/cobra"
 
-	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/core/args"
 	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/clisetup/setup"
+	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/core/args"
 )
 
 type acquisitionFlags struct {
@@ -54,7 +54,7 @@ cscli setup install-acquisition setup.yaml --dry-run
 `,
 		Args:              args.ExactArgs(1),
 		DisableAutoGenTag: true,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, args []string) error {
 			inputReader, err := maybeStdinFile(args[0])
 			if err != nil {
 				return err
@@ -100,7 +100,7 @@ func shouldOverwrite(path string, newContent []byte) (bool, error) {
 	oldContent, err := os.ReadFile(path)
 	if err != nil {
 		// File doesn't exist or unreadable, assume overwrite
-		return true, nil //nolint: nilerr
+		return true, nil //nolint:nilerr
 	}
 
 	if err := VerifyChecksum(bytes.NewReader(oldContent)); err == nil {
diff --git a/cmd/crowdsec-cli/clisetup/detect.go b/cmd/crowdsec-cli/clisetup/detect.go
@@ -8,8 +8,8 @@ import (
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 
-	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/core/args"
 	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/clisetup/setup"
+	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/core/args"
 	"github.com/crowdsecurity/crowdsec/pkg/csconfig"
 )
 
@@ -100,7 +100,7 @@ cscli setup detect --ignore whitelists
 `,
 		Args:              args.NoArgs,
 		DisableAutoGenTag: true,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
 
 			detectConfig, rulesFrom, err := f.detectConfig()
diff --git a/cmd/crowdsec-cli/clisetup/setup/exprsystem.go b/cmd/crowdsec-cli/clisetup/setup/exprsystem.go
@@ -17,7 +17,7 @@ func NewExprSystem(runningProcesses ProcessMap) *ExprSystem {
 }
 
 // ProcessRunning returns true if there is a running process with the given name.
-func (e *ExprSystem) ProcessRunning(ctx context.Context, processName string) (bool, error) {
+func (e *ExprSystem) ProcessRunning(_ context.Context, processName string) (bool, error) {
 	_, ok := e.runningProcesses[processName]
 
 	return ok, nil
diff --git a/cmd/crowdsec-cli/clisetup/setup/exprsystemd.go b/cmd/crowdsec-cli/clisetup/setup/exprsystemd.go
@@ -24,14 +24,14 @@ func NewExprSystemd(installedUnits UnitMap, logger logrus.FieldLogger) *ExprSyst
 }
 
 // UnitInstalled returns true if the unit is installed, even if it is not enabled or running.
-func (e *ExprSystemd) UnitInstalled(ctx context.Context, unitName string) (bool, error) {
+func (e *ExprSystemd) UnitInstalled(_ context.Context, unitName string) (bool, error) {
 	_, ok := e.installedUnits[unitName]
 
 	return ok, nil
 }
 
 // UnitConfig returns the value of the specified key in the unit's configuration.
-func (e *ExprSystemd) UnitConfig(ctx context.Context, unitName, key string) (string, error) {
+func (e *ExprSystemd) UnitConfig(_ context.Context, unitName, key string) (string, error) {
 	unit, ok := e.installedUnits[unitName]
 	if !ok {
 		// unit not installed
diff --git a/cmd/crowdsec-cli/clisetup/setup/exprwindows.go b/cmd/crowdsec-cli/clisetup/setup/exprwindows.go
@@ -10,6 +10,6 @@ func NewExprWindows() (*ExprWindows, error) {
 	return &ExprWindows{}, nil
 }
 
-func (*ExprWindows) ServiceEnabled(serviceName string) (bool, error) {
+func (*ExprWindows) ServiceEnabled(_ string) (bool, error) {
 	return false, nil
 }
diff --git a/cmd/crowdsec-cli/clisetup/validate.go b/cmd/crowdsec-cli/clisetup/validate.go
@@ -6,8 +6,8 @@ import (
 
 	"github.com/spf13/cobra"
 
-	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/core/args"
 	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/clisetup/setup"
+	"github.com/crowdsecurity/crowdsec/cmd/crowdsec-cli/core/args"
 )
 
 func (cli *cliSetup) newValidateCmd() *cobra.Command {
@@ -25,7 +25,7 @@ generated it through other means.`,
 
 		Args:              args.ExactArgs(1),
 		DisableAutoGenTag: true,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, args []string) error {
 			inputReader, err := maybeStdinFile(args[0])
 			if err != nil {
 				return err
diff --git a/cmd/crowdsec-cli/dashboard.go b/cmd/crowdsec-cli/dashboard.go
@@ -5,13 +5,14 @@ package main
 import (
 	"errors"
 	"fmt"
+	"os"
 
 	"github.com/spf13/cobra"
 )
 
-type cliDashboard struct {}
+type cliDashboard struct{}
 
-func NewCLIDashboard(cfg configGetter) *cliDashboard {
+func NewCLIDashboard(_ configGetter) *cliDashboard {
 	return &cliDashboard{}
 }
 
@@ -28,8 +29,8 @@ func (*cliDashboard) NewCommand() *cobra.Command {
 		},
 	}
 
-	cmd.SetHelpFunc(func(cmd *cobra.Command, args []string) {
-		fmt.Println(ErrDashboardDeprecated.Error())
+	cmd.SetHelpFunc(func(_ *cobra.Command, _ []string) {
+		fmt.Fprintln(os.Stdout, ErrDashboardDeprecated.Error())
 	})
 
 	return cmd
diff --git a/cmd/crowdsec-cli/doc.go b/cmd/crowdsec-cli/doc.go
@@ -2,6 +2,7 @@ package main
 
 import (
 	"fmt"
+	"os"
 	"path/filepath"
 	"strings"
 
@@ -28,12 +29,12 @@ func (cli cliDoc) NewCommand(rootCmd *cobra.Command) *cobra.Command {
 		Args:              args.NoArgs,
 		Hidden:            true,
 		DisableAutoGenTag: true,
-		RunE: func(_ *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, _ []string) error {
 			if err := doc.GenMarkdownTreeCustom(rootCmd, target, cli.filePrepender, cli.linkHandler); err != nil {
 				return fmt.Errorf("failed to generate cscli documentation: %w", err)
 			}
 
-			fmt.Println("Documentation generated in", target)
+			fmt.Fprintln(os.Stdout, "Documentation generated in", target)
 
 			return nil
 		},
diff --git a/pkg/csconfig/config.go b/pkg/csconfig/config.go
@@ -94,10 +94,7 @@ func NewConfig(configFile string, disableAgent bool, disableAPI bool, quiet bool
 		return nil, "", err
 	}
 
-	if err = cfg.loadHub(); err != nil {
-		return nil, "", err
-	}
-
+	cfg.loadHub()
 	cfg.loadCSCLI()
 
 	globalConfig = cfg
diff --git a/pkg/csconfig/hub.go b/pkg/csconfig/hub.go
@@ -2,19 +2,17 @@ package csconfig
 
 // LocalHubCfg holds the configuration for a local hub: where to download etc.
 type LocalHubCfg struct {
-	HubIndexFile   string	// Path to the local index file
-	HubDir         string	// Where the hub items are downloaded
-	InstallDir     string	// Where to install items
-	InstallDataDir string	// Where to install data
+	HubIndexFile   string // Path to the local index file
+	HubDir         string // Where the hub items are downloaded
+	InstallDir     string // Where to install items
+	InstallDataDir string // Where to install data
 }
 
-func (c *Config) loadHub() error {
+func (c *Config) loadHub() {
 	c.Hub = &LocalHubCfg{
 		HubIndexFile:   c.ConfigPaths.HubIndexFile,
 		HubDir:         c.ConfigPaths.HubDir,
 		InstallDir:     c.ConfigPaths.ConfigDir,
 		InstallDataDir: c.ConfigPaths.DataDir,
 	}
-
-	return nil
 }
diff --git a/pkg/csconfig/hub_test.go b/pkg/csconfig/hub_test.go
@@ -4,8 +4,6 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-
-	"github.com/crowdsecurity/go-cs-lib/cstest"
 )
 
 func TestLoadHub(t *testing.T) {
@@ -36,12 +34,7 @@ func TestLoadHub(t *testing.T) {
 
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
-			err := tc.input.loadHub()
-			cstest.RequireErrorContains(t, err, tc.expectedErr)
-			if tc.expectedErr != "" {
-				return
-			}
-
+			tc.input.loadHub()
 			assert.Equal(t, tc.expected, tc.input.Hub)
 		})
 	}
diff --git a/pkg/database/alertfilter.go b/pkg/database/alertfilter.go
@@ -172,7 +172,7 @@ func handleIncludeCapiFilter(value string, predicates *[]predicate.Alert) error
 			),
 		))
 	} else if value != "true" {
-		log.Errorf("invalid bool '%s' for include_capi", value)
+		log.Errorf("invalid bool %q for include_capi", value)
 	}
 
 	return nil
@@ -189,8 +189,8 @@ func alertPredicatesFromFilter(filter map[string][]string) ([]predicate.Alert, e
 
 	contains := true
 
-	/*if contains is true, return bans that *contains* the given value (value is the inner)
-	  else, return bans that are *contained* by the given value (value is the outer)*/
+	// if contains is true, return bans that *contains* the given value (value is the inner)
+	// else, return bans that are *contained* by the given value (value is the outer)
 
 	handleSimulatedFilter(filter, &predicates)
 	handleOriginFilter(filter, &predicates)
@@ -208,7 +208,7 @@ func alertPredicatesFromFilter(filter map[string][]string) ([]predicate.Alert, e
 			predicates = append(predicates, alert.SourceValueEQ(value[0]))
 		case "scenario":
 			predicates = append(predicates, alert.Or(
-				alert.ScenarioEQ(value[0]),  // match alerts with no decisions
+				alert.ScenarioEQ(value[0]), // match alerts with no decisions
 				alert.HasDecisionsWith(decision.ScenarioEQ(value[0])),
 			))
 		case "ip", "range":

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ Raw values, standard input:`
`292`	`292`
`293`	`293`	`$ echo "1.2.3.4" \| cscli decisions import -i - --format values`
`294`	`294`	`,
`295`		`- RunE: func(cmd *cobra.Command, args []string) error {`
	`295`	`+ RunE: func(cmd *cobra.Command, _ []string) error {`
`296`	`296`	`return cli.import_(cmd.Context(), input, duration, scope, reason, decisionType, batch, format)`
`297`	`297`	`},`
`298`	`298`	`}`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ type cliExplain struct {`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`
`64`		`-func New(cfg configGetter, configFilePath string) *cliExplain {`
	`64`	`+func New(_ configGetter, configFilePath string) *cliExplain {`
`65`	`65`	`return &cliExplain{`
`66`	`66`	`configFilePath: configFilePath,`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ func NewExprSystem(runningProcesses ProcessMap) *ExprSystem {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`// ProcessRunning returns true if there is a running process with the given name.`
`20`		`-func (e *ExprSystem) ProcessRunning(ctx context.Context, processName string) (bool, error) {`
	`20`	`+func (e *ExprSystem) ProcessRunning(_ context.Context, processName string) (bool, error) {`
`21`	`21`	`_, ok := e.runningProcesses[processName]`
`22`	`22`
`23`	`23`	`return ok, nil`
Original file line number	Diff line number	Diff line change
`@@ -24,14 +24,14 @@ func NewExprSystemd(installedUnits UnitMap, logger logrus.FieldLogger) *ExprSyst`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`// UnitInstalled returns true if the unit is installed, even if it is not enabled or running.`
`27`		`-func (e *ExprSystemd) UnitInstalled(ctx context.Context, unitName string) (bool, error) {`
	`27`	`+func (e *ExprSystemd) UnitInstalled(_ context.Context, unitName string) (bool, error) {`
`28`	`28`	`_, ok := e.installedUnits[unitName]`
`29`	`29`
`30`	`30`	`return ok, nil`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`// UnitConfig returns the value of the specified key in the unit's configuration.`
`34`		`-func (e *ExprSystemd) UnitConfig(ctx context.Context, unitName, key string) (string, error) {`
	`34`	`+func (e *ExprSystemd) UnitConfig(_ context.Context, unitName, key string) (string, error) {`
`35`	`35`	`unit, ok := e.installedUnits[unitName]`
`36`	`36`	`if !ok {`
`37`	`37`	`// unit not installed`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,6 @@ func NewExprWindows() (*ExprWindows, error) {`
`10`	`10`	`return &ExprWindows{}, nil`
`11`	`11`	`}`
`12`	`12`
`13`		`-func (*ExprWindows) ServiceEnabled(serviceName string) (bool, error) {`
	`13`	`+func (*ExprWindows) ServiceEnabled(_ string) (bool, error) {`
`14`	`14`	`return false, nil`
`15`	`15`	`}`