lint: modernize - enable slicessort, stringsseq (#4162)

* modernize: slices.Insert, slices.Sort

* modernize: strings.SplitSeq

Author: mmetc

.golangci.yml

@@ -267,9 +267,7 @@ linters:
         - fmtappendf
         - forvar
         - omitzero
-        - slicessort
         - stringsbuilder
-        - stringsseq
         - waitgroup
 
     nestif:

pkg/cwhub/sync.go

@@ -486,7 +486,7 @@ func insertInOrderNoCase(sl []string, value string) []string {
 		return strings.ToLower(sl[i]) >= strings.ToLower(value)
 	})
 
-	return append(sl[:i], append([]string{value}, sl[i:]...)...)
+	return slices.Insert(sl, i, value)
 }
 
 func removeDuplicates(sl []string) []string {

pkg/exprhelpers/helpers.go

@@ -15,6 +15,7 @@ import (
 	"path/filepath"
 	"reflect"
 	"regexp"
+	"slices"
 	"sort"
 	"strconv"
 	"strings"
@@ -707,9 +708,7 @@ func MedianInterval(params ...any) (any, error) {
 	}
 
 	// Sort intervals for median calculation
-	sort.Slice(intervals, func(i, j int) bool {
-		return intervals[i] < intervals[j]
-	})
+	slices.Sort(intervals)
 
 	n := len(intervals)
 	if n%2 == 1 {

pkg/hubtest/hubtest_item.go

@@ -295,7 +295,7 @@ func (*HubTestItem) ImprovedLogDisplay(crowdsecLogFile string) error {
 	failures := []string{}
 	general := []string{}
 
-	for _, line := range strings.Split(string(crowdsecLog), "\n") {
+	for line := range strings.SplitSeq(string(crowdsecLog), "\n") {
 		if strings.Contains(line, `"Evaluating operator: MATCH"`) {
 			success = append(success, line)
 		} else if strings.Contains(line, `"Evaluating operator: NO MATCH"`) {