fix ban flush (#277)

* fix ban flush by soft-deleting entries in database
* fix unit tests accordingly

Author: registergoofy

pkg/database/delete.go

@@ -25,6 +25,15 @@ func (c *Context) DeleteBan(target string) (int, error) {
 }
 
 func (c *Context) DeleteAll() error {
+	allBa := types.BanApplication{}
+	records := c.Db.Delete(&allBa)
+	if records.Error != nil {
+		return records.Error
+	}
+	return nil
+}
+
+func (c *Context) HardDeleteAll() error {
 	allBa := types.BanApplication{}
 	records := c.Db.Unscoped().Delete(&allBa)
 	if records.Error != nil {

pkg/database/delete_test.go

@@ -20,7 +20,7 @@ func TestNoCleanUpParams(t *testing.T) {
 		t.Fatalf("failed to create simple sqlite")
 	}
 
-	if err := ctx.DeleteAll(); err != nil {
+	if err := ctx.HardDeleteAll(); err != nil {
 		t.Fatalf("failed to flush existing bans")
 	}
 
@@ -78,7 +78,7 @@ func TestNoCleanUp(t *testing.T) {
 		t.Fatalf("failed to create simple sqlite")
 	}
 
-	if err := ctx.DeleteAll(); err != nil {
+	if err := ctx.HardDeleteAll(); err != nil {
 		t.Fatalf("failed to flush existing bans")
 	}
 
@@ -143,7 +143,7 @@ func TestCleanUpByCount(t *testing.T) {
 		t.Fatalf("failed to create simple sqlite")
 	}
 
-	if err := ctx.DeleteAll(); err != nil {
+	if err := ctx.HardDeleteAll(); err != nil {
 		t.Fatalf("failed to flush existing bans")
 	}
 
@@ -255,7 +255,7 @@ func TestCleanUpByAge(t *testing.T) {
 		t.Fatalf("failed to create simple sqlite")
 	}
 
-	if err := ctx.DeleteAll(); err != nil {
+	if err := ctx.HardDeleteAll(); err != nil {
 		t.Fatalf("failed to flush existing bans")
 	}
 

pkg/database/read_test.go

@@ -27,7 +27,7 @@ func TestFetchBans(t *testing.T) {
 		t.Fatalf("failed to create simple sqlite")
 	}
 
-	if err := ctx.DeleteAll(); err != nil {
+	if err := ctx.HardDeleteAll(); err != nil {
 		t.Fatalf("failed to flush existing bans")
 	}