fix 2808: show certificate path in "lapi status" (#4053)

* fix 2808: show certificate path in "lapi status"

* lint (print, space)

Author: mmetc

cmd/crowdsec-cli/clilapi/context.go

@@ -79,6 +79,7 @@ cscli lapi context add --value evt.Meta.source_ip --value evt.Meta.target_user
 				keySlice := strings.Split(v, ".")
 				key := keySlice[len(keySlice)-1]
 				value := []string{v}
+
 				if err := cli.addContext(key, value); err != nil {
 					return err
 				}
@@ -105,6 +106,7 @@ func (cli *cliLapi) newContextStatusCmd() *cobra.Command {
 		DisableAutoGenTag: true,
 		RunE: func(_ *cobra.Command, _ []string) error {
 			cfg := cli.cfg()
+
 			hub, err := require.Hub(cfg, nil)
 			if err != nil {
 				return err
@@ -145,6 +147,7 @@ cscli lapi context detect crowdsecurity/sshd-logs
 		DisableAutoGenTag: true,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			cfg := cli.cfg()
+
 			if !detectAll && len(args) == 0 {
 				_ = cmd.Help()
 				return errors.New("please provide parsers to detect or --all flag")
@@ -168,13 +171,16 @@ cscli lapi context detect crowdsecurity/sshd-logs
 			}
 
 			fieldByParsers := make(map[string][]string)
+
 			for _, node := range csParsers.Nodes {
 				if !detectAll && !slices.Contains(args, node.Name) {
 					continue
 				}
+
 				if !detectAll {
 					args = removeFromSlice(node.Name, args)
 				}
+
 				fieldByParsers[node.Name] = make([]string, 0)
 				fieldByParsers[node.Name] = detectNode(node, *csParsers.Ctx)
 
@@ -195,18 +201,22 @@ cscli lapi context detect crowdsecurity/sshd-logs
 			for k := range fieldByParsers {
 				parsersKey = append(parsersKey, k)
 			}
+
 			sort.Strings(parsersKey)
 
 			for _, k := range parsersKey {
 				if len(fieldByParsers[k]) == 0 {
 					continue
 				}
+
 				fmt.Fprintf(os.Stdout, "%s :\n\n", k)
 				values := fieldByParsers[k]
 				sort.Strings(values)
+
 				for _, value := range values {
 					fmt.Fprintf(os.Stdout, "  - %s\n", value)
 				}
+
 				fmt.Fprintln(os.Stdout)
 			}
 
@@ -254,6 +264,7 @@ func (cli *cliLapi) newContextCmd() *cobra.Command {
 					return fmt.Errorf("unable to load CrowdSec agent configuration: %w", err)
 				}
 			}
+
 			if cfg.DisableAgent {
 				return errors.New("agent is disabled and lapi context can only be used on the agent")
 			}

cmd/crowdsec-cli/clilapi/lapi.go

@@ -29,6 +29,7 @@ func (cli *cliLapi) NewCommand() *cobra.Command {
 			if err := cli.cfg().LoadAPIClient(); err != nil {
 				return fmt.Errorf("loading api client: %w", err)
 			}
+
 			return nil
 		},
 	}

cmd/crowdsec-cli/clilapi/register.go

@@ -85,7 +85,7 @@ func (cli *cliLapi) register(ctx context.Context, apiURL string, outputFile stri
 
 		log.Printf("Local API credentials written to '%s'", dumpFile)
 	} else {
-		fmt.Printf("%s\n", string(apiConfigDump))
+		fmt.Fprintln(os.Stdout, string(apiConfigDump))
 	}
 
 	if msg := reload.UserMessage(); msg != "" {

cmd/crowdsec-cli/clilapi/status.go

@@ -61,7 +61,14 @@ func (cli *cliLapi) Status(ctx context.Context, out io.Writer, hub *cwhub.Hub) e
 	cred := cfg.API.Client.Credentials
 
 	fmt.Fprintf(out, "Loaded credentials from %s\n", cfg.API.Client.CredentialsFilePath)
-	fmt.Fprintf(out, "Trying to authenticate with username %s on %s\n", cred.Login, cred.URL)
+
+	if cred.Login != "" {
+		fmt.Fprintf(out, "Trying to authenticate with username %q on %s\n", cred.Login, cred.URL)
+	}
+
+	if cred.CertPath != "" {
+		fmt.Fprintf(out, "Trying to authenticate with certificate %q on %s\n", cred.CertPath, cred.URL)
+	}
 
 	_, err := queryLAPIStatus(ctx, hub, cred.URL, cred.Login, cred.Password)
 	if err != nil {

cmd/crowdsec-cli/clilapi/utils.go

@@ -1,8 +1,10 @@
 package clilapi
 
 func removeFromSlice(val string, slice []string) []string {
-	var i int
-	var value string
+	var (
+		i int
+		value string
+	)
 
 	valueFound := false