Merge pull request #23 from morrowgarrett/fix/observe-format-default-json

fix(cli): default observe --format to json (closes #21)

Author: crowecawcaw

src/main.rs

@@ -64,8 +64,8 @@ enum Commands {
         #[arg(long)]
         include_hidden: bool,
 
-        /// Output format: xml (default) or json
-        #[arg(long, default_value = "xml")]
+        /// Output format: json (default) or xml
+        #[arg(long, default_value = "json")]
         format: String,
 
         /// Include platform-specific raw attributes in output

tests/e2e_cli.rs

@@ -204,3 +204,72 @@ fn test_scroll_without_element_no_state_needed() {
 
     result.stderr(predicate::str::contains("xdotool").or(predicate::str::contains("screenshot tool").or(predicate::str::contains("scroll"))));
 }
+
+// =============================================================================
+// Observe --format default (issue #21)
+// =============================================================================
+
+#[test]
+fn observe_help_documents_json_as_default() {
+    agent_desktop_cmd()
+        .args(["observe", "--help"])
+        .assert()
+        .success()
+        .stdout(predicate::str::contains("--format").and(predicate::str::contains("json")));
+}
+
+#[test]
+fn observe_default_format_is_json() {
+    // The default output of `observe` should be valid JSON, not XML.
+    // A weak "doesn't start with <" check is not enough — empty output
+    // or an error banner would pass that. We assert the command succeeds
+    // AND that stdout parses as a JSON value.
+    let output = agent_desktop_cmd()
+        .args(["observe"])
+        .output()
+        .expect("agent-desktop should run");
+
+    assert!(
+        output.status.success(),
+        "observe should exit 0; got status={:?}, stderr={}",
+        output.status,
+        String::from_utf8_lossy(&output.stderr)
+    );
+
+    let stdout = String::from_utf8_lossy(&output.stdout);
+    let trimmed = stdout.trim();
+    assert!(!trimmed.is_empty(), "expected non-empty stdout");
+
+    let parsed: serde_json::Value = serde_json::from_str(trimmed).unwrap_or_else(|e| {
+        panic!(
+            "expected JSON default but parse failed: {}\nfirst 200 chars of stdout: {}",
+            e,
+            &trimmed[..trimmed.len().min(200)]
+        )
+    });
+
+    // Sanity: the parsed value should be either an object with fields or a
+    // non-empty array. We don't assume a specific shape — that's another test.
+    let non_empty = match &parsed {
+        serde_json::Value::Object(m) => !m.is_empty(),
+        serde_json::Value::Array(a) => !a.is_empty(),
+        _ => true, // bare scalar is unexpected but technically valid JSON
+    };
+    assert!(non_empty, "parsed JSON should not be an empty object/array");
+}
+
+#[test]
+fn observe_with_explicit_xml_still_works() {
+    // Backward-compat: --format xml must still work after the default flip.
+    let output = agent_desktop_cmd()
+        .args(["observe", "--format", "xml"])
+        .output()
+        .expect("agent-desktop should run with explicit format");
+    let stdout = String::from_utf8_lossy(&output.stdout);
+    let trimmed = stdout.trim_start();
+    assert!(
+        trimmed.starts_with("<"),
+        "expected XML output with --format xml but got: {}",
+        &trimmed[..trimmed.len().min(80)]
+    );
+}