external editor won't launch if there's a space in the path to the editor

[seanmcd27]

install VS code
attempt to use it as the external editor
putting " around the editor path in the settings doesn't help

[crschnick]

do you pass any arguments as well?

[crschnick]

I know that with arguments, it might be a bit broken. But without any additional arguments, it should work fine. If it still does not, I think that vscode also has an option in the installer to be added to the PATH. Then, you should be able to just enter code.cmd and it should open

[seanmcd27]

i didn't pass any arguments. i tried several workaround with .cmd and symlinks with no luck. i haven't looked at the code. but my first suspect would be some shenanigans in the java framework spawn/exec support for windows. what i did in the meantime was use pdx-unlimiter to unpack the savefile and then cd to the directory and open the .json file directly with the editor. this allowed me to repair the corrupted state that was breaking my game and i'm operational again. thanks for writing the tool.

[crschnick]

Ok, so I had time to test this. I have spaces in my username myself on Windows, and this does not happen for me with VSCode.

What did you enter here?

The only reason I can think of is that maybe your cmd.exe is blocked? Pdxu tries to launch the editor with cmd /c "<editor>"