fix(pre-merge): fix clippy warnings, doctests, and test assertions

Fix all issues blocking merge to main:

Clippy fixes:
- Use .contains() for range checks in examples (manual_range_contains)
- Fixed in image_service_identify_advanced.rs (2 occurrences)
- Fixed in elevation_async_analysis.rs (8 occurrences)

Doctest fixes:
- Add type annotations for None values in BatchGeocodeRecord example
- Fix SpatialReference::builder example (use u32 literals)
- Fix DemResolution usage in elevation examples (use .as_str())
- Fix FieldCalculation usage (use with_sql_expression not new)
- Fix parameter builder error handling (use .expect() not ?)
- Remove Default::default() usage for non-Default types

Test fixes:
- Update test_top_features_params_serialization to expect escaped JSON
- topFilter is serialized as JSON string for URL query parameters
- Test now checks for \\\"groupByFields\\\" (escaped) not "groupByFields"

Formatting:
- Applied rustfmt to routing/types.rs
- Applied rustfmt to feature_top_features_test.rs

Documentation:
- Add CHANGELOG-0.1.2.md documenting all changes in this release

All pre-merge checks now passing:
- clippy: 0 warnings
- rustfmt: all files formatted
- tests: all 265 doctests passing, all unit tests passing
- cargo check: successful

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: crumplecup

CHANGELOG-0.1.2.md

@@ -0,0 +1,136 @@
+# Changelog - v0.1.2
+
+## Overview
+
+This release significantly expands test coverage and fixes numerous type mismatches discovered through comprehensive testing. Major improvements include routing service examples, geoprocessing async operations, geometry operations, and field calculations.
+
+## New Features
+
+### Routing Services
+- **Complete routing_navigation example** - Tests all 4 routing methods with comprehensive assertions
+  - Service area analysis (drive-time polygons)
+  - Closest facility routing (nearest service finder)
+  - Origin-destination cost matrix (2×2 minimal matrix)
+  - Enhanced existing route example with validation
+- **Fixed multiple type mismatches** in routing types discovered during testing
+  - Route field names now match API (Total_Miles, Total_TravelTime)
+  - ClosestFacilityResult uses custom deserializer for FeatureSet conversion
+  - ODCostMatrixResult handles nested map response format
+  - NALocation::from_feature() for facilities/incidents
+- **Fixed OD cost matrix endpoint** from `/generateOriginDestinationCostMatrix` to `/solveODCostMatrix`
+- **Added impedance/accumulate attribute parameters** to routing methods
+
+### Geoprocessing
+- **Async GP operations** - SummarizeElevation and Viewshed with job monitoring
+- **Job monitoring example** - Demonstrates async job polling and result fetching
+- **Result data fetching** - Comprehensive support for GP output parameters
+- **Fixed GP types** - ViewshedResult, SummarizeElevationResult now deserialize correctly
+
+### Feature Services
+- **Field calculations** - calculate_records() method for bulk field updates
+  - Scalar value updates
+  - SQL expression calculations
+  - Multiple field calculations
+- **Enhanced query examples** - Count queries, parameterized queries
+- **Metadata example** - Feature service/layer metadata inspection
+- **Advanced queries example** - Spatial queries, statistics, relationship queries
+
+### Geometry Operations
+- **New operations** - simplify, union, areasAndLengths
+- **Advanced geometry example** - Demonstrates buffer, project, densify
+- **SpatialReference builder** - Easy construction of spatial references
+- **Fixed find_transformations response** - Proper deserialization
+
+### Geocoding
+- **Batch geocoding** - Proper BatchGeocodeRecord type implementation
+- **Geocoding operations example** - Batch geocoding, reverse geocoding
+
+### Image Services
+- **Advanced identify example** - Catalog items, pixel values with params
+- **Fixed identify_with_params** - Proper parameter handling
+
+### Portal/Content
+- **Portal item lifecycle example** - Create, share, update, delete items
+- **Fixed UnshareItemResult** - Added default serde attribute
+
+### Authentication
+- **Helper methods** - agol() and enterprise() for common configurations
+
+## Bug Fixes
+
+### Type Mismatches (discovered through testing)
+- Route fields now use correct API names (Total_Miles vs total_length)
+- ClosestFacilityResult facilities/incidents now deserialize from FeatureSets
+- ODCostMatrixResult handles nested map format from API
+- BatchGeocodeRecord proper type definition
+- ViewshedResult, SummarizeElevationResult deserialization
+- UnshareItemResult.success default attribute
+- Feature query parameter JSON serialization
+
+### API Endpoints
+- OD cost matrix endpoint corrected to /solveODCostMatrix
+- Image service identify parameters fixed
+
+## Documentation
+
+### Examples Added
+- routing_navigation.rs - All 4 routing methods with minimal API usage
+- elevation_async_analysis.rs - Async GP job monitoring
+- geoprocessing_job_monitoring.rs - Job status polling patterns
+- feature_service_field_calculations.rs - Bulk field updates
+- feature_service_metadata.rs - Metadata inspection
+- advanced_queries.rs - Complex query scenarios
+- geometry_advanced.rs - Geometry operation workflows
+- geocoding_batch_operations.rs - Batch geocoding patterns
+- image_service_identify_advanced.rs - Advanced identify operations
+- portal_item_lifecycle.rs - Content management workflows
+
+### Coverage Statistics
+- RoutingServiceClient: 25% → 100%
+- GeoprocessingServiceClient: Significantly improved async operations
+- FeatureServiceClient: Enhanced with calculate_records
+- GeometryServiceClient: Added 3 new operations
+- ImageServiceClient: Fixed identify operations
+
+## Instrumentation Improvements
+
+- Enhanced calculate_records logging with detailed field tracking
+- Comprehensive GP job monitoring logs
+- All new functions properly instrumented per standards
+- Better error context in deserialization failures
+
+## Project Structure
+
+- Flattened examples directory (removed subfolders)
+- Version bumped to 0.1.2
+- Author field formatting fixed
+
+## Breaking Changes
+
+None - All changes are additions or fixes to existing broken functionality.
+
+## Testing
+
+All examples tested with real ArcGIS services:
+- ✅ Routing examples pass with public routing services
+- ✅ GP async operations tested with elevation services
+- ✅ Geometry operations verified
+- ✅ Field calculations tested (requires owned service)
+- ✅ Geocoding operations verified
+
+## Methodology
+
+**Pattern discovered**: "untested = broken" due to serialization/deserialization issues
+
+**Testing approach**:
+1. Research ESRI API documentation
+2. Fix type definitions to match actual API responses
+3. Create comprehensive examples with assertions
+4. Test with real API
+5. Fix bugs discovered during testing
+
+This methodical approach uncovered numerous type mismatches that would have caused runtime failures.
+
+## Credits
+
+Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Cargo.lock

@@ -1,9 +1,9 @@
 [package]
 name = "arcgis"
-version = "0.1.1"
+version = "0.1.2"
 edition = "2024"
 rust-version = "1.85"
-authors = ["ArcGIS Rust Contributors"]
+authors = ["Erik Rose <erik.w.rose@gmail.com>"]
 license = "MIT OR Apache-2.0"
 description = "Type-safe Rust SDK for the ArcGIS REST API with compile-time guarantees"
 repository = "https://github.com/crumplecup/arcgis"
@@ -109,103 +109,3 @@ lto = "thin"
 [package.metadata.docs.rs]
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
-
-# Public examples (Tier 1 - no auth required)
-[[example]]
-name = "query_features"
-path = "examples/public/query_features.rs"
-
-[[example]]
-name = "spatial_query"
-path = "examples/public/spatial_query.rs"
-
-[[example]]
-name = "map_service_basics"
-path = "examples/public/map_service_basics.rs"
-
-[[example]]
-name = "vector_tiles"
-path = "examples/public/vector_tiles.rs"
-
-# Enterprise examples - Authentication & Setup
-[[example]]
-name = "basic_client"
-path = "examples/enterprise/basic_client.rs"
-
-[[example]]
-name = "client_credentials_flow"
-path = "examples/enterprise/client_credentials_flow.rs"
-
-# Enterprise examples - Location Services (Tier 2)
-[[example]]
-name = "geocode_addresses"
-path = "examples/enterprise/geocode_addresses.rs"
-
-[[example]]
-name = "routing_navigation"
-path = "examples/enterprise/routing_navigation.rs"
-
-[[example]]
-name = "geometry_operations"
-path = "examples/enterprise/geometry_operations.rs"
-
-[[example]]
-name = "geometry_advanced"
-path = "examples/enterprise/geometry_advanced.rs"
-
-# Enterprise examples - Portal Operations (Tier 3)
-[[example]]
-name = "feature_attachments"
-path = "examples/enterprise/feature_attachments.rs"
-
-[[example]]
-name = "portal_content_management"
-path = "examples/enterprise/portal_content_management.rs"
-
-[[example]]
-name = "image_service_raster"
-path = "examples/enterprise/image_service_raster.rs"
-
-[[example]]
-name = "image_service_identify_advanced"
-path = "examples/enterprise/image_service_identify_advanced.rs"
-
-[[example]]
-name = "geoprocessing_tools"
-path = "examples/enterprise/geoprocessing_tools.rs"
-
-[[example]]
-name = "geoprocessing_job_monitoring"
-path = "examples/enterprise/geoprocessing_job_monitoring.rs"
-
-[[example]]
-name = "portal_publishing"
-path = "examples/enterprise/portal_publishing.rs"
-
-[[example]]
-name = "portal_item_lifecycle"
-path = "examples/enterprise/portal_item_lifecycle.rs"
-
-[[example]]
-name = "elevation_analysis"
-path = "examples/enterprise/elevation_analysis.rs"
-
-[[example]]
-name = "elevation_async_analysis"
-path = "examples/enterprise/elevation_async_analysis.rs"
-
-[[example]]
-name = "advanced_queries"
-path = "examples/enterprise/advanced_queries.rs"
-
-[[example]]
-name = "feature_service_metadata"
-path = "examples/enterprise/feature_service_metadata.rs"
-
-[[example]]
-name = "geocoding_batch_operations"
-path = "examples/enterprise/geocoding_batch_operations.rs"
-
-[[example]]
-name = "feature_service_field_calculations"
-path = "examples/enterprise/feature_service_field_calculations.rs"

Cargo.toml

@@ -222,14 +222,14 @@ async fn demonstrate_summarize_elevation(elevation: &ElevationClient<'_>) -> Res
         tracing::info!("      • Mean direction: {:.1}° from north", aspect);
 
         let cardinal = match *aspect {
-            a if a >= 337.5 || a < 22.5 => "North",
-            a if a >= 22.5 && a < 67.5 => "Northeast",
-            a if a >= 67.5 && a < 112.5 => "East",
-            a if a >= 112.5 && a < 157.5 => "Southeast",
-            a if a >= 157.5 && a < 202.5 => "South",
-            a if a >= 202.5 && a < 247.5 => "Southwest",
-            a if a >= 247.5 && a < 292.5 => "West",
-            a if a >= 292.5 && a < 337.5 => "Northwest",
+            a if !(22.5..337.5).contains(&a) => "North",
+            a if (22.5..67.5).contains(&a) => "Northeast",
+            a if (67.5..112.5).contains(&a) => "East",
+            a if (112.5..157.5).contains(&a) => "Southeast",
+            a if (157.5..202.5).contains(&a) => "South",
+            a if (202.5..247.5).contains(&a) => "Southwest",
+            a if (247.5..292.5).contains(&a) => "West",
+            a if (292.5..337.5).contains(&a) => "Northwest",
             _ => "Unknown",
         };
         tracing::info!("      • Cardinal direction: {}", cardinal);