Skip to content

[Request] Move SmartTriggers remote management into CryostatAgentMXBean #826

@andrewazores

Description

@andrewazores

See cryostatio/cryostat-core#625

https://github.com/cryostatio/cryostat-agent/blob/main/src/main/java/io/cryostat/agent/mxbean/CryostatAgentMXBeanImpl.java

The Cryostat Agent has an internal MXBean implementation for itself which is automatically registered when the Agent starts up. Currently this MXBean is only used to enhance the JVM hash ID uniqueness, but we can extend this with more functionality. Smart Triggers remote management seems like it could be a good fit, since the triggers themselves are simple String definitions or may become serializable POJOs, so operations to add/remove/update them should fit well with M(X)Beans.

This would remove the need for specific Smart Triggers-related methods from the JFRConnection internal API, and is a general pattern that we can follow in the future for any other similar cases so that the cryostat-core internal API does not need to be updated so frequently - changes can be done at the Cryostat and Cryostat Agent ends of the chain and transparently pass over the cryostat-core in between.

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreRefactor, rename, cleanup, etc.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions