-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
breaking changeThis change (potentially) breaks API compatibility and requires corresponding changes elsewhereThis change (potentially) breaks API compatibility and requires corresponding changes elsewherechoreRefactor, rename, cleanup, etc.Refactor, rename, cleanup, etc.good first issueGood for newcomersGood for newcomers
Description
Descriptions
I think some prefixes (e.g. cryostat.) should be added to local storage keys in order to distinguish them from others, which might be used third-party packages. Furthermore, since Cryostat and Grafana are now being served at the same origin, they do share the same local storage.
I guess it would avoid any potential collision that could result in the console crashing.
References
cryostat-web/src/app/utils/LocalStorage.ts
Lines 17 to 43 in 7ceb432
| export enum LocalStorageKey { | |
| ASSET_VERSION, | |
| FEATURE_LEVEL, | |
| DASHBOARD_CFG, | |
| AUTOMATED_ANALYSIS_FILTERS, | |
| TARGET_RECORDING_FILTERS, | |
| CREDENTIAL_LOCATION, | |
| TARGET, | |
| TARGET_FAVORITES, | |
| TOPOLOGY_GRAPH_POSITONS, | |
| TOPOLOGY_NODE_POSITIONS, | |
| TOPOLOGY_CONFIG, | |
| TOPOLOGY_FILTERS, | |
| AUTO_REFRESH_ENABLED, | |
| AUTO_REFRESH_PERIOD, | |
| AUTO_REFRESH_UNITS, | |
| AUTOMATED_ANALYSIS_RECORDING_CONFIG, | |
| CHART_CONTROLLER_CONFIG, | |
| DELETION_DIALOGS_ENABLED, | |
| VISIBLE_NOTIFICATIONS_COUNT, | |
| NOTIFICATIONS_ENABLED, | |
| WEBSOCKET_DEBOUNCE_MS, | |
| DATETIME_FORMAT, | |
| MATCH_EXPRES_VIS_GRAPH_POSITIONS, | |
| MATCH_EXPRES_VIS_NODE_POSITIONS, | |
| THEME, | |
| } |
andrewazores
Metadata
Metadata
Assignees
Labels
breaking changeThis change (potentially) breaks API compatibility and requires corresponding changes elsewhereThis change (potentially) breaks API compatibility and requires corresponding changes elsewherechoreRefactor, rename, cleanup, etc.Refactor, rename, cleanup, etc.good first issueGood for newcomersGood for newcomers
Type
Projects
Status
Backlog
Status
Backlog