better operation for cleanup

Author: andrewazores

src/main/java/io/cryostat/recordings/RecordingHelper.java

@@ -1303,7 +1303,7 @@ private Uni<String> uploadToJFRDatasource(Path recordingPath)
                         });
     }
 
-    Optional<Path> getRecordingCopyPath(
+    private Optional<Path> getRecordingCopyPath(
             JFRConnection connection, Target target, String recordingName) throws Exception {
         return connection.getService().getAvailableRecordings().stream()
                 .filter(recording -> recording.getName().equals(recordingName))

src/main/java/io/cryostat/reports/ReportsServiceImpl.java

@@ -87,12 +87,12 @@ public Uni<Map<String, AnalysisResult>> reportFor(ActiveRecording recording, Str
             logger.tracev(
                     "inprocess reportFor active recording {0} {1}",
                     recording.target.jvmId, recording.remoteId);
-            return process(stream, filter).invoke(safeClose(stream));
+            return process(stream, filter).eventually(safeClose(stream));
         } else {
             logger.tracev(
                     "sidecar reportFor active recording {0} {1}",
                     recording.target.jvmId, recording.remoteId);
-            return fireRequest(stream, filter).invoke(safeClose(stream));
+            return fireRequest(stream, filter).eventually(safeClose(stream));
         }
     }
 
@@ -103,7 +103,7 @@ public Uni<Map<String, AnalysisResult>> reportFor(
             if (!useSidecar()) {
                 InputStream stream = helper.getArchivedRecordingStream(jvmId, filename);
                 logger.tracev("inprocess reportFor archived recording {0} {1}", jvmId, filename);
-                return process(stream, filter).invoke(safeClose(stream));
+                return process(stream, filter).eventually(safeClose(stream));
             } else if (usePresignedSidecar()) {
                 logger.tracev(
                         "sidecar reportFor presigned archived recording {0} {1}", jvmId, filename);
@@ -112,7 +112,7 @@ public Uni<Map<String, AnalysisResult>> reportFor(
             } else {
                 InputStream stream = helper.getArchivedRecordingStream(jvmId, filename);
                 logger.tracev("sidecar reportFor archived recording {0} {1}", jvmId, filename);
-                return fireRequest(stream, filter).invoke(safeClose(stream));
+                return fireRequest(stream, filter).eventually(safeClose(stream));
             }
         } catch (URISyntaxException e) {
             logger.error(e);