Use HytaleLogger instead of System.out.println for proper logging

cryptobench · claude · cryptobench · commit a9586098ccdd · 2026-01-13T21:13:50.000+01:00
- Pass HytaleLogger from plugin to all protection systems
- Use flogger API (atInfo().log(), atWarning().log(), etc.)
- Logs now appear in server console and log files properly

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/src/main/java/com/landclaims/LandClaims.java b/src/main/java/com/landclaims/LandClaims.java
@@ -73,28 +73,27 @@ public void setup() {
         protectionListener.register(getEventRegistry());
 
         // Register ECS block protection systems
-        System.out.println("[LandClaims] Registering ECS block protection systems...");
+        getLogger().atInfo().log("Registering ECS block protection systems...");
         try {
             // Register entity event types first - required before systems can receive these events
             getEntityStoreRegistry().registerEntityEventType(DamageBlockEvent.class);
             getEntityStoreRegistry().registerEntityEventType(BreakBlockEvent.class);
             getEntityStoreRegistry().registerEntityEventType(PlaceBlockEvent.class);
             getEntityStoreRegistry().registerEntityEventType(UseBlockEvent.Pre.class);
-            System.out.println("[LandClaims] Registered entity event types");
+            getLogger().atInfo().log("Registered entity event types");
 
             // Now register the systems that handle these events
-            getEntityStoreRegistry().registerSystem(new BlockDamageProtectionSystem(claimManager));
-            System.out.println("[LandClaims] Registered BlockDamageProtectionSystem");
-            getEntityStoreRegistry().registerSystem(new BlockBreakProtectionSystem(claimManager));
-            System.out.println("[LandClaims] Registered BlockBreakProtectionSystem");
-            getEntityStoreRegistry().registerSystem(new BlockPlaceProtectionSystem(claimManager));
-            System.out.println("[LandClaims] Registered BlockPlaceProtectionSystem");
-            getEntityStoreRegistry().registerSystem(new BlockUseProtectionSystem(claimManager));
-            System.out.println("[LandClaims] Registered BlockUseProtectionSystem");
-            System.out.println("[LandClaims] All ECS systems registered successfully!");
+            getEntityStoreRegistry().registerSystem(new BlockDamageProtectionSystem(claimManager, getLogger()));
+            getLogger().atInfo().log("Registered BlockDamageProtectionSystem");
+            getEntityStoreRegistry().registerSystem(new BlockBreakProtectionSystem(claimManager, getLogger()));
+            getLogger().atInfo().log("Registered BlockBreakProtectionSystem");
+            getEntityStoreRegistry().registerSystem(new BlockPlaceProtectionSystem(claimManager, getLogger()));
+            getLogger().atInfo().log("Registered BlockPlaceProtectionSystem");
+            getEntityStoreRegistry().registerSystem(new BlockUseProtectionSystem(claimManager, getLogger()));
+            getLogger().atInfo().log("Registered BlockUseProtectionSystem");
+            getLogger().atInfo().log("All ECS systems registered successfully!");
         } catch (Exception e) {
-            System.out.println("[LandClaims] ERROR registering ECS systems: " + e.getMessage());
-            e.printStackTrace();
+            getLogger().atSevere().withCause(e).log("ERROR registering ECS systems");
         }
     }
 
diff --git a/src/main/java/com/landclaims/listeners/ClaimProtectionListener.java b/src/main/java/com/landclaims/listeners/ClaimProtectionListener.java
@@ -1,6 +1,7 @@
 package com.landclaims.listeners;
 
 import com.hypixel.hytale.event.EventRegistry;
+import com.hypixel.hytale.logger.HytaleLogger;
 import com.hypixel.hytale.math.vector.Vector3i;
 import com.hypixel.hytale.server.core.entity.entities.Player;
 import com.hypixel.hytale.server.core.event.events.player.PlayerConnectEvent;
@@ -22,6 +23,7 @@
 public class ClaimProtectionListener {
     private final LandClaims plugin;
     private final ClaimManager claimManager;
+    private final HytaleLogger logger;
 
     // Track player interactions - shared with BlockProtectionSystems
     // Key: "x,y,z" block position, Value: PlayerInteraction data
@@ -33,6 +35,7 @@ public class ClaimProtectionListener {
     public ClaimProtectionListener(LandClaims plugin) {
         this.plugin = plugin;
         this.claimManager = plugin.getClaimManager();
+        this.logger = plugin.getLogger();
     }
 
     /**
@@ -62,8 +65,7 @@ private void onPlayerInteract(PlayerInteractEvent event) {
         InteractionType actionType = event.getActionType();
 
         // DEBUG: Log all interactions
-        System.out.println("[LandClaims] PlayerInteractEvent: player=" + playerId +
-            " block=" + targetBlock + " action=" + actionType);
+        logger.atInfo().log("PlayerInteractEvent: player=%s block=%s action=%s", playerId, targetBlock, actionType);
 
         // Track this interaction for ECS event correlation
         String blockKey = getBlockKey(targetBlock);
@@ -76,11 +78,12 @@ private void onPlayerInteract(PlayerInteractEvent event) {
 
         // Check if this location is protected - cancel ALL interactions in protected areas
         boolean canInteract = claimManager.canInteract(playerId, worldName, targetBlock.getX(), targetBlock.getZ());
-        System.out.println("[LandClaims] canInteract=" + canInteract + " for chunk " +
-            (int)Math.floor(targetBlock.getX()/16.0) + "," + (int)Math.floor(targetBlock.getZ()/16.0));
+        int chunkX = (int)Math.floor(targetBlock.getX()/16.0);
+        int chunkZ = (int)Math.floor(targetBlock.getZ()/16.0);
+        logger.atInfo().log("canInteract=%s for chunk %d,%d", canInteract, chunkX, chunkZ);
 
         if (!canInteract) {
-            System.out.println("[LandClaims] CANCELLING PlayerInteractEvent");
+            logger.atInfo().log("CANCELLING PlayerInteractEvent");
             event.setCancelled(true);
         }
     }
diff --git a/src/main/java/com/landclaims/systems/BlockBreakProtectionSystem.java b/src/main/java/com/landclaims/systems/BlockBreakProtectionSystem.java
@@ -6,6 +6,7 @@
 import com.hypixel.hytale.component.Store;
 import com.hypixel.hytale.component.query.Query;
 import com.hypixel.hytale.component.system.EntityEventSystem;
+import com.hypixel.hytale.logger.HytaleLogger;
 import com.hypixel.hytale.math.vector.Vector3i;
 import com.hypixel.hytale.server.core.entity.entities.Player;
 import com.hypixel.hytale.server.core.event.events.ecs.BreakBlockEvent;
@@ -20,10 +21,12 @@
 public class BlockBreakProtectionSystem extends EntityEventSystem<EntityStore, BreakBlockEvent> {
 
     private final ClaimManager claimManager;
+    private final HytaleLogger logger;
 
-    public BlockBreakProtectionSystem(ClaimManager claimManager) {
+    public BlockBreakProtectionSystem(ClaimManager claimManager, HytaleLogger logger) {
         super(BreakBlockEvent.class);
         this.claimManager = claimManager;
+        this.logger = logger;
     }
 
     @Override
@@ -37,29 +40,29 @@ public void handle(int entityIndex, ArchetypeChunk<EntityStore> chunk, Store<Ent
         Vector3i targetBlock = event.getTargetBlock();
         if (targetBlock == null) return;
 
-        System.out.println("[LandClaims] BreakBlockEvent fired at " + targetBlock);
+        logger.atInfo().log("BreakBlockEvent fired at %s", targetBlock);
 
         // Get the entity that triggered this event
         Ref<EntityStore> entityRef = chunk.getReferenceTo(entityIndex);
         if (entityRef == null) {
-            System.out.println("[LandClaims] BreakBlock: No entity ref");
+            logger.atWarning().log("BreakBlock: No entity ref");
             return;
         }
 
         // Get the Player component from the entity
         Player player = store.getComponent(entityRef, Player.getComponentType());
         if (player == null) {
-            System.out.println("[LandClaims] BreakBlock: Entity is not a player");
+            logger.atFine().log("BreakBlock: Entity is not a player");
             return;
         }
 
         UUID playerId = player.getUuid();
         String worldName = "default"; // TODO: Get actual world name
 
-        System.out.println("[LandClaims] BreakBlock: Player " + playerId + " at " + targetBlock);
+        logger.atInfo().log("BreakBlock: Player %s at %s", playerId, targetBlock);
 
         if (!claimManager.canInteract(playerId, worldName, targetBlock.getX(), targetBlock.getZ())) {
-            System.out.println("[LandClaims] CANCELLING BreakBlockEvent for player " + playerId);
+            logger.atInfo().log("CANCELLING BreakBlockEvent for player %s", playerId);
             event.setCancelled(true);
         }
     }
diff --git a/src/main/java/com/landclaims/systems/BlockDamageProtectionSystem.java b/src/main/java/com/landclaims/systems/BlockDamageProtectionSystem.java
@@ -6,6 +6,7 @@
 import com.hypixel.hytale.component.Store;
 import com.hypixel.hytale.component.query.Query;
 import com.hypixel.hytale.component.system.EntityEventSystem;
+import com.hypixel.hytale.logger.HytaleLogger;
 import com.hypixel.hytale.math.vector.Vector3i;
 import com.hypixel.hytale.server.core.entity.entities.Player;
 import com.hypixel.hytale.server.core.event.events.ecs.DamageBlockEvent;
@@ -21,10 +22,12 @@
 public class BlockDamageProtectionSystem extends EntityEventSystem<EntityStore, DamageBlockEvent> {
 
     private final ClaimManager claimManager;
+    private final HytaleLogger logger;
 
-    public BlockDamageProtectionSystem(ClaimManager claimManager) {
+    public BlockDamageProtectionSystem(ClaimManager claimManager, HytaleLogger logger) {
         super(DamageBlockEvent.class);
         this.claimManager = claimManager;
+        this.logger = logger;
     }
 
     @Override
@@ -56,7 +59,7 @@ public void handle(int entityIndex, ArchetypeChunk<EntityStore> chunk, Store<Ent
         if (!claimManager.canInteract(playerId, worldName, targetBlock.getX(), targetBlock.getZ())) {
             // Only log on first damage attempt to reduce spam
             if (event.getCurrentDamage() < 0.1f) {
-                System.out.println("[LandClaims] CANCELLING DamageBlockEvent for player " + playerId + " at " + targetBlock);
+                logger.atInfo().log("CANCELLING DamageBlockEvent for player %s at %s", playerId, targetBlock);
             }
             event.setCancelled(true);
         }
diff --git a/src/main/java/com/landclaims/systems/BlockPlaceProtectionSystem.java b/src/main/java/com/landclaims/systems/BlockPlaceProtectionSystem.java
@@ -6,6 +6,7 @@
 import com.hypixel.hytale.component.Store;
 import com.hypixel.hytale.component.query.Query;
 import com.hypixel.hytale.component.system.EntityEventSystem;
+import com.hypixel.hytale.logger.HytaleLogger;
 import com.hypixel.hytale.math.vector.Vector3i;
 import com.hypixel.hytale.server.core.entity.entities.Player;
 import com.hypixel.hytale.server.core.event.events.ecs.PlaceBlockEvent;
@@ -20,10 +21,12 @@
 public class BlockPlaceProtectionSystem extends EntityEventSystem<EntityStore, PlaceBlockEvent> {
 
     private final ClaimManager claimManager;
+    private final HytaleLogger logger;
 
-    public BlockPlaceProtectionSystem(ClaimManager claimManager) {
+    public BlockPlaceProtectionSystem(ClaimManager claimManager, HytaleLogger logger) {
         super(PlaceBlockEvent.class);
         this.claimManager = claimManager;
+        this.logger = logger;
     }
 
     @Override
@@ -37,29 +40,29 @@ public void handle(int entityIndex, ArchetypeChunk<EntityStore> chunk, Store<Ent
         Vector3i targetBlock = event.getTargetBlock();
         if (targetBlock == null) return;
 
-        System.out.println("[LandClaims] PlaceBlockEvent fired at " + targetBlock);
+        logger.atInfo().log("PlaceBlockEvent fired at %s", targetBlock);
 
         // Get the entity that triggered this event
         Ref<EntityStore> entityRef = chunk.getReferenceTo(entityIndex);
         if (entityRef == null) {
-            System.out.println("[LandClaims] PlaceBlock: No entity ref");
+            logger.atWarning().log("PlaceBlock: No entity ref");
             return;
         }
 
         // Get the Player component from the entity
         Player player = store.getComponent(entityRef, Player.getComponentType());
         if (player == null) {
-            System.out.println("[LandClaims] PlaceBlock: Entity is not a player");
+            logger.atFine().log("PlaceBlock: Entity is not a player");
             return;
         }
 
         UUID playerId = player.getUuid();
         String worldName = "default"; // TODO: Get actual world name
 
-        System.out.println("[LandClaims] PlaceBlock: Player " + playerId + " at " + targetBlock);
+        logger.atInfo().log("PlaceBlock: Player %s at %s", playerId, targetBlock);
 
         if (!claimManager.canInteract(playerId, worldName, targetBlock.getX(), targetBlock.getZ())) {
-            System.out.println("[LandClaims] CANCELLING PlaceBlockEvent for player " + playerId);
+            logger.atInfo().log("CANCELLING PlaceBlockEvent for player %s", playerId);
             event.setCancelled(true);
         }
     }
diff --git a/src/main/java/com/landclaims/systems/BlockUseProtectionSystem.java b/src/main/java/com/landclaims/systems/BlockUseProtectionSystem.java
@@ -6,6 +6,7 @@
 import com.hypixel.hytale.component.Store;
 import com.hypixel.hytale.component.query.Query;
 import com.hypixel.hytale.component.system.EntityEventSystem;
+import com.hypixel.hytale.logger.HytaleLogger;
 import com.hypixel.hytale.math.vector.Vector3i;
 import com.hypixel.hytale.server.core.entity.InteractionContext;
 import com.hypixel.hytale.server.core.entity.entities.Player;
@@ -21,10 +22,12 @@
 public class BlockUseProtectionSystem extends EntityEventSystem<EntityStore, UseBlockEvent.Pre> {
 
     private final ClaimManager claimManager;
+    private final HytaleLogger logger;
 
-    public BlockUseProtectionSystem(ClaimManager claimManager) {
+    public BlockUseProtectionSystem(ClaimManager claimManager, HytaleLogger logger) {
         super(UseBlockEvent.Pre.class);
         this.claimManager = claimManager;
+        this.logger = logger;
     }
 
     @Override
@@ -38,35 +41,35 @@ public void handle(int entityIndex, ArchetypeChunk<EntityStore> chunk, Store<Ent
         Vector3i targetBlock = event.getTargetBlock();
         if (targetBlock == null) return;
 
-        System.out.println("[LandClaims] UseBlockEvent.Pre fired at " + targetBlock);
+        logger.atInfo().log("UseBlockEvent.Pre fired at %s", targetBlock);
 
         // Get player directly from the InteractionContext
         InteractionContext context = event.getContext();
         if (context == null) {
-            System.out.println("[LandClaims] UseBlock: No context available");
+            logger.atWarning().log("UseBlock: No context available");
             return;
         }
 
         Ref<EntityStore> entityRef = context.getEntity();
         if (entityRef == null) {
-            System.out.println("[LandClaims] UseBlock: No entity ref in context");
+            logger.atWarning().log("UseBlock: No entity ref in context");
             return;
         }
 
         // Get the Player component from the entity
         Player player = store.getComponent(entityRef, Player.getComponentType());
         if (player == null) {
-            System.out.println("[LandClaims] UseBlock: Entity is not a player");
+            logger.atFine().log("UseBlock: Entity is not a player");
             return;
         }
 
         UUID playerId = player.getUuid();
         String worldName = "default"; // TODO: Get actual world name
 
-        System.out.println("[LandClaims] UseBlock: Player " + playerId + " at " + targetBlock);
+        logger.atInfo().log("UseBlock: Player %s at %s", playerId, targetBlock);
 
         if (!claimManager.canInteract(playerId, worldName, targetBlock.getX(), targetBlock.getZ())) {
-            System.out.println("[LandClaims] CANCELLING UseBlockEvent.Pre for player " + playerId);
+            logger.atInfo().log("CANCELLING UseBlockEvent.Pre for player %s", playerId);
             event.setCancelled(true);
         }
     }
