Fix command arguments to use positional args

Change commands to use RequiredArg for positional arguments:
- AdminSetSubcommand: setting and value are now positional
- TrustSubcommand: player is now positional, level remains optional
- UntrustSubcommand: player is now positional

This fixes "wrong number of required arguments" errors when users
type commands like "/easyclaims admin set starting 4"

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: cryptobench

src/main/java/com/easyclaims/commands/subcommands/TrustSubcommand.java

@@ -6,6 +6,7 @@
 import com.hypixel.hytale.server.core.NameMatching;
 import com.hypixel.hytale.server.core.command.system.CommandContext;
 import com.hypixel.hytale.server.core.command.system.arguments.system.OptionalArg;
+import com.hypixel.hytale.server.core.command.system.arguments.system.RequiredArg;
 import com.hypixel.hytale.server.core.command.system.arguments.types.ArgTypes;
 import com.hypixel.hytale.server.core.command.system.basecommands.AbstractPlayerCommand;
 import com.hypixel.hytale.server.core.universe.PlayerRef;
@@ -21,7 +22,7 @@
 
 public class TrustSubcommand extends AbstractPlayerCommand {
     private final EasyClaims plugin;
-    private final OptionalArg<String> playerArg;
+    private final RequiredArg<String> playerArg;
     private final OptionalArg<String> levelArg;
 
     private static final Color GREEN = new Color(85, 255, 85);
@@ -31,7 +32,7 @@ public class TrustSubcommand extends AbstractPlayerCommand {
     public TrustSubcommand(EasyClaims plugin) {
         super("trust", "Trust a player to interact with your claims");
         this.plugin = plugin;
-        this.playerArg = withOptionalArg("player", "Player name to trust", ArgTypes.STRING);
+        this.playerArg = withRequiredArg("player", "Player name to trust", ArgTypes.STRING);
         this.levelArg = withOptionalArg("level", "Trust level (use/container/workstation/build)", ArgTypes.STRING);
         requirePermission("easyclaims.use");
     }
@@ -45,12 +46,6 @@ protected void execute(@Nonnull CommandContext ctx,
         String playerInput = playerArg.get(ctx);
         String levelInput = levelArg.get(ctx);
 
-        if (playerInput == null || playerInput.isEmpty()) {
-            playerData.sendMessage(Message.raw("Usage: /easyclaims trust <player> [level]").color(RED));
-            playerData.sendMessage(Message.raw("Levels: use, container, workstation, build").color(GRAY));
-            return;
-        }
-
         TrustLevel level = TrustLevel.BUILD;
         if (levelInput != null && !levelInput.isEmpty()) {
             level = TrustLevel.fromString(levelInput);

src/main/java/com/easyclaims/commands/subcommands/UntrustSubcommand.java

@@ -5,7 +5,7 @@
 import com.hypixel.hytale.server.core.Message;
 import com.hypixel.hytale.server.core.NameMatching;
 import com.hypixel.hytale.server.core.command.system.CommandContext;
-import com.hypixel.hytale.server.core.command.system.arguments.system.OptionalArg;
+import com.hypixel.hytale.server.core.command.system.arguments.system.RequiredArg;
 import com.hypixel.hytale.server.core.command.system.arguments.types.ArgTypes;
 import com.hypixel.hytale.server.core.command.system.basecommands.AbstractPlayerCommand;
 import com.hypixel.hytale.server.core.universe.PlayerRef;
@@ -24,7 +24,7 @@
 
 public class UntrustSubcommand extends AbstractPlayerCommand {
     private final EasyClaims plugin;
-    private final OptionalArg<String> playerArg;
+    private final RequiredArg<String> playerArg;
 
     private static final Color GREEN = new Color(85, 255, 85);
     private static final Color RED = new Color(255, 85, 85);
@@ -33,7 +33,7 @@ public class UntrustSubcommand extends AbstractPlayerCommand {
     public UntrustSubcommand(EasyClaims plugin) {
         super("untrust", "Remove trust from a player");
         this.plugin = plugin;
-        this.playerArg = withOptionalArg("player", "Player name to untrust", ArgTypes.STRING);
+        this.playerArg = withRequiredArg("player", "Player name to untrust", ArgTypes.STRING);
         requirePermission("easyclaims.use");
     }
 
@@ -45,11 +45,6 @@ protected void execute(@Nonnull CommandContext ctx,
                           @Nonnull World world) {
         String playerInput = playerArg.get(ctx);
 
-        if (playerInput == null || playerInput.isEmpty()) {
-            playerData.sendMessage(Message.raw("Usage: /easyclaims untrust <player>").color(RED));
-            return;
-        }
-
         PlayerClaims claims = plugin.getClaimManager().getPlayerClaims(playerData.getUuid());
         UUID targetId = null;
         String targetName = playerInput;

src/main/java/com/easyclaims/commands/subcommands/admin/AdminSetSubcommand.java

@@ -4,7 +4,7 @@
 import com.hypixel.hytale.component.Store;
 import com.hypixel.hytale.server.core.Message;
 import com.hypixel.hytale.server.core.command.system.CommandContext;
-import com.hypixel.hytale.server.core.command.system.arguments.system.OptionalArg;
+import com.hypixel.hytale.server.core.command.system.arguments.system.RequiredArg;
 import com.hypixel.hytale.server.core.command.system.arguments.types.ArgTypes;
 import com.hypixel.hytale.server.core.command.system.basecommands.AbstractPlayerCommand;
 import com.hypixel.hytale.server.core.universe.PlayerRef;
@@ -18,8 +18,8 @@
 
 public class AdminSetSubcommand extends AbstractPlayerCommand {
     private final EasyClaims plugin;
-    private final OptionalArg<String> keyArg;
-    private final OptionalArg<String> valueArg;
+    private final RequiredArg<String> keyArg;
+    private final RequiredArg<Integer> valueArg;
 
     private static final Color GOLD = new Color(255, 170, 0);
     private static final Color GREEN = new Color(85, 255, 85);
@@ -28,10 +28,10 @@ public class AdminSetSubcommand extends AbstractPlayerCommand {
     private static final Color GRAY = new Color(170, 170, 170);
 
     public AdminSetSubcommand(EasyClaims plugin) {
-        super("set", "Change a server claim setting");
+        super("set", "Change a server claim setting (starting/perhour/max/buffer)");
         this.plugin = plugin;
-        this.keyArg = withOptionalArg("key", "Setting name (starting/perhour/max/buffer)", ArgTypes.STRING);
-        this.valueArg = withOptionalArg("value", "New value", ArgTypes.STRING);
+        this.keyArg = withRequiredArg("setting", "Setting name (starting/perhour/max/buffer)", ArgTypes.STRING);
+        this.valueArg = withRequiredArg("value", "New value", ArgTypes.INTEGER);
         requirePermission("easyclaims.admin");
     }
 
@@ -42,28 +42,7 @@ protected void execute(@Nonnull CommandContext ctx,
                           @Nonnull PlayerRef playerData,
                           @Nonnull World world) {
         String key = keyArg.get(ctx);
-        String valueStr = valueArg.get(ctx);
-
-        if (key == null || valueStr == null) {
-            playerData.sendMessage(Message.raw("How to change settings:").color(GOLD));
-            playerData.sendMessage(Message.raw("  /easyclaims admin set starting <number>").color(YELLOW));
-            playerData.sendMessage(Message.raw("    How many claims new players start with").color(GRAY));
-            playerData.sendMessage(Message.raw("  /easyclaims admin set perhour <number>").color(YELLOW));
-            playerData.sendMessage(Message.raw("    Extra claims earned per hour played").color(GRAY));
-            playerData.sendMessage(Message.raw("  /easyclaims admin set max <number>").color(YELLOW));
-            playerData.sendMessage(Message.raw("    Maximum claims any player can have").color(GRAY));
-            playerData.sendMessage(Message.raw("  /easyclaims admin set buffer <number>").color(YELLOW));
-            playerData.sendMessage(Message.raw("    Buffer zone in chunks around claims (0 = disabled)").color(GRAY));
-            return;
-        }
-
-        int value;
-        try {
-            value = Integer.parseInt(valueStr);
-        } catch (NumberFormatException e) {
-            playerData.sendMessage(Message.raw("Please enter a number! Example: /easyclaims admin set max 100").color(RED));
-            return;
-        }
+        int value = valueArg.get(ctx);
 
         PluginConfig config = plugin.getPluginConfig();
         switch (key.toLowerCase()) {