Merge pull request #539 from crytic/fix/target-not-found-error

fix: raise error when target is not file/directory

Author: 0xalpharush

crytic_compile/crytic_compile.py

@@ -697,7 +697,7 @@ def compile_all(target: str, **kwargs: str) -> List[CryticCompile]:
         **kwargs: optional arguments. Used: "solc_standard_json"
 
     Raises:
-        NotImplementedError: If the target could not be compiled
+        ValueError: If the target could not be compiled
 
     Returns:
         List[CryticCompile]: Returns a list of CryticCompile instances for all compilations which occurred.
@@ -737,12 +737,11 @@ def compile_all(target: str, **kwargs: str) -> List[CryticCompile]:
             vyper_standard_json.add_source_files(vyper_filenames)
             compilations.append(CryticCompile(vyper_standard_json, **kwargs))
     else:
-        raise NotImplementedError()
         # TODO split glob into language
         # # Attempt to perform glob expansion of target/filename
         # globbed_targets = glob.glob(target, recursive=True)
         # print(globbed_targets)
 
-        # raise ValueError(f"{str(target)} is not a file or directory.")
+        raise ValueError(f"{str(target)} is not a file or directory.")
 
     return compilations