throw error before logging

anishnaik · anishnaik · commit 2ed80c4b78a8 · 2025-01-08T15:04:47.000-05:00
diff --git a/compilation/types/slither.go b/compilation/types/slither.go
@@ -78,11 +78,10 @@ func (s *SlitherConfig) RunSlither(target string) (*SlitherResults, error) {
 		// Run slither
 		start := time.Now()
 		out, err = cmd.CombinedOutput()
-		logging.GlobalLogger.Info("Finished running Slither in ", time.Since(start).Round(time.Second))
-
 		if err != nil {
 			return nil, err
 		}
+		logging.GlobalLogger.Info("Finished running Slither in ", time.Since(start).Round(time.Second))
 	}
 
 	// Capture the slither results

Original file line number	Diff line number	Diff line change
`@@ -78,11 +78,10 @@ func (s SlitherConfig) RunSlither(target string) (SlitherResults, error) {`
`78`	`78`	`// Run slither`
`79`	`79`	`start := time.Now()`
`80`	`80`	`out, err = cmd.CombinedOutput()`
`81`		`- logging.GlobalLogger.Info("Finished running Slither in ", time.Since(start).Round(time.Second))`
`82`		`-`
`83`	`81`	`if err != nil {`
`84`	`82`	`return nil, err`
`85`	`83`	`}`
	`84`	`+ logging.GlobalLogger.Info("Finished running Slither in ", time.Since(start).Round(time.Second))`
`86`	`85`	`}`
`87`	`86`
`88`	`87`	`// Capture the slither results`