Slither results caching is re-used even if compilation target changes

[gustavo-grieco]

I did some tests using medusa in a single directory, where different a number of contracts are available to compile individually (e.g. tests). The workflow looks like this:

1. medusa fuzz --compilation-target src/X.sol
2. medusa fuzz --compilation-target src/Y.sol

The first command will work correctly, the slither results will be saved to "slither_results.json", however, the second run will use the incorrect result. This can cause medusa to be less effective since the constants will not be extracted.

I think we should consider re-running slither if the compilation target changes.

[anishnaik]

There is nothing we can do about this. It would require us to cache additional information about the compilation target. In a real scenario (e.g. testing curvance or something), the compilation target does not change. Thus, we won't fix this and it's a known limitation of caching.

[anishnaik]

Re-opening for visibility but will but this issue on hold for reasons mentioned above.