Fix pylint

Author: frabert

.github/workflows/pylint.yaml

@@ -37,6 +37,7 @@
             run: |
               mkdir -p .github/linters
               cp pyproject.toml .github/linters
+              pip install .
     
           - name: Register pylint problem matcher
             run: |

pyproject.toml

@@ -40,8 +40,22 @@ slither-lsp = "slither_lsp.__main__:main"
 max-line-length = 120
 
 disable = """
-import-outside-toplevel,
 missing-module-docstring,
-useless-return,
-duplicate-code
+missing-class-docstring,
+missing-function-docstring,
+unnecessary-lambda,
+cyclic-import,
+line-too-long,
+invalid-name,
+fixme,
+too-many-return-statements,
+too-many-ancestors,
+logging-fstring-interpolation,
+logging-not-lazy,
+duplicate-code,
+import-error,
+unsubscriptable-object,
+unnecessary-lambda-assignment,
+too-few-public-methods,
+too-many-instance-attributes
 """

slither_lsp/app/app.py

@@ -1,8 +1,8 @@
 from importlib.metadata import version as pkg_version
 from logging import Logger
 
-import slither_lsp.app.request_handlers as request_handlers
 import slither_lsp.app.types.params as slsp
+from slither_lsp.app import request_handlers
 from slither_lsp.app.slither_server import SlitherServer
 
 

slither_lsp/app/feature_analyses/slither_diagnostics.py

@@ -136,7 +136,7 @@ def clear(self) -> None:
         :return: None
         """
         # Loop through all diagnostic files, publish new diagnostics for each file with no items.
-        for file_uri in self.diagnostics.keys():
+        for file_uri, _ in self.diagnostics:
             self._clear_single(file_uri, False)
 
         # Clear the dictionary

slither_lsp/app/request_handlers/analysis/get_detector_list.py

@@ -1,10 +1,10 @@
-from typing import Any
+# pylint: disable=unused-argument
 
 from pygls.server import LanguageServer
 from slither.__main__ import get_detectors_and_printers, output_detectors_json
 
 
-def get_detector_list(ls: LanguageServer, params: Any) -> Any:
+def get_detector_list(ls: LanguageServer, params):
     """
     Handler which invokes slither to obtain a list of all detectors and some properties that describe them.
     """

slither_lsp/app/request_handlers/analysis/get_version.py

@@ -1,10 +1,11 @@
+# pylint: disable=unused-argument
+
 from importlib.metadata import version as pkg_version
-from typing import Any
 
 from pygls.server import LanguageServer
 
 
-def get_version(ls: LanguageServer, params: Any) -> Any:
+def get_version(ls: LanguageServer, params):
     """
     Handler which retrieves versions for slither, crytic-compile, and related applications.
     """

slither_lsp/app/request_handlers/call_hierarchy.py

@@ -70,7 +70,7 @@ def on_prepare_call_hierarchy(
                         "offset": offset,
                     },
                 )
-        return [elem for elem in res.values()]
+        return list(res.values())
 
 
 def register_on_get_incoming_calls(ls: "SlitherServer"):

slither_lsp/app/request_handlers/compilation/__init__.py

@@ -1,2 +1 @@
-from .autogenerate_standard_json import autogenerate_standard_json
 from .get_command_line_args import get_command_line_args

slither_lsp/app/request_handlers/compilation/autogenerate_standard_json.py

@@ -1,11 +1,12 @@
+# pylint: disable=protected-access, unused-argument
+
 from argparse import ArgumentParser
-from typing import Any
 
 from crytic_compile.cryticparser.cryticparser import init as crytic_parser_init
 from pygls.server import LanguageServer
 
 
-def get_command_line_args(ls: LanguageServer, params: Any) -> Any:
+def get_command_line_args(ls: LanguageServer, params):
     """
     Handler which obtains data regarding all command line arguments available in crytic-compile.
     """