cleanup done

Author: priyankabose

slither/analyses/data_dependency/data_dependency.py

@@ -292,19 +292,21 @@ def get_all_dependencies_ssa(
         return context.context[KEY_SSA_UNPROTECTED]
     return context.context[KEY_SSA]
 
-def always_depends_on(x, must_depend_on_value):
-    must_dependencies = analyze_dependency(x)
-    print("")
+def get_must_depends_on(x):
+    must_dependencies = compute_must_dependencies(x)
+    if len(must_dependencies) > 1 or len(must_dependencies) == 0:
+        return None
+    return list(must_dependencies)[0]
 
-
-def analyze_dependency(x):
+def compute_must_dependencies(x):
     if isinstance(x, SolidityVariableComposed) or isinstance(x, Constant) or \
             (x.function.visibility in ['public', 'external'] and x in x.function.parameters):
         return set([x])
 
     function_dependencies = {}
     function_dependencies['context'] = {}
     lvalues = []
+
     for node in x.function.nodes:
         for ir in node.irs_ssa:
             if isinstance(ir, OperationWithLValue) and ir.lvalue:
@@ -318,7 +320,6 @@ def analyze_dependency(x):
 
     for lvalue_details in lvalues:
         lvalue = lvalue_details[0]
-        function = lvalue_details[1]
         ir = lvalue_details[2]
 
         if not lvalue in function_dependencies['context']:
@@ -332,21 +333,19 @@ def analyze_dependency(x):
         else:
             read = ir.read
         for v in read:
-            if not isinstance(v, Constant):
-                function_dependencies['context'][lvalue].add(v)
+            #if not isinstance(v, Constant):
+            function_dependencies['context'][lvalue].add(v)
     function_dependencies['context'] = convert_to_non_ssa(function_dependencies['context'])
 
     must_dependencies = set()
     if x in function_dependencies['context']:
-        i = 0
-        for dep_value in list(function_dependencies['context'][x]):
-            result = analyze_dependency(dep_value)
-            if i == 0:
-                must_dependencies = must_dependencies.union(result)
-            else:
+        dependencies = list(function_dependencies['context'][x])
+        for i in range(0, len(dependencies)):
+            result = compute_must_dependencies(dependencies[i])
+            if i > 0:
                 must_dependencies = must_dependencies.intersection(result)
-            i +=1
-
+            else:
+                must_dependencies = must_dependencies.union(result)
     return must_dependencies
 
 # endregion