Upgrade minimum Python version to 3.9

dguido · claude · dguido · commit e790c693f641 · 2025-09-02T10:01:36.000-04:00
- Update requires-python to >=3.9 in pyproject.toml - Simplify entry points code using Python 3.9+ select() method - Remove Python 3.8 from all CI test matrices - Update documentation to reflect Python 3.9 requirement - Remove outdated version compatibility code - Set ruff target-version to py39 This simplification was prompted by CI issues after the PEP 735 migration, where maintaining Python 3.8 compatibility added unnecessary complexity. Python 3.8 reaches EOL in October 2024. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,8 +29,8 @@ jobs:
           ${{ (github.event_name == 'pull_request' && fromJSON('["ubuntu-latest"]'))
             || fromJSON('["ubuntu-latest", "windows-2025"]') }}
         python: >-
-          ${{ (github.event_name == 'pull_request' && fromJSON('["3.8", "3.12"]'))
-            || fromJSON('["3.8", "3.9", "3.10", "3.11", "3.12"]') }}
+          ${{ (github.event_name == 'pull_request' && fromJSON('["3.9", "3.12"]'))
+            || fromJSON('["3.9", "3.10", "3.11", "3.12"]') }}
         type: >-
           ${{ (github.event_name == 'pull_request' &&
             fromJSON('["data_dependency", "path_filtering","erc","find_paths","flat","interface",
@@ -39,9 +39,6 @@ jobs:
             "printers","slither_config","upgradability", "cli", "dapp", "etherscan", "kspec",
             "simil", "truffle"]') }}
         exclude:
-          # Python 3.8 is not available on Windows Server 2025
-          - os: windows-2025
-            python: 3.8
           # Requires nix
           - os: windows-2025
             type: dapp
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -33,7 +33,7 @@ jobs:
         uses: actions/configure-pages@v5
       - uses: actions/setup-python@v5
         with:
-          python-version: '3.8'
+          python-version: '3.9'
       - run: |
           pip install uv
           uv sync --group dev
diff --git a/.github/workflows/doctor.yml b/.github/workflows/doctor.yml
@@ -23,11 +23,7 @@ jobs:
       fail-fast: false
       matrix:
         os: ["ubuntu-latest", "windows-2025"]
-        python: ["3.8", "3.9", "3.10", "3.11", "3.12"]
-        exclude:
-          # strange failure
-          - os: windows-2025
-            python: 3.8
+        python: ["3.9", "3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@v5
 
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -26,12 +26,8 @@ jobs:
         os: ["ubuntu-latest", "windows-2025"]
         type: ["unit", "integration", "tool"]
         python: >-
-          ${{ (github.event_name == 'pull_request' && fromJSON('["3.8", "3.12"]'))
-            || fromJSON('["3.8", "3.9", "3.10", "3.11", "3.12"]') }}
-        exclude:
-          # Python 3.8 is not available on Windows Server 2025
-          - os: windows-2025
-            python: 3.8
+          ${{ (github.event_name == 'pull_request' && fromJSON('["3.9", "3.12"]'))
+            || fromJSON('["3.9", "3.10", "3.11", "3.12"]') }}
     steps:
       - uses: actions/checkout@v5
       - name: Set up Python ${{ matrix.python }}
@@ -96,7 +92,7 @@ jobs:
         uses: ./.github/actions/upload-coverage
         # only aggregate test coverage over linux-based tests to avoid any OS-specific filesystem information stored in
         # coverage metadata.
-        if: ${{ matrix.os == 'ubuntu-latest' && matrix.python == '3.8' }}
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.python == '3.9' }}
 
   coverage:
     needs:
@@ -106,10 +102,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v5
-      - name: Set up Python 3.8
+      - name: Set up Python 3.9
         uses: actions/setup-python@v5
         with:
-          python-version: 3.8
+          python-version: 3.9
 
       - run: pip install coverage[toml]
 
diff --git a/README.md b/README.md
@@ -68,7 +68,7 @@ slither tests/uninitialized.sol
 ## How to install
 
 > **Note** <br />
-> Slither requires Python 3.8+.
+> Slither requires Python 3.9+.
 If you're **not** going to use one of the [supported compilation frameworks](https://github.com/crytic/crytic-compile), you need [solc](https://github.com/ethereum/solidity/), the Solidity compiler; we recommend using [solc-select](https://github.com/crytic/solc-select) to conveniently switch between solc versions.
 
 ### Using uv
diff --git a/docs/src/tutorials/README.md b/docs/src/tutorials/README.md
@@ -17,7 +17,7 @@ Watch Slither's [code walkthrough](https://www.youtube.com/watch?v=EUl3UlYSluU),
 
 ## Installation
 
-Slither requires Python >= 3.8. You can install it through pip or by using Docker.
+Slither requires Python >= 3.9. You can install it through pip or by using Docker.
 
 Installing Slither through pip:
 
diff --git a/plugin_example/setup.py b/plugin_example/setup.py
@@ -7,7 +7,7 @@
     author="Trail of Bits",
     version="0.0",
     packages=find_packages(),
-    python_requires=">=3.8",
+    python_requires=">=3.9",
     install_requires=["slither-analyzer>=0.6.0"],
     entry_points={
         "slither_analyzer.plugin": "slither my-plugin=slither_my_plugin:make_plugin",
diff --git a/pyproject.toml b/pyproject.toml
@@ -7,7 +7,7 @@ name = "slither-analyzer"
 version = "0.11.3"
 description = "Slither is a Solidity and Vyper static analysis framework written in Python 3."
 readme = "README.md"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 license = {text = "AGPL-3.0"}
 authors = [
     {name = "Trail of Bits"},
@@ -22,7 +22,6 @@ classifiers = [
     "Intended Audience :: Developers",
     "License :: OSI Approved :: GNU Affero General Public License v3",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -84,8 +83,8 @@ packages = ["slither"]
 [tool.ruff]
 # Match black's line length
 line-length = 100
-# Target Python 3.8+ (minimum version required by project)
-target-version = "py38"
+# Target Python 3.9+ (minimum version required by project)
+target-version = "py39"
 # Additional exclusions beyond defaults and .gitignore
 extend-exclude = [
     "docs/",
diff --git a/slither/__main__.py b/slither/__main__.py
@@ -166,23 +166,8 @@ def get_detectors_and_printers() -> Tuple[
     printers = [p for p in printers_ if inspect.isclass(p) and issubclass(p, AbstractPrinter)]
 
     # Handle plugins!
-    # In Python 3.10+, entry_points() accepts a group parameter directly
-    # In Python 3.8-3.9, we need to use select() or dict lookup
-    try:
-        # Try the Python 3.10+ API with group parameter
-        entry_points = metadata.entry_points(group="slither_analyzer.plugin")
-    except TypeError:
-        # Fall back to Python 3.8-3.9 API
-        eps = metadata.entry_points()
-        if hasattr(eps, 'select'):
-            # Python 3.9+ with select method
-            entry_points = eps.select(group="slither_analyzer.plugin")
-        elif isinstance(eps, dict):
-            # Python 3.8 returns a dict
-            entry_points = eps.get("slither_analyzer.plugin", [])
-        else:
-            # Fallback
-            entry_points = []
+    # Python 3.9+ has select() method on entry_points()
+    entry_points = metadata.entry_points().select(group="slither_analyzer.plugin")
 
     for entry_point in entry_points:
         make_plugin = entry_point.load()
diff --git a/slither/tools/doctor/checks/paths.py b/slither/tools/doctor/checks/paths.py
@@ -13,20 +13,7 @@ def path_is_relative_to(path: Path, relative_to: Path) -> bool:
 
     Compatibility wrapper for Path.is_relative_to
     """
-    if sys.version_info >= (3, 9, 0):
-        return path.is_relative_to(relative_to)
-
-    path_parts = path.resolve().parts
-    relative_to_parts = relative_to.resolve().parts
-
-    if len(path_parts) < len(relative_to_parts):
-        return False
-
-    for (a, b) in zip(path_parts, relative_to_parts):
-        if a != b:
-            return False
-
-    return True
+    return path.is_relative_to(relative_to)
 
 
 def check_path_config(name: str) -> Tuple[bool, Optional[Path], List[Path]]:
diff --git a/test_ci_locally.sh b/test_ci_locally.sh
@@ -0,0 +1,89 @@
+#!/bin/bash
+set -euo pipefail
+IFS=$'\n\t'
+
+echo "========================================="
+echo "Local CI Simulation for Python 3.9 Upgrade"
+echo "========================================="
+
+# Color codes for output
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+NC='\033[0m' # No Color
+
+# Check Python version
+echo -e "\n${YELLOW}1. Checking Python version...${NC}"
+python_version=$(python3 --version | cut -d' ' -f2)
+min_version="3.9.0"
+if [ "$(printf '%s\n' "$min_version" "$python_version" | sort -V | head -n1)" = "$min_version" ]; then
+    echo -e "${GREEN}✓ Python $python_version meets minimum requirement (>=3.9)${NC}"
+else
+    echo -e "${RED}✗ Python $python_version does not meet minimum requirement (>=3.9)${NC}"
+    exit 1
+fi
+
+# Check for Python 3.8 references in key files
+echo -e "\n${YELLOW}2. Checking for Python 3.8 references...${NC}"
+files_with_38=$(grep -r "3\.8" --include="*.py" --include="*.yml" --include="*.yaml" --include="*.toml" --include="*.md" --include="setup.py" . 2>/dev/null | grep -v ".git" | grep -v "uv.lock" | grep -v "test_ci_locally.sh" || true)
+if [ -z "$files_with_38" ]; then
+    echo -e "${GREEN}✓ No Python 3.8 references found${NC}"
+else
+    echo -e "${RED}✗ Found Python 3.8 references:${NC}"
+    echo "$files_with_38"
+fi
+
+# Run ruff linting
+echo -e "\n${YELLOW}3. Running ruff linting...${NC}"
+if uv run ruff check; then
+    echo -e "${GREEN}✓ Ruff linting passed${NC}"
+else
+    echo -e "${RED}✗ Ruff linting failed${NC}"
+    exit 1
+fi
+
+# Test slither installation
+echo -e "\n${YELLOW}4. Testing slither installation...${NC}"
+if uv run slither --version > /dev/null 2>&1; then
+    version=$(uv run slither --version)
+    echo -e "${GREEN}✓ Slither runs successfully (version: $version)${NC}"
+else
+    echo -e "${RED}✗ Slither failed to run${NC}"
+    exit 1
+fi
+
+# Test entry points plugin system
+echo -e "\n${YELLOW}5. Testing entry points (plugin system)...${NC}"
+if uv run python -c "from importlib import metadata; eps = metadata.entry_points().select(group='slither_analyzer.plugin'); print(f'✓ Entry points work: {list(eps)}')"; then
+    echo -e "${GREEN}✓ Entry points API working correctly${NC}"
+else
+    echo -e "${RED}✗ Entry points API failed${NC}"
+    exit 1
+fi
+
+# Run a subset of unit tests
+echo -e "\n${YELLOW}6. Running sample unit tests...${NC}"
+if uv run pytest tests/unit/core/test_constant_folding.py -q 2>/dev/null; then
+    echo -e "${GREEN}✓ Sample unit tests passed${NC}"
+else
+    echo -e "${YELLOW}⚠ Sample unit tests failed (this might be expected if test dependencies are missing)${NC}"
+fi
+
+# Check pyproject.toml validity
+echo -e "\n${YELLOW}7. Checking pyproject.toml validity...${NC}"
+if python3 -c "import tomllib; tomllib.load(open('pyproject.toml', 'rb'))" 2>/dev/null || python3 -c "import toml; toml.load('pyproject.toml')" 2>/dev/null; then
+    echo -e "${GREEN}✓ pyproject.toml is valid${NC}"
+else
+    echo -e "${RED}✗ pyproject.toml is invalid${NC}"
+    exit 1
+fi
+
+# Summary
+echo -e "\n${YELLOW}=========================================${NC}"
+echo -e "${GREEN}Local CI simulation complete!${NC}"
+echo -e "${YELLOW}=========================================${NC}"
+echo ""
+echo "Next steps to verify CI will pass:"
+echo "1. Push changes to a branch and create a PR to see actual CI results"
+echo "2. Or run the full test suite locally with: UV_RUN='uv run' bash .github/scripts/unit_test_runner.sh"
+echo "3. Check specific workflow files match Python versions: .github/workflows/*.yml"
diff --git a/uv.lock b/uv.lock
