Skip to content

[False-Positive]: "ignores return value" false positive #2126

Open
@thedavidmeister

Description

@thedavidmeister

Describe the issue:

slither says that i'm ignoring the return value

https://github.com/rainprotocol/rain.flow/actions/runs/6138590436/job/16655608341?pr=5#step:4:57965

FlowERC1155._previewFlow(Evaluable,uint256[][]) (src/concrete/erc1155/FlowERC1155.sol#133-153) ignores return value by (stackTop,tuplesPointer) = stackBottom.consumeSentinelTuples(stackTop,RAIN_FLOW_ERC1155_SENTINEL,3) (src/concrete/erc1155/FlowERC1155.sol#143)
FlowERC1155._previewFlow(Evaluable,uint256[][]) (src/concrete/erc1155/FlowERC1155.sol#133-153) ignores return value by (stackTop,tuplesPointer) = stackBottom.consumeSentinelTuples(stackTop,RAIN_FLOW_ERC1155_SENTINEL,3) (src/concrete/erc1155/FlowERC1155.sol#148)

but it isn't ignored, both return values are used

https://github.com/rainprotocol/rain.flow/pull/5/files#diff-0bfdd537a599fa870763c6915d4a43184ba4ef54bc038e33bd9d3545a445c4b0R143

Code example to reproduce the issue:

https://github.com/rainprotocol/rain.flow/pull/5/files#diff-0bfdd537a599fa870763c6915d4a43184ba4ef54bc038e33bd9d3545a445c4b0R142

Version:

latest according to github actions

Relevant log output:

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions