tests: move util functions into separate file

Author: elopez

tests/conftest.py

@@ -68,68 +68,6 @@ def isolated_python_env(tmp_path):
     }
 
 
-def run_in_venv(
-    venv_info: Dict, cmd: str, check: bool = True, **kwargs
-) -> subprocess.CompletedProcess:
-    """
-    Run a command in an isolated virtual environment.
-
-    Args:
-        venv_info: Dictionary from isolated_python_env fixture
-        cmd: Command to run
-        check: Whether to raise on non-zero exit code
-        **kwargs: Additional arguments to subprocess.run
-
-    Returns:
-        CompletedProcess instance with stdout, stderr, and returncode
-    """
-    env = os.environ.copy()
-    env.update(venv_info["env"])
-
-    try:
-        return subprocess.run(
-            cmd, shell=True, env=env, capture_output=True, text=True, check=check, **kwargs
-        )
-    except subprocess.CalledProcessError as e:
-        print("Command failed with CalledProcessError.")
-        print("Exit code:", e.returncode)
-        print("Command:", e.cmd)
-        print("Stdout:", e.stdout)
-        print("Stderr:", e.stderr)
-        raise
-
-
-def run_command(
-    cmd: str, check: bool = True, capture_stderr: bool = True
-) -> subprocess.CompletedProcess:
-    """
-    Execute shell commands and return output.
-
-    This function is kept for backward compatibility with tests using isolated_solc_data.
-    For tests using isolated_python_env, use run_in_venv instead.
-
-    Args:
-        cmd: Command to run
-        check: Whether to raise on non-zero exit code
-        capture_stderr: Whether to capture stderr
-
-    Returns:
-        CompletedProcess instance with stdout, stderr, and returncode
-    """
-    stderr_setting = subprocess.STDOUT if capture_stderr else subprocess.PIPE
-
-    result = subprocess.run(
-        cmd,
-        shell=True,
-        capture_output=False,
-        stdout=subprocess.PIPE,
-        stderr=stderr_setting,
-        text=True,
-        check=check,
-    )
-    return result
-
-
 @pytest.fixture(scope="session")
 def test_contracts_dir() -> Path:
     """Path to test Solidity contracts."""

tests/test_compiler_versions.py

@@ -4,7 +4,7 @@
 This module tests compilation with different Solidity versions.
 """
 
-from .conftest import run_command
+from .utils import run_command
 
 
 class TestCompilerVersions:

tests/test_platform_specific.py

@@ -9,7 +9,7 @@
 
 import pytest
 
-from .conftest import run_command
+from .utils import run_command
 
 # Platform configuration matrix
 PLATFORM_CONFIGS = {

tests/test_upgrade.py

@@ -7,7 +7,7 @@
 
 from pathlib import Path
 
-from .conftest import run_in_venv
+from .utils import run_in_venv
 
 
 class TestUpgrade:  # pylint: disable=too-few-public-methods

tests/utils.py

@@ -0,0 +1,72 @@
+"""
+Utility functions for solc-select tests.
+
+This module contains helper functions that are not pytest fixtures
+but are used across multiple test files.
+"""
+
+import os
+import subprocess
+from typing import Dict
+
+
+def run_in_venv(
+    venv_info: Dict, cmd: str, check: bool = True, **kwargs
+) -> subprocess.CompletedProcess:
+    """
+    Run a command in an isolated virtual environment.
+
+    Args:
+        venv_info: Dictionary from isolated_python_env fixture
+        cmd: Command to run
+        check: Whether to raise on non-zero exit code
+        **kwargs: Additional arguments to subprocess.run
+
+    Returns:
+        CompletedProcess instance with stdout, stderr, and returncode
+    """
+    env = os.environ.copy()
+    env.update(venv_info["env"])
+
+    try:
+        return subprocess.run(
+            cmd, shell=True, env=env, capture_output=True, text=True, check=check, **kwargs
+        )
+    except subprocess.CalledProcessError as e:
+        print("Command failed with CalledProcessError.")
+        print("Exit code:", e.returncode)
+        print("Command:", e.cmd)
+        print("Stdout:", e.stdout)
+        print("Stderr:", e.stderr)
+        raise
+
+
+def run_command(
+    cmd: str, check: bool = True, capture_stderr: bool = True
+) -> subprocess.CompletedProcess:
+    """
+    Execute shell commands and return output.
+
+    This function is kept for backward compatibility with tests using isolated_solc_data.
+    For tests using isolated_python_env, use run_in_venv instead.
+
+    Args:
+        cmd: Command to run
+        check: Whether to raise on non-zero exit code
+        capture_stderr: Whether to capture stderr
+
+    Returns:
+        CompletedProcess instance with stdout, stderr, and returncode
+    """
+    stderr_setting = subprocess.STDOUT if capture_stderr else subprocess.PIPE
+
+    result = subprocess.run(
+        cmd,
+        shell=True,
+        capture_output=False,
+        stdout=subprocess.PIPE,
+        stderr=stderr_setting,
+        text=True,
+        check=check,
+    )
+    return result