fix: resolve pylint warnings in test files

- Add explicit check=False parameter to subprocess.run calls
- Mark unused fixture arguments as intentionally unused with _ assignment
- Move module imports to top level instead of inside functions
- Disable too-few-public-methods warning for test classes
- Fix all W0613 (unused-argument) warnings
- Fix all C0415 (import-outside-toplevel) warnings
- Fix all W1510 (subprocess-run-check) warnings

Author: dguido

tests/conftest.py

@@ -137,7 +137,7 @@ def ensure_solc_select_installed():
     development version is being tested.
     """
     # Check if solc-select is available
-    result = subprocess.run(["solc-select", "--help"], capture_output=True, text=True)
+    result = subprocess.run(["solc-select", "--help"], capture_output=True, text=True, check=False)
 
     if result.returncode != 0:
         pytest.exit("solc-select is not installed. Please run: pip install -e .")

tests/test_compiler_versions.py

@@ -5,6 +5,9 @@
 exactly mirroring the behavior of the original test_solc.sh script.
 """
 
+import os
+import shutil
+
 import pytest
 
 
@@ -20,6 +23,7 @@ def install_required_versions(self, run_command):
 
     def test_solc_045(self, run_command, test_contracts_dir, backup_current_version):
         """Test Solidity 0.4.5 compilation behavior."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Switch to 0.4.5
         result = run_command("solc-select use 0.4.5", check=False)
         assert result.returncode == 0, f"Failed to switch to 0.4.5: {result.stdout}"
@@ -37,6 +41,7 @@ def test_solc_045(self, run_command, test_contracts_dir, backup_current_version)
 
     def test_solc_050(self, run_command, test_contracts_dir, backup_current_version):
         """Test Solidity 0.5.0 compilation behavior."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Switch to 0.5.0
         result = run_command("solc-select use 0.5.0", check=False)
         assert result.returncode == 0, f"Failed to switch to 0.5.0: {result.stdout}"
@@ -55,6 +60,7 @@ def test_solc_050(self, run_command, test_contracts_dir, backup_current_version)
 
     def test_solc_060(self, run_command, test_contracts_dir, backup_current_version):
         """Test Solidity 0.6.0 compilation behavior."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Switch to 0.6.0
         result = run_command("solc-select use 0.6.0", check=False)
         assert result.returncode == 0, f"Failed to switch to 0.6.0: {result.stdout}"
@@ -69,6 +75,7 @@ def test_solc_060(self, run_command, test_contracts_dir, backup_current_version)
 
     def test_solc_070(self, run_command, test_contracts_dir, backup_current_version):
         """Test Solidity 0.7.0 compilation behavior."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Switch to 0.7.0
         result = run_command("solc-select use 0.7.0", check=False)
         assert result.returncode == 0, f"Failed to switch to 0.7.0: {result.stdout}"
@@ -86,6 +93,7 @@ def test_solc_070(self, run_command, test_contracts_dir, backup_current_version)
 
     def test_solc_080(self, run_command, test_contracts_dir, backup_current_version):
         """Test Solidity 0.8.0 compilation behavior."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Switch to 0.8.0
         result = run_command("solc-select use 0.8.0", check=False)
         assert result.returncode == 0, f"Failed to switch to 0.8.0: {result.stdout}"
@@ -115,12 +123,11 @@ class TestVersionSwitching:
 
     def test_always_install_flag(self, run_command, solc_select_path, backup_current_version):
         """Test --always-install flag functionality."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Safely remove 0.8.9 if it exists
         artifacts_path = solc_select_path / "artifacts"
 
         # Validate path to ensure we're in the right place
-        import os
-
         path_parts = str(artifacts_path).replace(os.sep, "/").split("/")
         if len(path_parts) < 2 or path_parts[-2:] != [".solc-select", "artifacts"]:
             pytest.fail(f"Unsafe artifacts path: {artifacts_path}")
@@ -135,8 +142,6 @@ def test_always_install_flag(self, run_command, solc_select_path, backup_current
                         file_path.unlink()
                     elif file_path.is_dir():
                         # On macOS, solc binaries are directories
-                        import shutil
-
                         shutil.rmtree(file_path)
                 except (PermissionError, OSError):
                     # If we can't delete, that's okay - test will still work
@@ -151,11 +156,11 @@ def test_always_install_flag(self, run_command, solc_select_path, backup_current
 
     def test_use_without_install(self, run_command, solc_select_path, backup_current_version):
         """Test that 'use' fails when version is not installed."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Safely remove 0.8.1 if it exists
         artifacts_path = solc_select_path / "artifacts"
 
         # Validate path to ensure we're in the right place
-        import os
 
         path_parts = str(artifacts_path).replace(os.sep, "/").split("/")
         if len(path_parts) < 2 or path_parts[-2:] != [".solc-select", "artifacts"]:
@@ -171,8 +176,6 @@ def test_use_without_install(self, run_command, solc_select_path, backup_current
                         file_path.unlink()
                     elif file_path.is_dir():
                         # On macOS, solc binaries are directories
-                        import shutil
-
                         shutil.rmtree(file_path)
                 except (PermissionError, OSError):
                     # If we can't delete, that's okay - test will still work

tests/test_platform_specific.py

@@ -11,12 +11,13 @@
 import pytest
 
 
-class TestLinuxSpecific:
+class TestLinuxSpecific:  # pylint: disable=too-few-public-methods
     """Linux-specific version boundary tests."""
 
     @pytest.mark.linux
     def test_linux_version_boundaries(self, run_command, backup_current_version):
         """Test Linux version boundaries and constraints."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Install all versions (as original script does)
         run_command("solc-select install all", check=False)
 
@@ -55,12 +56,13 @@ def test_linux_version_boundaries(self, run_command, backup_current_version):
         ), f"Did not fail for version too high. Output: {result.stdout}"
 
 
-class TestMacOSSpecific:
+class TestMacOSSpecific:  # pylint: disable=too-few-public-methods
     """macOS-specific version boundary tests."""
 
     @pytest.mark.macos
     def test_macos_version_boundaries(self, run_command, backup_current_version):
         """Test macOS version boundaries and constraints."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Install all versions (as original script does)
         run_command("solc-select install all", check=False)
 
@@ -99,12 +101,13 @@ def test_macos_version_boundaries(self, run_command, backup_current_version):
         ), f"Did not fail for version too high. Output: {result.stdout}"
 
 
-class TestWindowsSpecific:
+class TestWindowsSpecific:  # pylint: disable=too-few-public-methods
     """Windows-specific version boundary tests."""
 
     @pytest.mark.windows
     def test_windows_version_boundaries(self, run_command, backup_current_version):
         """Test Windows version boundaries and constraints."""
+        _ = backup_current_version  # Fixture ensures clean state
         # Install all versions (as original script does)
         run_command("solc-select install all", check=False)
 

tests/test_upgrade.py

@@ -10,11 +10,11 @@
 import pytest
 
 
-class TestUpgrade:
+class TestUpgrade:  # pylint: disable=too-few-public-methods
     """Test solc-select upgrade behavior."""
 
     @pytest.mark.slow  # This test reinstalls packages, so it's slow
-    def test_upgrade_preserves_versions(self, run_command, tmp_path):
+    def test_upgrade_preserves_versions(self, run_command, tmp_path):  # pylint: disable=unused-argument
         """
         Test that upgrading solc-select preserves installed versions.