Merge pull request #238 from junaire/jun/skip_already_installed

Skip already installed versions in install_artifacts

Author: elopez

solc_select/solc_select.py

@@ -206,18 +206,26 @@ def install_artifacts(versions: [str], silent: bool = False) -> bool:
             print(f"{', '.join(not_available_versions)} solc versions are not available.")
             return False
 
+    already_installed = installed_versions()
     for version, artifact in releases.items():
         if "all" not in versions:
             if versions and version not in versions:
                 continue
 
+        artifact_file_dir = ARTIFACTS_DIR.joinpath(f"solc-{version}")
+
+        if version in already_installed:
+            if os.listdir(artifact_file_dir):
+                if not silent:
+                    print(f"Version '{version}' is already installed, skipping...")
+                continue
+
         (url, _) = get_url(version, artifact)
 
         if is_linux_0818(version):
             url = CRYTIC_SOLC_ARTIFACTS + artifact
             print(url)
 
-        artifact_file_dir = ARTIFACTS_DIR.joinpath(f"solc-{version}")
         Path.mkdir(artifact_file_dir, parents=True, exist_ok=True)
         if not silent:
             print(f"Installing solc '{version}'...")

tests/test_upgrade.py

@@ -66,3 +66,18 @@ def test_upgrade_preserves_versions(self, isolated_python_env):
         assert old_versions == new_versions, (
             f"Installed versions changed during upgrade.\nOld: {old_versions}\nNew: {new_versions}"
         )
+
+    def test_cache_already_installed(self, isolated_python_env):
+        venv = isolated_python_env
+        project_root = Path(__file__).parent.parent
+
+        # Install development version
+        run_in_venv(venv, f"pip install -e {project_root}", check=True)
+
+        run_in_venv(venv, "solc-select install 0.8.20", check=False)
+
+        result = run_in_venv(venv, "solc-select install 0.8.20", check=False)
+        already_installed = result.stdout.strip()
+        assert "Version '0.8.20' is already installed, skipping.." in already_installed, (
+            "No skipping already installed versions"
+        )