Fix tests on Windows

Author: elopez

solc_select/infrastructure/filesystem.py

@@ -73,7 +73,7 @@ def get_version_source(self) -> str:
             return "SOLC_VERSION"
 
         global_version_file = self.config_dir / "global-version"
-        return str(global_version_file)
+        return global_version_file.as_posix()
 
     def get_artifact_directory(self, version: SolcVersion) -> Path:
         """Get the directory for a version's artifacts.

solc_select/services/artifact_manager.py

@@ -308,15 +308,17 @@ def install_versions(self, versions: List[SolcVersion], silent: bool = False) ->
                         success_count += 1
                         if not silent:
                             print(
-                                f"✓ Version '{version}' installed ({success_count}/{total_count})"
+                                f"[OK] Version '{version}' installed ({success_count}/{total_count})"
                             )
                     elif not silent:
                         print(
-                            f"✗ Version '{version}' failed to install ({success_count}/{total_count})"
+                            f"[FAIL] Version '{version}' failed to install ({success_count}/{total_count})"
                         )
                 except SolcSelectError as e:
                     if not silent:
-                        print(f"✗ Version '{version}' failed: {e} ({success_count}/{total_count})")
+                        print(
+                            f"[FAIL] Version '{version}' failed: {e} ({success_count}/{total_count})"
+                        )
 
         except KeyboardInterrupt:
             if not silent:

tests/test_version_verification.py

@@ -41,7 +41,7 @@ def test_all_versions_work_correctly(self, isolated_solc_data: Any, test_mode: s
         # Test each version
         for version in versions:
             # Run solc --version with the specific version set
-            result = run_command(f"SOLC_VERSION={version} solc --version", check=True)
+            result = run_command("solc --version", check=True, env={"SOLC_VERSION": version})
             output = result.stdout.lower()
 
             # Check that output contains "solidity compiler" and the version

tests/utils.py

@@ -44,7 +44,7 @@ def run_in_venv(
 
 
 def run_command(
-    cmd: str, check: bool = True, capture_stderr: bool = True
+    cmd: str, check: bool = True, capture_stderr: bool = True, env: dict[str, str] | None = None
 ) -> subprocess.CompletedProcess[str]:
     """
     Execute shell commands and return output.
@@ -56,19 +56,33 @@ def run_command(
         cmd: Command to run
         check: Whether to raise on non-zero exit code
         capture_stderr: Whether to capture stderr
+        env: Additional environment variables to set
 
     Returns:
         CompletedProcess instance with stdout, stderr, and returncode
     """
     stderr_setting = subprocess.STDOUT if capture_stderr else subprocess.PIPE
 
-    result = subprocess.run(
-        cmd,
-        shell=True,
-        capture_output=False,
-        stdout=subprocess.PIPE,
-        stderr=stderr_setting,
-        text=True,
-        check=check,
-    )
-    return result
+    # Merge environment variables
+    process_env = os.environ.copy()
+    if env:
+        process_env.update(env)
+
+    try:
+        return subprocess.run(
+            cmd,
+            shell=True,
+            capture_output=False,
+            stdout=subprocess.PIPE,
+            stderr=stderr_setting,
+            text=True,
+            check=check,
+            env=process_env,
+        )
+    except subprocess.CalledProcessError as e:
+        print("Command failed with CalledProcessError.")
+        print("Exit code:", e.returncode)
+        print("Command:", e.cmd)
+        print("Stdout:", e.stdout)
+        print("Stderr:", e.stderr)
+        raise