Skip to content

Review all internal errors #4915

Description

@glpatcern

The current code base uses status.NewInternal() in far too many places as a "shortcut" to report an error. In many/most occurrences, a more tailored error code should be used for the caller to display proper error messages, and logging should be adapted as well.

Here follows the count per GRPC service:

applicationauth: 4
appregistry: 6
authregistry: 2
datatx: 4
gateway: 104
groupprovider: 5
ocmcore: 1
ocminvitemanager: 10
ocmproviderauthorizer: 3
ocmshareprovider: 12
preferences: 2
publicshareprovider: 6
publicstorageprovider: 9
storageprovider: 64
storageregistry: 3
userprovider: 4
usershareprovider: 8

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions