Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Commit 240095b

Browse files
authored
Merge pull request #12 from cs5331jan2018-prdz/release-1.0
Finalise README.md for Release 1.0
2 parents bb1cefe + 6aabc03 commit 240095b

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

README.md

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,15 @@ Please fill out this section with details relevant to your team.
128128

129129
#### Question 1: Briefly describe the web technology stack used in your implementation.
130130

131-
The web framework is written in Python Flask that connects to a MongoDB database and the web server is hosted on Apache.
131+
The web app is written on Python Flask framework that connects to a MongoDB database and the frontend web server is hosted on Apache.
132132
The frontend is designed using HTML, Bootstrap 4 and JavaScript (jQuery 3.3.1).
133133

134134
#### Question 2: Are there any security considerations your team thought about?
135135

136136
We had identified the following security considerations, however it had been stated in the assignment brief that there is no need to implement the actual security measures to counter these issues.
137137

138138
Implemented:
139-
- Password hashing using bcrypt
139+
- Password salted-hashing using bcrypt
140140
- Client-side XSS sanitisation using DOMPurify
141141

142142
Considered but not implemented:
@@ -160,26 +160,30 @@ One potential weakness is in the cookie management - currently we are still usin
160160

161161
Another vulnerability is the lack of SSL. Due to that, all web traffic is sent / received in the clear, allowing all kinds of MITM attacks to occur.
162162

163-
Our usage of DOMPurify provides client-side sanitisation for our web app. However, it is not a foolproof way. For a more rigorous defense, server-side sanitisation should be employed as well.
163+
Our usage of DOMPurify provides client-side sanitisation for our web app. However, it is not a foolproof way. For a more rigorous defense (e.g. against persistent XSS), server-side sanitisation should be employed as well.
164164

165165
#### Feedback: Is there any other feedback you would like to give?
166166

167167
Logging should be done on the server-side to track all the significant actions made by all the users of the web app.
168+
A framework/tool we could use to test our final webapp would be really appreciated.
169+
The API should also consider RESTful features like: correct http verbs for end-points (GET for idempotent, resource-info-acquiring end-points, DELETE for resource deletion...), response status codes that make more sense (4xx for client-side errors), maybe a header instead of a field for the auth token...
168170

169171
### Declaration
170172

171173
#### Please declare your individual contributions to the assignment:
172174

173175
1. Ngo Kim Phu
174-
- Wrote the back-end code
175-
- Designed the Docker configuration
176+
- Managed project, GitHub organization, repository
177+
- Configured CircleCI continuous integration for quality control
178+
- Wrote the back-end routing and logic code
176179
2. Choo Rui Bin
177180
- Wrote the front-end code
178181
- Integrated the RESTful API into the front-end
179182
- Wrote the documentation
180183
3. Ouyang Danwen
184+
- Designed the Docker configuration
181185
- Designed the database schema
182-
- Wrote the back-end code
186+
- Wrote the back-end db code
183187
4. Chai Wai Aik Zander
184188
- Wrote the front-end code
185-
- Integrated the RESTful API into the front-end
189+
- Integrated the RESTful API into the front-end

0 commit comments

Comments
 (0)