Skip to content

Commit 43d2a4f

Browse files
committed
Fix date-sensitive tests for 2026
Tests were failing because fixtures have memberships ending in 2024/2025 and deliveries only up to 2025. When the current date became 2026-01-01, members no longer had current/future memberships and create_membership couldn't find deliveries for the current year. Added travel_to "2024-01-01" to affected tests to ensure they run in the expected time context where fixtures are valid.
1 parent 3407140 commit 43d2a4f

File tree

9 files changed

+18
-0
lines changed

9 files changed

+18
-0
lines changed

test/models/concerns/auditable_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ class AuditableTest < ActiveSupport::TestCase
1818
end
1919

2020
test "save changes on audited attributes with current session" do
21+
travel_to "2024-01-01"
2122
member = members(:john)
2223
session = create_session(member)
2324
Current.session = session

test/models/liquid/data_preview_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ class Liquid::DataPreviewTest < ActiveSupport::TestCase
160160
end
161161

162162
test "render non-drop data" do
163+
travel_to "2024-01-01"
163164
mail_template = mail_templates(:member_validated)
164165
data = Liquid::DataPreview.for(mail_template, random: 1)
165166

test/models/member/state_transitions_test.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ class Member::StateTransitionsTest < ActiveSupport::TestCase
182182
end
183183

184184
test "activate! activates new active member and sent member-activated email" do
185+
travel_to "2024-01-01"
185186
mail_templates(:member_activated).update!(active: true)
186187
member = members(:john)
187188
member.update_columns(state: "inactive", activated_at: nil, annual_fee: nil)
@@ -197,6 +198,7 @@ class Member::StateTransitionsTest < ActiveSupport::TestCase
197198
end
198199

199200
test "activate! when annual_fee_support_member_only is true" do
201+
travel_to "2024-01-01"
200202
org(annual_fee_support_member_only: true)
201203
member = members(:john)
202204
member.update_columns(state: "inactive", activated_at: nil, annual_fee: nil)
@@ -209,6 +211,7 @@ class Member::StateTransitionsTest < ActiveSupport::TestCase
209211
end
210212

211213
test "activate! activates previously active member" do
214+
travel_to "2024-01-01"
212215
mail_templates(:member_activated).update!(active: true)
213216
member = members(:john)
214217
member.update_columns(state: "inactive", activated_at: 1.year.ago)
@@ -223,6 +226,7 @@ class Member::StateTransitionsTest < ActiveSupport::TestCase
223226
end
224227

225228
test "activate! previously active member (recent)" do
229+
travel_to "2024-01-01"
226230
mail_templates(:member_activated).update!(active: true)
227231
member = members(:john)
228232
member.update_columns(state: "inactive", activated_at: 1.day.ago)
@@ -265,6 +269,7 @@ class Member::StateTransitionsTest < ActiveSupport::TestCase
265269
end
266270

267271
test "deactivate! raises if current membership" do
272+
travel_to "2024-01-01"
268273
member = members(:john)
269274
assert_raises(InvalidTransitionError) { member.deactivate! }
270275
end

test/models/member_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,7 @@ class MemberTest < ActiveSupport::TestCase
375375
end
376376

377377
test "set_default_waiting_delivery_cycle" do
378+
travel_to "2024-01-01"
378379
member = members(:aria)
379380
member.update!(waiting_delivery_cycle_id: nil)
380381
assert_equal delivery_cycles(:all), member.waiting_delivery_cycle

test/models/membership/activity_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,23 @@
44

55
class Membership::ActivityTest < ActiveSupport::TestCase
66
test "set activity_participations_demanded_annually by default" do
7+
travel_to "2024-01-01"
78
basket_sizes(:medium).update!(activity_participations_demanded_annually: 5)
89
membership = create_membership(basket_size: basket_sizes(:medium))
910

1011
assert_equal 5, membership.activity_participations_demanded_annually
1112
end
1213

1314
test "set activity_participations_demanded_annually using basket quantity" do
15+
travel_to "2024-01-01"
1416
basket_sizes(:medium).update!(activity_participations_demanded_annually: 5)
1517
membership = create_membership(basket_size: basket_sizes(:medium), basket_quantity: 2)
1618

1719
assert_equal 10, membership.activity_participations_demanded_annually
1820
end
1921

2022
test "set activity_participations_demanded_annually using basket_size and complements" do
23+
travel_to "2024-01-01"
2124
basket_sizes(:medium).update!(activity_participations_demanded_annually: 5)
2225
basket_complements(:bread).update!(activity_participations_demanded_annually: 2)
2326
basket_complements(:eggs).update!(activity_participations_demanded_annually: 3)
@@ -33,6 +36,7 @@ class Membership::ActivityTest < ActiveSupport::TestCase
3336
end
3437

3538
test "set activity_participations_demanded_annually when overridden" do
39+
travel_to "2024-01-01"
3640
membership = create_membership(activity_participations_demanded_annually: 12)
3741

3842
assert_equal 12, membership.activity_participations_demanded_annually

test/models/membership_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,7 @@ class MembershipTest < ActiveSupport::TestCase
339339
end
340340

341341
test "activates pending member on creation" do
342+
travel_to "2024-01-01"
342343
member = members(:aria)
343344
assert_changes -> { member.reload.state }, from: "waiting", to: "active" do
344345
create_membership(member: member)

test/models/newsletter_test.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ class NewsletterTest < ActiveSupport::TestCase
165165
end
166166

167167
test "persist deliveries draft when saved" do
168+
travel_to "2024-01-01"
168169
members(:john).update!(emails: "[email protected], [email protected]")
169170
suppress_email("[email protected]", stream_id: "broadcast")
170171

@@ -185,6 +186,7 @@ class NewsletterTest < ActiveSupport::TestCase
185186
end
186187

187188
test "send newsletter" do
189+
travel_to "2024-01-01"
188190
newsletter = build_newsletter(
189191
audience: "member_state::active",
190192
template: newsletter_templates(:simple),
@@ -225,6 +227,7 @@ class NewsletterTest < ActiveSupport::TestCase
225227
end
226228

227229
test "send single email" do
230+
travel_to "2024-01-01"
228231
newsletter = build_newsletter(
229232
audience: "member_state::active",
230233
template: newsletter_templates(:simple),

test/models/notifier_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
class NotifierTest < ActiveSupport::TestCase
66
test "send_admin_memberships_renewal_pending_emails" do
7+
travel_to "2024-01-01"
78
admins(:ultra).update(notifications: [ "memberships_renewal_pending" ])
89
end_of_fiscal_year = Current.fiscal_year.end_of_year
910
memberships(:john).update!(renew: true, renewal_opened_at: nil, renewed_at: nil)

test/system/members/accounts_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class Members::AccountsTest < ApplicationSystemTestCase
2020
end
2121

2222
test "edits current member data" do
23+
travel_to "2024-01-01"
2324
member = members(:john)
2425
login(member)
2526

0 commit comments

Comments
 (0)