Refactor Notifier module into Notification namespace

The monolithic Notifier module was becoming unwieldy with 15+ notification
types all in one file. This refactoring splits each notification into its
own class under app/models/notification/, following the PORO pattern.

Each notification class inherits from Notification::Base which provides:
- notify/notify_later class methods for sync/async execution
- mail_template DSL to declare the associated MailTemplate
- mail_template_active? for efficient existence check
- deliver_later helper for sending emails

The scheduled jobs now enqueue each notification individually, providing
better parallelization and failure isolation. Added MailTemplate.active_template?
for efficient EXISTS queries when only checking template availability.

Author: thibaudgg

app/jobs/notification_job.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class NotificationJob < ApplicationJob
+  queue_as :low
+
+  def perform(notification_class_name)
+    notification_class_name.constantize.notify
+  end
+end

app/jobs/scheduled/notifier_daily_job.rb

@@ -2,8 +2,25 @@
 
 module Scheduled
   class NotifierDailyJob < BaseJob
+    NOTIFICATIONS = [
+      Notification::InvoiceOverdueNotice,
+      Notification::AdminDeliveryList,
+      Notification::AdminMembershipsRenewalPending,
+      Notification::MembershipInitialBasket,
+      Notification::MembershipFinalBasket,
+      Notification::MembershipFirstBasket,
+      Notification::MembershipLastBasket,
+      Notification::MembershipSecondLastTrialBasket,
+      Notification::MembershipLastTrialBasket,
+      Notification::MembershipRenewalReminder,
+      Notification::ActivityParticipationReminder,
+      Notification::ActivityParticipationValidated,
+      Notification::ActivityParticipationRejected,
+      Notification::BiddingRoundOpenedReminder
+    ].freeze
+
     def perform
-      Notifier.send_all_daily
+      NOTIFICATIONS.each(&:notify_later)
     end
   end
 end

app/jobs/scheduled/notifier_hourly_job.rb

@@ -2,8 +2,12 @@
 
 module Scheduled
   class NotifierHourlyJob < BaseJob
+    NOTIFICATIONS = [
+      Notification::AdminNewActivityParticipation
+    ].freeze
+
     def perform
-      Notifier.send_all_hourly
+      NOTIFICATIONS.each(&:notify_later)
     end
   end
 end

app/models/mail_template.rb

@@ -93,6 +93,10 @@ def self.active_template(title)
     active.find_by(title: title)
   end
 
+  def self.active_template?(title)
+    active.exists?(title: title)
+  end
+
   def self.create_all!
     TITLES.each do |title|
       find_or_create_by!(title: title)

app/models/notification/activity_participation_rejected.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+class Notification::ActivityParticipationRejected < Notification::Base
+  mail_template :activity_participation_rejected
+
+  def notify
+    return unless Current.org.feature?("activity")
+    return unless mail_template_active?
+
+    ActivityParticipationGroup.group(eligible_participations).each do |group|
+      deliver_later(activity_participation_ids: group.ids)
+      group.touch(:review_sent_at)
+    end
+  end
+
+  private
+
+  def eligible_participations
+    ActivityParticipation
+      .where(rejected_at: 3.days.ago..)
+      .review_not_sent
+      .includes(:activity, :member)
+      .select(&:can_send_email?)
+  end
+end

app/models/notification/activity_participation_reminder.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+class Notification::ActivityParticipationReminder < Notification::Base
+  mail_template :activity_participation_reminder
+
+  def notify
+    return unless Current.org.feature?("activity")
+
+    ActivityParticipationGroup.group(eligible_participations).each do |group|
+      deliver_later(activity_participation_ids: group.ids)
+      group.touch(:latest_reminder_sent_at)
+    end
+  end
+
+  private
+
+  def eligible_participations
+    ActivityParticipation
+      .future
+      .includes(:activity, :member)
+      .select(&:reminderable?)
+      .select(&:can_send_email?)
+  end
+end

app/models/notification/activity_participation_validated.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+class Notification::ActivityParticipationValidated < Notification::Base
+  mail_template :activity_participation_validated
+
+  def notify
+    return unless Current.org.feature?("activity")
+    return unless mail_template_active?
+
+    ActivityParticipationGroup.group(eligible_participations).each do |group|
+      deliver_later(activity_participation_ids: group.ids)
+      group.touch(:review_sent_at)
+    end
+  end
+
+  private
+
+  def eligible_participations
+    ActivityParticipation
+      .where(validated_at: 3.days.ago..)
+      .review_not_sent
+      .includes(:activity, :member)
+      .select(&:can_send_email?)
+  end
+end

app/models/notification/admin_delivery_list.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+class Notification::AdminDeliveryList < Notification::Base
+  def notify
+    return unless next_delivery
+    return unless Date.current == (next_delivery.date - 1.day)
+
+    notify_depots
+    notify_admins
+  end
+
+  private
+
+  def next_delivery
+    @next_delivery ||= Delivery.next
+  end
+
+  def notify_depots
+    next_delivery.depots.select(&:emails?).each do |depot|
+      AdminMailer.with(
+        depot: depot,
+        delivery: next_delivery
+      ).depot_delivery_list_email.deliver_later
+    end
+  end
+
+  def notify_admins
+    Admin.notify!(:delivery_list, delivery: next_delivery)
+  end
+end

app/models/notification/admin_memberships_renewal_pending.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+class Notification::AdminMembershipsRenewalPending < Notification::Base
+  def notify
+    return unless notify_today?
+    return unless pending_memberships.any? || opened_memberships.any?
+
+    Admin.notify!(:memberships_renewal_pending,
+      pending_memberships: pending_memberships.to_a,
+      opened_memberships: opened_memberships.to_a,
+      pending_action_url: memberships_url(renewal_state_eq: :renewal_pending),
+      opened_action_url: memberships_url(renewal_state_eq: :renewal_opened),
+      action_url: memberships_url)
+  end
+
+  private
+
+  def notify_today?
+    Current.fiscal_year.end_of_year == 10.days.from_now.to_date
+  end
+
+  def pending_memberships
+    @pending_memberships ||= Membership.current_year.renewal_state_eq(:renewal_pending)
+  end
+
+  def opened_memberships
+    @opened_memberships ||= Membership.current_year.renewal_state_eq(:renewal_opened)
+  end
+
+  def memberships_url(**options)
+    Rails
+      .application
+      .routes
+      .url_helpers
+      .memberships_url(
+        q: { during_year: Current.fy_year }.merge(options),
+        scope: :all,
+        host: Current.org.admin_url)
+  end
+end

app/models/notification/admin_new_activity_participation.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+class Notification::AdminNewActivityParticipation < Notification::Base
+  def notify
+    return unless Current.org.feature?("activity")
+
+    ActivityParticipationGroup.group(eligible_participations).each do |group|
+      notify_admins(group)
+      group.touch(:admins_notified_at)
+    end
+  end
+
+  private
+
+  def eligible_participations
+    ActivityParticipation
+      .where(created_at: 1.day.ago.., admins_notified_at: nil)
+      .includes(:activity, :member, :session)
+  end
+
+  def notify_admins(group)
+    attrs = {
+      activity_participation_ids: group.ids,
+      skip: group.session&.admin
+    }
+    Admin.notify!(:new_activity_participation, **attrs)
+    Admin.notify!(:new_activity_participation_with_note, **attrs) if group.note?
+  end
+end