Exclude empty baskets from trial basket count

Baskets with quantity = 0 (complement-only baskets) should not be
counted as trial baskets. Only baskets with an actual basket quantity
are now marked as trial.

Author: thibaudgg

app/models/member.rb

@@ -185,7 +185,7 @@ def update_trial_baskets!
     recent_baskets = self.baskets.where(deliveries: { date: min_date.. }).includes(:membership)
     transaction do
       recent_baskets.trial.update_all(state: "normal")
-      recent_baskets.normal.limit(trial_baskets_count).update_all(state: "trial")
+      recent_baskets.normal.where("baskets.quantity > 0").limit(trial_baskets_count).update_all(state: "trial")
       recent_baskets.map(&:membership).uniq.each(&:update_baskets_counts!)
     end
   end

test/models/member_test.rb

@@ -273,6 +273,26 @@ class MemberTest < ActiveSupport::TestCase
     ], members(:jane).baskets.between(range).map { |b| [ b.delivery.date.to_s, b.trial? ] }
   end
 
+  test "update_trial_baskets! ignores empty baskets (quantity = 0)" do
+    travel_to "2024-01-01"
+    org(trial_baskets_count: 2)
+    member = members(:jane)
+    range = Date.new(2024, 1, 1)..Date.new(2024, 5, 1)
+
+    # Set first basket quantity to 0 (complement-only basket)
+    first_basket = member.baskets.between(range).first
+    first_basket.update_column(:quantity, 0)
+
+    member.update_trial_baskets!
+
+    assert_equal [
+     [ "2024-04-04", false ],  # Empty basket, not counted as trial
+     [ "2024-04-11", true ],
+     [ "2024-04-18", true ],
+     [ "2024-04-25", false ]
+    ], member.baskets.between(range).map { |b| [ b.delivery.date.to_s, b.trial? ] }
+  end
+
   test "emails= / emails" do
     member = Member.new(emails: "[email protected], [email protected]")
     assert_equal "[email protected], [email protected]", member.emails