Upgrade Go version from 1.23 to 1.24 - #418
Merged
Merged
Conversation
Co-authored-by: cschleiden <2201819+cschleiden@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Upgrade to go 1.24
Upgrade Go version from 1.23 to 1.24
Aug 18, 2025
cschleiden
marked this pull request as ready for review
August 18, 2025 21:13
cschleiden
enabled auto-merge
August 18, 2025 21:13
Owner
|
@copilot There is a test failure: |
Co-authored-by: cschleiden <2201819+cschleiden@users.noreply.github.com>
auto-merge was automatically disabled
August 18, 2025 21:24
Head branch was pushed to by a user without write access
Contributor
Author
... Fixed the test failure. The issue was that Go 1.24 changed how anonymous functions are named in stack traces - they now include the pattern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Go version used throughout the project from 1.23 to 1.24. The upgrade includes:
Changes Made
Updated
go.mod: Changed the Go version requirement fromgo 1.23togo 1.24and updated the toolchain fromgo1.23.4togo1.24.6Updated GitHub Actions workflows: Updated all Go version references in CI/CD pipelines:
.github/workflows/go.yml: Updated 4 instances across build, test_redis, test_sqlite, and test_mysql jobs.github/workflows/bench.yml: Updated 3 instances across mysql-bench, sqlite-bench, and redis-bench jobsFixed stack trace test: Updated
internal/workflowerrors/stack_test.goto work with Go 1.24's new anonymous function naming convention where functions are named with.func1,.func2, etc. in stack traces.Validation
✅ Build compatibility: Verified with
go build -v ./...- all packages build successfully✅ Test suite: Ran short test suite - all core functionality tests pass including the fixed stack trace test
✅ Sample applications: Tested the simple workflow sample with SQLite backend - works correctly
✅ Backward compatibility: Go 1.24 maintains full backward compatibility with Go 1.23 code
The upgrade is straightforward as Go 1.24 maintains backward compatibility with Go 1.23, and the codebase follows standard Go practices. All existing functionality continues to work as expected.
The only test failure was due to a change in Go 1.24's runtime behavior where anonymous functions are now named with patterns like
functionName.func1in stack traces, which is expected and the test has been updated accordingly.Fixes #417.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.