Merge pull request #100 from cseptesting/88-test-coverage

Improved unit and e2e tests for panel viewer

Author: pabloitu

floatcsep/commands/main.py

@@ -159,7 +159,7 @@ def view(config: str, **kwargs) -> None:
     exp.stage_models()
     exp.set_tree()
     log.info(f"Creating Panel App")
-    run_app(experiment=exp)
+    run_app(experiment=exp, **kwargs)
 
 
 def reproduce(config: str, **kwargs) -> None:

floatcsep/postprocess/panel/app.py

@@ -12,6 +12,8 @@ def run_app(
     address: str = "localhost",
     show: bool = True,
     title: Optional[str] = None,
+    start: bool = True,
+    **kwargs,
 ) -> None:
     pn.extension()
 
@@ -31,4 +33,6 @@ def run_app(
         show=show,
         title=title or manifest.name,
         static_dirs={"artifacts": str(artifacts_dir)},
+        start=start,
+        **kwargs
     )

floatcsep/postprocess/panel/views/cats.py

@@ -86,8 +86,14 @@ def _load_csep_catalog_from_manifest(manifest: Manifest):
     if not path:
         return None
 
+    app_root = Path(getattr(manifest, "app_root", "."))
     path_obj = Path(path)
 
+    if not path_obj.is_absolute():
+        path_obj = (app_root / path_obj).resolve()
+    else:
+        path_obj = path_obj.resolve()
+
     try:
         if path_obj.suffix.lower() == ".json":
             try:

tests/e2e/test_data.py

@@ -42,6 +42,10 @@ def repr_evaluation(cfg_file):
     def get_eval_dist(self):
         pass
 
+    @staticmethod
+    def view_dashboard(cfg_file):
+        main.view(cfg_file, show=True, start=False)
+
 
 @patch("floatcsep.commands.main.plot_forecasts")
 @patch("floatcsep.commands.main.plot_catalogs")
@@ -123,3 +127,24 @@ def test_case_f(self, *args):
         cfg = self.get_rerunpath("f")
         self.repr_evaluation(cfg)
         self.assertEqual(1, 1)
+
+
+@patch("floatcsep.commands.main.plot_forecasts")
+@patch("floatcsep.commands.main.plot_catalogs")
+@patch("floatcsep.commands.main.plot_custom")
+@patch("floatcsep.commands.main.generate_report")
+class ViewExamples(DataTest):
+    def test_case_c(self, *args):
+        cfg = self.get_rerunpath("c")
+        self.view_dashboard(cfg)
+        self.assertEqual(1, 1)
+
+    def test_case_f(self, *args):
+        cfg = self.get_rerunpath("f")
+        self.view_dashboard(cfg)
+        self.assertEqual(1, 1)
+
+    def test_case_g(self, *args):
+        cfg = self.get_rerunpath("g")
+        self.view_dashboard(cfg)
+        self.assertEqual(1, 1)