Drop any tol=0.00001 from bin1d_vec calls or their calling function

... even in the unit tests
(only used when binning magnitudes)

Notes:
* specifying `tol=0.00001` was not even necessary with the revised tolerance section by commit 949d342 (albeit most of the `tol=0.00001` were introduced by this commit);
* Why? because magnitude bins are "cleanly" created with `np.arange()` in `csep.core.regions.magnitude_bins`;
* their redundancy is confirmed by passing the corresponding unit test `test_scalar_outside` without `tol=0.00001` using the unfixed `bin1d_vec`;
* yet, I left optional `tol=None` argument in `bin1d_vec` and the functions that call it -- just in case there is a real need to override tolerance.

Author: mherrmann3

csep/core/catalogs.py

@@ -395,7 +395,7 @@ def to_dataframe(self, with_datetime=False):
     def get_mag_idx(self):
         """ Return magnitude index from region magnitudes """
         try:
-            return bin1d_vec(self.get_magnitudes(), self.region.magnitudes, tol=0.00001, right_continuous=True)
+            return bin1d_vec(self.get_magnitudes(), self.region.magnitudes, right_continuous=True)
         except AttributeError:
             raise CSEPCatalogException("Cannot return magnitude index without self.region.magnitudes")
 
@@ -699,7 +699,7 @@ def spatial_event_probability(self):
         event_flag[idx] = 1
         return event_flag
 
-    def magnitude_counts(self, mag_bins=None, tol=0.00001, retbins=False):
+    def magnitude_counts(self, mag_bins=None, tol=None, retbins=False):
         """ Computes the count of events within mag_bins
 
 
@@ -734,7 +734,7 @@ def magnitude_counts(self, mag_bins=None, tol=0.00001, retbins=False):
         else:
             return out
 
-    def spatial_magnitude_counts(self, mag_bins=None, tol=0.00001):
+    def spatial_magnitude_counts(self, mag_bins=None, tol=None):
         """ Return counts of events in space-magnitude region.
 
         We figure out the index of the polygons and create a map that relates the spatial coordinate in the

csep/core/forecasts.py

@@ -213,7 +213,7 @@ def magnitude_counts(self):
         """ Returns counts of events in magnitude bins """
         return numpy.sum(self.data, axis=0)
 
-    def get_magnitude_index(self, mags, tol=0.00001):
+    def get_magnitude_index(self, mags, tol=None):
         """ Returns the indices into the magnitude bins of selected magnitudes
 
         Note: the right-most bin is treated as extending to infinity.

csep/core/regions.py

@@ -495,7 +495,7 @@ def compute_vertices(origin_points, dh, tol=numpy.finfo(float).eps):
     """
     return list(map(lambda x: compute_vertex(x, dh, tol=tol), origin_points))
 
-def _bin_catalog_spatio_magnitude_counts(lons, lats, mags, n_poly, mask, idx_map, binx, biny, mag_bins, tol=0.00001):
+def _bin_catalog_spatio_magnitude_counts(lons, lats, mags, n_poly, mask, idx_map, binx, biny, mag_bins, tol=None):
     """
     Returns a list of event counts as ndarray with shape (n_poly, n_cat) where each value
     represents the event counts within the polygon.
@@ -1182,7 +1182,7 @@ def _get_spatial_magnitude_counts(self, catalog, mag_bins=None):
         out = numpy.zeros([len(self.quadkeys), len(mag_bins)])
 
         idx_loc = self.get_index_of(lon, lat)
-        idx_mag = bin1d_vec(mag, mag_bins, tol=0.00001, right_continuous=True)
+        idx_mag = bin1d_vec(mag, mag_bins, right_continuous=True)
 
         numpy.add.at(out, (idx_loc, idx_mag), 1)
 

tests/test_calc.py

@@ -137,15 +137,15 @@ def test_less_and_greater_than(self):
     def test_scalar_outside(self):
         from csep.utils.calc import bin1d_vec
         mbins = numpy.arange(5.95, 9, 0.1)  # This gives bins from 5.95 to 8.95
-        idx = bin1d_vec(5.95, mbins, tol=0.00001, right_continuous=True)
+        idx = bin1d_vec(5.95, mbins, right_continuous=True)
         self.assertEqual(idx, 0)
 
-        idx = bin1d_vec(6, mbins, tol=0.00001, right_continuous=True)  # This would give 0: Which is fine.
+        idx = bin1d_vec(6, mbins, right_continuous=True)  # This would give 0: Which is fine.
         self.assertEqual(idx, 0)
 
-        idx = bin1d_vec(5, mbins, tol=0.00001, right_continuous=True)
+        idx = bin1d_vec(5, mbins, right_continuous=True)
         self.assertEqual(idx, -1)
 
-        idx = bin1d_vec(4, mbins, tol=0.00001, right_continuous=True)
+        idx = bin1d_vec(4, mbins, right_continuous=True)
         self.assertEqual(idx, -1)