notifications/tests: Fix flaky libp2p_disconnects_libp2p_substream test (paritytech#10886)

Under load, 5 seconds might not be enough for the CI to capture all
events generated by the net backend.

In this PR, the timeout is increased to 60s after which a hard panic
occurs.

Discovered during:
- paritytech#10846

Signed-off-by: Alexandru Vasile <[email protected]>

Author: lexnv

substrate/client/network/src/protocol/notifications/tests/conformance.rs

@@ -371,8 +371,8 @@ async fn libp2p_disconnects_libp2p_substream() {
 
 	libp2p_rhs.dial(libp2p_lhs_address).unwrap();
 
-	// Disarm first timer interval that fires immediately.
-	let mut timer = tokio::time::interval(std::time::Duration::from_secs(5));
+	// Timeout as a safety guard in case the test hangs.
+	let mut timer = tokio::time::interval(std::time::Duration::from_secs(60));
 	timer.tick().await;
 
 	let mut sink = None;
@@ -388,7 +388,7 @@ async fn libp2p_disconnects_libp2p_substream() {
 	loop {
 		tokio::select! {
 			_ = timer.tick() => {
-				break;
+				panic!("Test timed out waiting for expected events");
 			}
 
 			event = libp2p_lhs.select_next_some() => {
@@ -488,6 +488,17 @@ async fn libp2p_disconnects_libp2p_substream() {
 
 			},
 		}
+
+		// Check if all expected events have occurred
+		if open_times == 2 &&
+			notification_count == 4 &&
+			recv_1111 == 2 &&
+			recv_2222 == 2 &&
+			recv_3333 == 2 &&
+			recv_4444 == 2
+		{
+			break;
+		}
 	}
 
 	assert_eq!(open_times, 2);