From 7e66f3fcdb74b425b49cfdb6770549e855423921 Mon Sep 17 00:00:00 2001 From: Madhu Rajanna Date: Wed, 26 Nov 2025 13:48:13 +0100 Subject: [PATCH] fix: remove duplicate CEL rule for secrets we have 2 CEL rules for secrets, the rules is same but with two different messages, removing the duplicate one added recently fixes: #879 Signed-off-by: Madhu Rajanna --- api/csiaddons/v1alpha1/networkfence_types.go | 1 - config/crd/bases/csiaddons.openshift.io_networkfences.yaml | 2 -- deploy/controller/crds.yaml | 2 -- 3 files changed, 5 deletions(-) diff --git a/api/csiaddons/v1alpha1/networkfence_types.go b/api/csiaddons/v1alpha1/networkfence_types.go index 3b12f2581..8f28552c9 100644 --- a/api/csiaddons/v1alpha1/networkfence_types.go +++ b/api/csiaddons/v1alpha1/networkfence_types.go @@ -92,7 +92,6 @@ type NetworkFenceSpec struct { // Secret is a kubernetes secret, which is required to perform the fence/unfence operation. // +kubebuilder:deprecatedversion:warning="specifying secrets in networkfence is deprecated, please use networkFenceClassName instead" // +kubebuilder:validation:Optional - // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="secrets are immutable" Secret SecretSpec `json:"secret,omitempty"` // Parameters is used to pass additional parameters to the CSI driver. diff --git a/config/crd/bases/csiaddons.openshift.io_networkfences.yaml b/config/crd/bases/csiaddons.openshift.io_networkfences.yaml index b96d65c5a..4c7cc794a 100644 --- a/config/crd/bases/csiaddons.openshift.io_networkfences.yaml +++ b/config/crd/bases/csiaddons.openshift.io_networkfences.yaml @@ -112,8 +112,6 @@ spec: rule: self == oldSelf type: object x-kubernetes-validations: - - message: secrets are immutable - rule: self == oldSelf - message: secret is immutable rule: self == oldSelf required: diff --git a/deploy/controller/crds.yaml b/deploy/controller/crds.yaml index 9c7f5c9bc..8317f9757 100644 --- a/deploy/controller/crds.yaml +++ b/deploy/controller/crds.yaml @@ -771,8 +771,6 @@ spec: rule: self == oldSelf type: object x-kubernetes-validations: - - message: secrets are immutable - rule: self == oldSelf - message: secret is immutable rule: self == oldSelf required: