Skip to content

Commit 4639fa3

Browse files
authored
Merge pull request #437 from csiro-internal/bugfix/camerafirmware-improvements
Evolto's requested camerafirmware improvements Updated approved submodules and changelog. Rod approved over slack
2 parents 00d9a89 + d029d35 commit 4639fa3

5 files changed

Lines changed: 17 additions & 3 deletions

File tree

docs/user/PostProcessing.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,10 @@ The `rcvd_fa_data_summary.csv` and `best_feedback.csv` both have the same CSV fi
120120
- feedback_y: the align_feedback's y position in cvd frame
121121
- feedback_length: (feedback.x^2 + feedback.y^2)^0.5
122122
- bounds_pixels: defines the bounding box in pixels
123+
- roi_centre_pixel_x: geometric center x position of bounding box
124+
- roi_centre_pixel_y: geometric center y position of bounding box
125+
- roi_rotation_microrads: rotation of bounding box in microradians
126+
- fuel_mark: boolean indicating whether the align_feedback for this index is minimised
123127

124128
The yaml files will have the following messages within:
125129

src/CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,16 @@ This file is to document the high level changes to the RCVD project from release
99
- Added `--rcvd_scale_camerafirmware_to_12bit` and `--ignore` args to handbag. This is to scale 16-bit images to be 12-bit.
1010
- Added `run-handbag-image-scale.bash` script to run handbag outside of RCVD GUI.
1111
- Added `docs/dev/Images.md`.
12+
- Added `mask_radius` and `fuel_size` to `iaea-xcvd-camerafirmware` parameters. `fuel_size` is calculated from CV params `fa_size` and `pixel_size`.
13+
- Added `roi_centre_pixel_x`, `roi_centre_pixel_y`, `roi_rotation_microrads` and `fuel_mark` to CSV outputs from Handbag's Summarise FA Data
14+
15+
### Changed
16+
17+
- Updated `session.py` to forward `fa_size` and `pixel_size` to two topics, CV (original) and camerafirmware (new)
18+
19+
### Fixed
20+
21+
- Fixed bug where `slamcomms.cpp` was only writing x values for `slam_orientation_euler_scaled`.
1222

1323
## 1.18.13 - 2026-04-14
1424

src/handbag

src/iaea-xcvd-camerafirmware

src/rcvd_ui

0 commit comments

Comments
 (0)