fix: normalize args to tuple before BotCommand construction and assertion checks

timkpaine · timkpaine · commit 9107b3974e78 · 2026-06-14T16:35:56.000-04:00
diff --git a/csp_bot_commands/tests/test_fun.py b/csp_bot_commands/tests/test_fun.py
@@ -57,6 +57,8 @@ def test_statics(self):
         ],
     )
     def test_execute(self, args):
+        if isinstance(args, str):
+            args = (args,)
         msg = cmd.execute(
             BotCommand(
                 backend="slack",
@@ -65,7 +67,7 @@ def test_execute(self, args):
                     id="123",
                 ),
                 targets=(User(id="456"),),
-                args=(args,) if isinstance(args, str) else args,
+                args=args,
             )
         )
         assert msg is not None
diff --git a/csp_bot_commands/tests/test_thanks.py b/csp_bot_commands/tests/test_thanks.py
@@ -21,6 +21,8 @@ def test_statics(self):
         ],
     )
     def test_execute(self, args):
+        if isinstance(args, str):
+            args = (args,)
         msg = cmd.execute(
             BotCommand(
                 backend="slack",
@@ -29,7 +31,7 @@ def test_execute(self, args):
                     id="123",
                 ),
                 targets=(User(id="456"),),
-                args=(args,) if isinstance(args, str) else args,
+                args=args,
             )
         )
         assert msg is not None
diff --git a/csp_bot_commands/tests/test_trout.py b/csp_bot_commands/tests/test_trout.py
@@ -21,6 +21,8 @@ def test_statics(self):
         ],
     )
     def test_execute(self, args):
+        if isinstance(args, str):
+            args = (args,)
         msg = cmd.execute(
             BotCommand(
                 backend="slack",
@@ -29,7 +31,7 @@ def test_execute(self, args):
                     id="123",
                 ),
                 targets=(User(id="456"),),
-                args=(args,) if isinstance(args, str) else args,
+                args=args,
             )
         )
         assert msg is not None

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ def test_statics(self):`
`57`	`57`	`],`
`58`	`58`	`)`
`59`	`59`	`def test_execute(self, args):`
	`60`	`+ if isinstance(args, str):`
	`61`	`+ args = (args,)`
`60`	`62`	`msg = cmd.execute(`
`61`	`63`	`BotCommand(`
`62`	`64`	`backend="slack",`
`@@ -65,7 +67,7 @@ def test_execute(self, args):`
`65`	`67`	`id="123",`
`66`	`68`	`),`
`67`	`69`	`targets=(User(id="456"),),`
`68`		`- args=(args,) if isinstance(args, str) else args,`
	`70`	`+ args=args,`
`69`	`71`	`)`
`70`	`72`	`)`
`71`	`73`	`assert msg is not None`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@ def test_statics(self):`
`21`	`21`	`],`
`22`	`22`	`)`
`23`	`23`	`def test_execute(self, args):`
	`24`	`+ if isinstance(args, str):`
	`25`	`+ args = (args,)`
`24`	`26`	`msg = cmd.execute(`
`25`	`27`	`BotCommand(`
`26`	`28`	`backend="slack",`
`@@ -29,7 +31,7 @@ def test_execute(self, args):`
`29`	`31`	`id="123",`
`30`	`32`	`),`
`31`	`33`	`targets=(User(id="456"),),`
`32`		`- args=(args,) if isinstance(args, str) else args,`
	`34`	`+ args=args,`
`33`	`35`	`)`
`34`	`36`	`)`
`35`	`37`	`assert msg is not None`