Police Page + Date Filter #80 (#97)

* Added basic embedded map in newly created components folder under EmbeddedMap.tsx. this is using the google maps API, using a personal API key that I would love to change.

* Implemented basic embed map

* created react map

* Created changed to

* Fixed Embedded Map to include the react integration library ( vis.gl/react-google-map). Created example map of Syndey with map pointers to different locations.

* Created Party Demo test page

* First mockup of party list props, and page created to be displayed in party demo

* Added popup text box and color to map

* Removed package and package lock in root directory, updated .env.template

* Created functioning dropdown for party list

* Implemented Radius Search Route

* fixed tests to use mock

* hopefully fixed mocks

* Modified styling to be accurate with the Lo-Fi wireframe

* Made changes as requested in ticket appraisal

* further main merging

* Fised broken tests from merge

* Update frontend/src/components/PartyList.tsx

Minor change to parties

Co-authored-by: Nicolas Asanov <[email protected]>

* pulled from mason branch, started work on police page. needs lots of work

* wip changed a bunch of things, built police page, added small changes to related components for compatibility and neccesary funcitonality

* changed a little margins

* fix: corrected auth in location tests

---------

Co-authored-by: MasonMines2006 <[email protected]>
Co-authored-by: Nicolas Asanov <[email protected]>
Co-authored-by: MasonMines2006 <[email protected]>
Co-authored-by: Vasu <[email protected]>
Co-authored-by: Nick A <[email protected]>

Author: 4 people

backend/src/core/config.py

@@ -25,4 +25,4 @@ class Config(BaseSettings):
     GOOGLE_MAPS_API_KEY: str
 
 
-env = Config()  # pyright: ignore[reportCallIssue]
+env = Config()  # pyright: ignore[reportCallIssue]

backend/src/modules/location/location_router.py

@@ -1,17 +1,19 @@
 from fastapi import APIRouter, Depends, HTTPException, status
 from src.core.authentication import (
     authenticate_admin,
+    authenticate_by_role,
     authenticate_staff_or_admin,
-    authenticate_user,
 )
 from src.modules.account.account_model import Account
 from src.modules.location.location_model import (
+    AddressData,
     Location,
     LocationCreate,
     LocationData,
     PaginatedLocationResponse,
 )
 from src.modules.location.location_service import LocationService
+from src.modules.police.police_model import PoliceAccount
 
 from .location_model import AutocompleteInput, AutocompleteResult
 
@@ -28,7 +30,9 @@
 async def autocomplete_address(
     input_data: AutocompleteInput,
     location_service: LocationService = Depends(),
-    user: Account = Depends(authenticate_user),
+    user: Account | PoliceAccount = Depends(
+        authenticate_by_role("police", "student", "admin", "staff")
+    ),
 ) -> list[AutocompleteResult]:
     """
     Autocomplete address search endpoint.
@@ -50,6 +54,38 @@ async def autocomplete_address(
         )
 
 
+@location_router.get(
+    "/place-details/{place_id}",
+    response_model=AddressData,
+    status_code=status.HTTP_200_OK,
+    summary="Get place details from Google Maps place ID",
+    description="Returns address details including coordinates for a given place ID.",
+)
+async def get_place_details(
+    place_id: str,
+    location_service: LocationService = Depends(),
+    user: Account | PoliceAccount = Depends(
+        authenticate_by_role("police", "student", "admin", "staff")
+    ),
+) -> AddressData:
+    """
+    Get place details endpoint.
+    """
+    try:
+        address_data = await location_service.get_place_details(place_id)
+        return address_data
+    except ValueError as e:
+        raise HTTPException(
+            status_code=status.HTTP_400_BAD_REQUEST,
+            detail=str(e),
+        )
+    except Exception:
+        raise HTTPException(
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail="Failed to fetch place details. Please try again later.",
+        )
+
+
 @location_router.get("/", response_model=PaginatedLocationResponse)
 async def get_locations(
     location_service: LocationService = Depends(),

backend/test/modules/location/location_router_test.py

@@ -4,9 +4,7 @@
 import pytest
 import pytest_asyncio
 from httpx import ASGITransport, AsyncClient
-from src.core.authentication import authenticate_user
 from src.main import app
-from src.modules.account.account_model import Account, AccountRole
 from src.modules.location.location_model import AutocompleteResult
 from src.modules.location.location_service import LocationService
 
@@ -21,20 +19,9 @@ async def mock_location_service():
 async def override_dependencies(mock_location_service: AsyncMock):
     """Override dependencies to provide mock service and auth"""
 
-    async def _fake_user():
-        return Account(
-            id=1,
-            email="[email protected]",
-            first_name="Test",
-            last_name="User",
-            pid="123456789",
-            role=AccountRole.STUDENT,
-        )
-
     def _get_mock_location_service():
         return mock_location_service
 
-    app.dependency_overrides[authenticate_user] = _fake_user
     app.dependency_overrides[LocationService] = _get_mock_location_service
     yield
     app.dependency_overrides.clear()
@@ -52,9 +39,20 @@ def _get_mock_location_service():
     app.dependency_overrides.clear()
 
 
+@pytest_asyncio.fixture
+async def admin_client(override_dependencies: Any):
+    """Create an authenticated admin client"""
+    async with AsyncClient(
+        transport=ASGITransport(app=app),
+        base_url="http://test",
+        headers={"Authorization": "Bearer admin"},
+    ) as client:
+        yield client
+
+
 @pytest.mark.asyncio
 async def test_autocomplete_success(
-    override_dependencies: Any, mock_location_service: AsyncMock
+    admin_client: AsyncClient, mock_location_service: AsyncMock
 ):
     """Test that the endpoint returns multiple address suggestions successfully"""
     mock_results = [
@@ -69,67 +67,53 @@ async def test_autocomplete_success(
     ]
     mock_location_service.autocomplete_address.return_value = mock_results
 
-    async with AsyncClient(
-        transport=ASGITransport(app=app), base_url="http://test"
-    ) as client:
-        response = await client.post(
-            "/api/locations/autocomplete", json={"address": "123 Main St"}
-        )
+    response = await admin_client.post(
+        "/api/locations/autocomplete", json={"address": "123 Main St"}
+    )
 
-        assert response.status_code == 200
-        data = response.json()
-        assert len(data) == 2
-        assert data[0]["formatted_address"] == "123 Main St, Chapel Hill, NC 27514, USA"
-        assert data[0]["place_id"] == "ChIJTest123"
-        mock_location_service.autocomplete_address.assert_called_once_with(
-            "123 Main St"
-        )
+    assert response.status_code == 200
+    data = response.json()
+    assert len(data) == 2
+    assert data[0]["formatted_address"] == "123 Main St, Chapel Hill, NC 27514, USA"
+    assert data[0]["place_id"] == "ChIJTest123"
+    mock_location_service.autocomplete_address.assert_called_once_with("123 Main St")
 
 
 @pytest.mark.asyncio
 async def test_autocomplete_empty_results(
-    override_dependencies: Any, mock_location_service: AsyncMock
+    admin_client: AsyncClient, mock_location_service: AsyncMock
 ):
     """Test that the endpoint returns an empty list when no addresses match"""
     mock_location_service.autocomplete_address.return_value = []
 
-    async with AsyncClient(
-        transport=ASGITransport(app=app), base_url="http://test"
-    ) as client:
-        response = await client.post(
-            "/api/locations/autocomplete",
-            json={"address": "nonexistentaddress12345xyz"},
-        )
+    response = await admin_client.post(
+        "/api/locations/autocomplete",
+        json={"address": "nonexistentaddress12345xyz"},
+    )
 
-        assert response.status_code == 200
-        assert response.json() == []
+    assert response.status_code == 200
+    assert response.json() == []
 
 
 @pytest.mark.asyncio
-async def test_autocomplete_missing_address(override_dependencies: Any):
+async def test_autocomplete_missing_address(admin_client: AsyncClient):
     """Test that the endpoint returns 422 when address field is missing"""
-    async with AsyncClient(
-        transport=ASGITransport(app=app), base_url="http://test"
-    ) as client:
-        response = await client.post("/api/locations/autocomplete", json={})
-        assert response.status_code == 422
+    response = await admin_client.post("/api/locations/autocomplete", json={})
+    assert response.status_code == 422
 
 
 @pytest.mark.asyncio
 async def test_autocomplete_empty_string(
-    override_dependencies: Any, mock_location_service: AsyncMock
+    admin_client: AsyncClient, mock_location_service: AsyncMock
 ):
     """Test that the endpoint handles empty string gracefully"""
     mock_location_service.autocomplete_address.return_value = []
 
-    async with AsyncClient(
-        transport=ASGITransport(app=app), base_url="http://test"
-    ) as client:
-        response = await client.post(
-            "/api/locations/autocomplete", json={"address": ""}
-        )
-        assert response.status_code == 200
-        assert response.json() == []
+    response = await admin_client.post(
+        "/api/locations/autocomplete", json={"address": ""}
+    )
+    assert response.status_code == 200
+    assert response.json() == []
 
 
 @pytest.mark.asyncio
@@ -146,39 +130,33 @@ async def test_autocomplete_unauthenticated(override_dependencies_no_auth: Any):
 
 @pytest.mark.asyncio
 async def test_autocomplete_service_exception(
-    override_dependencies: Any, mock_location_service: AsyncMock
+    admin_client: AsyncClient, mock_location_service: AsyncMock
 ):
     """Test that service exceptions are handled correctly"""
     mock_location_service.autocomplete_address.side_effect = Exception(
         "Service temporarily unavailable"
     )
 
-    async with AsyncClient(
-        transport=ASGITransport(app=app), base_url="http://test"
-    ) as client:
-        response = await client.post(
-            "/api/locations/autocomplete",
-            json={"address": "123 Test St"},
-        )
+    response = await admin_client.post(
+        "/api/locations/autocomplete",
+        json={"address": "123 Test St"},
+    )
 
-        assert response.status_code == 500
+    assert response.status_code == 500
 
 
 @pytest.mark.asyncio
 async def test_autocomplete_value_error(
-    override_dependencies: Any, mock_location_service: AsyncMock
+    admin_client: AsyncClient, mock_location_service: AsyncMock
 ):
     """Test that ValueError from API is handled correctly"""
     mock_location_service.autocomplete_address.side_effect = ValueError(
         "Invalid API key provided"
     )
 
-    async with AsyncClient(
-        transport=ASGITransport(app=app), base_url="http://test"
-    ) as client:
-        response = await client.post(
-            "/api/locations/autocomplete",
-            json={"address": "123 Test St"},
-        )
+    response = await admin_client.post(
+        "/api/locations/autocomplete",
+        json={"address": "123 Test St"},
+    )
 
-        assert response.status_code == 400
+    assert response.status_code == 400

frontend/.env.template

@@ -1,2 +1,4 @@
-NEXT_PUBLIC_API_BASE_URL=http://localhost:4000
-NEXTAUTH_SECRET=REPLACE_ME
+NEXT_PUBLIC_API_BASE_URL=http://localhost:8000/api
+NEXT_PUBLIC_GOOGLE_MAPS_API_KEY=REPLACE_ME
+NEXT_PUBLIC_GOOGLE_MAP_ID=REPLACE_ME
+NEXTAUTH_SECRET=REPLACE_ME

frontend/package-lock.json

@@ -9,6 +9,7 @@
     "lint": "eslint"
   },
   "dependencies": {
+    "@vis.gl/react-google-maps": "^1.6.1",
     "@hookform/resolvers": "^5.2.2",
     "@radix-ui/react-checkbox": "^1.3.3",
     "@radix-ui/react-dropdown-menu": "^2.1.16",

frontend/package.json

@@ -26,7 +26,7 @@ export default function RootLayout({
   return (
     <html lang="en">
       <body
-        className={`${geistSans.variable} ${geistMono.variable} antialiased`}
+        className={`${geistSans.variable} ${geistMono.variable} antialiased bg-white`}
       >
         <Providers>{children}</Providers>
       </body>

frontend/src/app/layout.tsx

@@ -1,12 +1,25 @@
-
 export default function Home() {
   return (
     <div className="font-sans min-h-screen flex flex-col items-center justify-center p-8 sm:p-20 max-w-2xl mx-auto">
-      <h1 className="text-3xl font-bold mb-6 text-center">Party Registration System</h1>
-      <p className="mb-8 text-lg text-center">A CS+SG project for the Office of Off-Campus Student Life at UNC.</p>
-      <h2 className="text-xl font-semibold mb-4 text-center">About the Office of Off-Campus Student Life</h2>
+      <h1 className="text-3xl font-bold mb-6 text-center">
+        Party Registration System
+      </h1>
+      <p className="mb-8 text-lg text-center">
+        A CS+SG project for the Office of Off-Campus Student Life at UNC.
+      </p>
+      <h2 className="text-xl font-semibold mb-4 text-center">
+        About the Office of Off-Campus Student Life
+      </h2>
       <p className="text-base text-center">
-        The Office of Off-Campus Student Life serves as a vital resource for students living off-campus, providing support, programs, and services to enhance the off-campus living experience. This office works to connect off-campus students with campus resources, facilitate community building, and ensure student safety and well-being in off-campus environments. Through various initiatives and programs, the office aims to bridge the gap between on-campus and off-campus student experiences, fostering a sense of belonging and engagement for all students regardless of their housing situation.
+        The Office of Off-Campus Student Life serves as a vital resource for
+        students living off-campus, providing support, programs, and services to
+        enhance the off-campus living experience. This office works to connect
+        off-campus students with campus resources, facilitate community
+        building, and ensure student safety and well-being in off-campus
+        environments. Through various initiatives and programs, the office aims
+        to bridge the gap between on-campus and off-campus student experiences,
+        fostering a sense of belonging and engagement for all students
+        regardless of their housing situation.
       </p>
     </div>
   );