Commit cb0828a
Fix CMake warnings: optional feature message level + policy version minimum (k2-fsa#3217)
* Downgrade optional feature messages from WARNING to STATUS
TTS and speaker diarization are optional features controlled by
SHERPA_ONNX_ENABLE_TTS and SHERPA_ONNX_ENABLE_SPEAKER_DIARIZATION.
Disabling an optional feature is a normal configuration choice, not a
warning condition. Using message(WARNING) causes spurious CMake warnings
for any project that intentionally sets these to OFF via FetchContent.
Change both to message(STATUS) to match the enabled-path messaging.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Raise CMAKE_POLICY_VERSION_MINIMUM from 3.5 to 3.10
CMake 4.x emits deprecation warnings for cmake_minimum_required()
versions below 3.10 ("Compatibility with CMake < 3.10 will be removed").
Several transitive deps (kaldi-native-fbank 3.5, kissfft 3.6, openfst
3.1) trigger this warning.
Raising the floor to 3.10 suppresses these deprecation notices while
preserving old policy behaviors for all deps. No functional change —
3.10 is still well below sherpa-onnx's own minimum of 3.15.
Co-authored-by: John Suykerbuyk <bd770i@suykerbuyk.org>1 parent 8bb5266 commit cb0828a
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
264 | | - | |
| 264 | + | |
265 | 265 | | |
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
| 272 | + | |
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
| |||
0 commit comments