Remove duplicate code

Author: jlenain

src/nectarchain/dqm/start_dqm.py

@@ -21,6 +21,7 @@
 from nectarchain.dqm.pixel_timeline import PixelTimelineHighLowGain
 from nectarchain.dqm.trigger_statistics import TriggerStatistics
 from nectarchain.makers import ChargesNectarCAMCalibrationTool
+from nectarchain.utils.constants import ALLOWED_CAMERAS
 
 logging.basicConfig(format="%(asctime)s %(name)s %(levelname)s %(message)s")
 log = logging.getLogger(__name__)
@@ -32,10 +33,6 @@ def main():
     Main DQM script
     """
 
-    prefix = "NectarCAM"
-    cameras = [f"{prefix}" + "QM"]
-    cameras.extend([f"{prefix + str(i)}" for i in range(2, 10)])
-
     # Create an ArgumentParser object
     parser = argparse.ArgumentParser(
         description="NectarCAM Data Quality Monitoring tool"
@@ -83,8 +80,8 @@ def main():
     parser.add_argument(
         "-c",
         "--camera",
-        choices=cameras,
-        default=[camera for camera in cameras if "QM" in camera][0],
+        choices=ALLOWED_CAMERAS,
+        default=[camera for camera in ALLOWED_CAMERAS if "QM" in camera][0],
         help="""Process data for a specific NectarCAM camera.
  Default: NectarCAMQM (Qualification Model).""",
         type=str,

src/nectarchain/makers/core.py

@@ -29,6 +29,7 @@
 from ..data import DataManagement
 from ..data.container.core import NectarCAMContainer, TriggerMapContainer
 from ..utils import ComponentUtils
+from ..utils.constants import ALLOWED_CAMERAS
 from .component import NectarCAMComponent, get_valid_component
 
 logging.basicConfig(format="%(asctime)s %(name)s %(levelname)s %(message)s")
@@ -234,12 +235,8 @@ def __new__(cls, *args, **kwargs):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
-        prefix = "NectarCAM"
-        cameras = [f"{prefix}" + "QM"]
-        cameras.extend([f"{prefix + str(i)}" for i in range(2, 10)])
-
-        if self.camera not in cameras and self.run_file is None:
-            raise TraitError(f"The camera field should be one of {cameras}.")
+        if self.camera not in ALLOWED_CAMERAS and self.run_file is None:
+            raise TraitError(f"The camera field should be one of {ALLOWED_CAMERAS}.")
 
         if not ("output_path" in kwargs.keys()):
             self._init_output_path()

src/nectarchain/user_scripts/ggrolleron/gain_PhotoStat_computation.py

@@ -10,10 +10,7 @@
 from nectarchain.data.management import DataManagement
 from nectarchain.makers.calibration import PhotoStatisticNectarCAMCalibrationTool
 from nectarchain.makers.extractor.utils import CtapipeExtractor
-
-prefix = "NectarCAM"
-cameras = [f"{prefix}" + "QM"]
-cameras.extend([f"{prefix + str(i)}" for i in range(2, 10)])
+from nectarchain.utils.constants import ALLOWED_CAMERAS
 
 parser = argparse.ArgumentParser(
     prog="gain_SPEfit_computation.py",
@@ -31,8 +28,8 @@
 parser.add_argument(
     "-c",
     "--camera",
-    choices=cameras,
-    default=[camera for camera in cameras if "QM" in camera][0],
+    choices=ALLOWED_CAMERAS,
+    default=[camera for camera in ALLOWED_CAMERAS if "QM" in camera][0],
     help="""Process data for a specific NectarCAM camera.
 Default: NectarCAMQM (Qualification Model).""",
     type=str,

src/nectarchain/user_scripts/ggrolleron/gain_SPEfit_combined_computation.py

@@ -13,10 +13,7 @@
     FlatFieldSPECombinedStdNectarCAMCalibrationTool,
 )
 from nectarchain.makers.extractor.utils import CtapipeExtractor
-
-prefix = "NectarCAM"
-cameras = [f"{prefix}" + "QM"]
-cameras.extend([f"{prefix + str(i)}" for i in range(2, 10)])
+from nectarchain.utils.constants import ALLOWED_CAMERAS
 
 parser = argparse.ArgumentParser(
     prog="gain_SPEfit_combined_computation.py",
@@ -30,8 +27,8 @@
 parser.add_argument(
     "-c",
     "--camera",
-    choices=cameras,
-    default=[camera for camera in cameras if "QM" in camera][0],
+    choices=ALLOWED_CAMERAS,
+    default=[camera for camera in ALLOWED_CAMERAS if "QM" in camera][0],
     help="""Process data for a specific NectarCAM camera.
 Default: NectarCAMQM (Qualification Model).""",
     type=str,

src/nectarchain/user_scripts/ggrolleron/gain_SPEfit_computation.py

@@ -14,10 +14,7 @@
     FlatFieldSPENominalStdNectarCAMCalibrationTool,
 )
 from nectarchain.makers.extractor.utils import CtapipeExtractor
-
-prefix = "NectarCAM"
-cameras = [f"{prefix}" + "QM"]
-cameras.extend([f"{prefix + str(i)}" for i in range(2, 10)])
+from nectarchain.utils.constants import ALLOWED_CAMERAS
 
 parser = argparse.ArgumentParser(
     prog="gain_SPEfit_computation.py",
@@ -31,8 +28,8 @@
 parser.add_argument(
     "-c",
     "--camera",
-    choices=cameras,
-    default=[camera for camera in cameras if "QM" in camera][0],
+    choices=ALLOWED_CAMERAS,
+    default=[camera for camera in ALLOWED_CAMERAS if "QM" in camera][0],
     help="""Process data for a specific NectarCAM camera.
 Default: NectarCAMQM (Qualification Model).""",
     type=str,

src/nectarchain/user_scripts/ggrolleron/load_wfs_compute_charge.py

@@ -15,10 +15,7 @@
     ChargesNectarCAMCalibrationTool,
     WaveformsNectarCAMCalibrationTool,
 )
-
-prefix = "NectarCAM"
-cameras = [f"{prefix}" + "QM"]
-cameras.extend([f"{prefix + str(i)}" for i in range(2, 10)])
+from nectarchain.utils.constants import ALLOWED_CAMERAS
 
 parser = argparse.ArgumentParser(
     prog="load_wfs_compute_charge",
@@ -33,8 +30,8 @@
 parser.add_argument(
     "-c",
     "--camera",
-    choices=cameras,
-    default=[camera for camera in cameras if "QM" in camera][0],
+    choices=ALLOWED_CAMERAS,
+    default=[camera for camera in ALLOWED_CAMERAS if "QM" in camera][0],
     help="""Process data for a specific NectarCAM camera.
 Default: NectarCAMQM (Qualification Model).""",
     type=str,

src/nectarchain/user_scripts/jlenain/dqm_job_submitter/submit_dqm_processor.py

@@ -21,15 +21,13 @@
 from DIRAC.Interfaces.API.Job import Job
 from DIRAC.Resources.Catalog.FileCatalogClient import FileCatalogClient
 
+from nectarchain.utils.constants import ALLOWED_CAMERAS
+
 logging.basicConfig(format="[%(levelname)s] %(message)s")
 logger = logging.getLogger(__name__)
 
 dirac = Dirac()
 
-prefix = "NectarCAM"
-cameras = [f"{prefix}" + "QM"]
-cameras.extend([f"{prefix+str(i)}" for i in range(2, 10)])
-
 # Option and argument parser
 parser = argparse.ArgumentParser(description="Submit jobs on DIRAC to run the DQM")
 parser.add_argument(
@@ -49,8 +47,8 @@
 parser.add_argument(
     "-c",
     "--camera",
-    choices=cameras,
-    default=[camera for camera in cameras if "QM" in camera][0],
+    choices=ALLOWED_CAMERAS,
+    default=[camera for camera in ALLOWED_CAMERAS if "QM" in camera][0],
     help="Process data for a specific NectarCAM camera. Default: Qualification Model.",
     type=str,
 )

src/nectarchain/user_scripts/jlenain/parse_dqm_fits_file.py

@@ -18,13 +18,11 @@
 from DIRAC.Interfaces.API.Dirac import Dirac
 
 from nectarchain.dqm.db_utils import DQMDB
+from nectarchain.utils.constants import ALLOWED_CAMERAS
 
 logging.basicConfig(format="[%(levelname)s] %(message)s")
 logger = logging.getLogger(__name__)
 
-prefix = "NectarCAM"
-cameras = [f"{prefix}" + "QM"]
-cameras.extend([f"{prefix+str(i)}" for i in range(2, 10)])
 
 # Option and argument parser
 parser = argparse.ArgumentParser(
@@ -55,8 +53,8 @@
 parser.add_argument(
     "-c",
     "--camera",
-    choices=cameras,
-    default=[camera for camera in cameras if "QM" in camera][0],
+    choices=ALLOWED_CAMERAS,
+    default=[camera for camera in ALLOWED_CAMERAS if "QM" in camera][0],
     help="Process data for a specific NectarCAM camera. Default: Qualification Model.",
     type=str,
 )

src/nectarchain/utils/constants.py

@@ -0,0 +1,8 @@
+def get_allowed_cameras():
+    prefix = "NectarCAM"
+    allowed_cameras = [f"{prefix}" + "QM"]
+    allowed_cameras.extend([f"{prefix + str(i)}" for i in range(2, 10)])
+    return allowed_cameras
+
+
+ALLOWED_CAMERAS = get_allowed_cameras()