-
Notifications
You must be signed in to change notification settings - Fork 20
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
The traitlet asked_pixels_id in FlatFieldSingleNominalSPENectarCAMComponent and PhotoStatisticNectarCAMComponent does not treat the correct pixels.
To Reproduce
Steps to reproduce the behavior:
- In a
config = traitlets.config.Config(), pass e.g.config["FlatFieldSingleNominalSPENectarCAMCalibrationTool"].asked_pixels_id = [100]. - Run the
FlatFieldSingleNominalSPENectarCAMCalibrationToolwith the aboveconfigfor run 3936 withmax_events=1000. - You will see during the SPE fit evaluation:
2025-10-10 08:26:45,421 INFO [nectarchain.makers.component.spe.spe_algorithm] (spe_algorithm.run_fit): creation of fit instance for pixel: 79
Expected behavior
The fit should be instantiated for pixel 100.
Additional context
Run 3936 only contains data for 1834/1855 pixels, i.e. 21 pixels are missing. So the difference in ID, 100 - 79 = 21, likely arises from this.
Note that similar stuff happens when applying the PhotoStatisticNectarCAMCalibrationTool. In any case, asked_pixels_id is defined both in FlatFieldSingleNominalSPENectarCAMComponent and PhotoStatisticNectarCAMComponent. Since it's a common trait, it should be defined in the parent GainNectarCAMComponent.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working